Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-24 Thread Henning Westerholt
Am Mittwoch, 23. Oktober 2013, 01:29:22 schrieb Charles Chance: Would you like to review the attached? [patch] Hi Charles, thank you - looks so far good to me. Could you maybe add also the doxygen documentation to the _compat function as well? Just copy the existing content and adapt it a

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-24 Thread Charles Chance
Now that we have backwards compatibility with older library versions, I guess I can remove the minimum requirement again from the docs - does anyone see a problem with doing so? Cheers, Charles On 24 October 2013 11:42, Henning Westerholt h...@kamailio.org wrote: Am Mittwoch, 23. Oktober

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-24 Thread Henning Westerholt
Am Donnerstag, 24. Oktober 2013, 15:43:10 schrieb Charles Chance: Now that we have backwards compatibility with older library versions, I guess I can remove the minimum requirement again from the docs - does anyone see a problem with doing so? Hi Charles, no, just revert the doc change again.

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-22 Thread Charles Chance
Henning, Would you like to review the attached? Regards, Charles On 21 October 2013 15:07, Dragos Oancea droan...@yahoo.com wrote: Hi all, Just wanted to say that any addition to the memcached module or its documentation is very useful to us. We use libmemcached-1.0.17 and as far as I

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Charles Chance
Hi Peter, The signatures of the custom memory allocator callbacks changed slightly in version 0.38 of libmemcached, so I believe this is the minimum required. Unfortunately it seems the version included in the EL6 base is still 0.31 :/ I can quickly add this info to the docs - is there still

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Peter Dunkley
Hello, I believe it is fine to amend or correct documentation during the freeze. It would certainly be helpful if the libmemcached requirement in the docs said version 0.38 or above. Regards, Peter On 21 October 2013 10:03, Charles Chance charles.cha...@sipcentric.comwrote: Hi Peter, The

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Henning Westerholt
Am Montag, 21. Oktober 2013, 10:03:46 schrieb Charles Chance: The signatures of the custom memory allocator callbacks changed slightly in version 0.38 of libmemcached, so I believe this is the minimum required. Unfortunately it seems the version included in the EL6 base is still 0.31 :/ I

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Charles Chance
Hi Henning, The library exports constants LIBMEMCACHED_VERSION_STRING and LIBMEMCACHED_VERSION_HEX so it seems it would be possible, if you think it's really necessary? I have updated the docs for now and will try to look more into it when I get a spare moment. Best regards, Charles On 21

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Peter Dunkley
Just my opinion, but this will allow CentOS and RedHat based systems to make sure of memcached. This would not be a bad thing if the change is easy to make. Regards, Peter On 21 October 2013 14:24, Charles Chance charles.cha...@sipcentric.comwrote: Hi Henning, The library exports

Re: [sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-21 Thread Dragos Oancea
Hi all, Just wanted to say that any addition to the memcached module or its documentation is very useful to us.  We use libmemcached-1.0.17 and as far as I know there is no CentOS RPM for it. Thank you, Charles! Regards, Dragos On Monday, October 21, 2013 3:24 PM, Charles Chance

[sr-dev] What version of memcached/libmemcached is needed for the memcached module in master?

2013-10-20 Thread Peter Dunkley
Hello, The memcached module cannot be built for stock Enterprise Linux 6 because the versions of libmemcached/memcached that come with EL6 are the wrong ones. Does anyone know what the right versions are, and is it worth updating the module documentation to specify them? That way if someone