Re: [sr-dev] couple of xavp questions

2012-12-12 Thread Daniel-Constantin Mierla
Hello, On 12/9/12 11:47 AM, Olle E. Johansson wrote: 9 dec 2012 kl. 11:09 skrev Andreas Granig agra...@sipwise.com: Hi, On 12/09/2012 10:54 AM, j...@tutpro.com wrote: Olle E. Johansson writes: In addition: Xavps are not as well documented as avps. We need to add something. There's a wiki

Re: [sr-dev] couple of xavp questions

2012-12-12 Thread Olle E. Johansson
12 dec 2012 kl. 10:28 skrev Daniel-Constantin Mierla mico...@gmail.com: Hello, On 12/9/12 11:47 AM, Olle E. Johansson wrote: 9 dec 2012 kl. 11:09 skrev Andreas Granig agra...@sipwise.com: Hi, On 12/09/2012 10:54 AM, j...@tutpro.com wrote: Olle E. Johansson writes: In addition:

Re: [sr-dev] couple of xavp questions

2012-12-10 Thread Daniel-Constantin Mierla
Hello, On 12/9/12 6:22 AM, j...@tutpro.com wrote: i'm trying to use xavps in new version of t serial functions and have a couple of questions: - when xavp value of type SR_XTYPE_STR is added using xavp_add_value function, do i need to make a copy of the string using pkg_malloc? in

Re: [sr-dev] couple of xavp questions

2012-12-10 Thread Alex Hermann
On Monday 10 December 2012 10:33:50 Daniel-Constantin Mierla wrote: On 12/9/12 6:22 AM, j...@tutpro.com wrote: i'm trying to use xavps in new version of t serial functions and have a couple of questions: - when xavp value of type SR_XTYPE_STR is added using xavp_add_value function,

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread Olle E. Johansson
9 dec 2012 kl. 06:22 skrev j...@tutpro.com: i'm trying to use xavps in new version of t serial functions and have a couple of questions: - when xavp value of type SR_XTYPE_STR is added using xavp_add_value function, do i need to make a copy of the string using pkg_malloc? in normal

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread jh
Olle E. Johansson writes: In addition: Xavps are not as well documented as avps. We need to add something. There's a wiki page with a proposal from Daniel, but I don't know if it documents the way it turned out in the code. yes, looks like currently both xavp api doc and xavp pseudo var

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread Andreas Granig
Hi, On 12/09/2012 10:54 AM, j...@tutpro.com wrote: Olle E. Johansson writes: In addition: Xavps are not as well documented as avps. We need to add something. There's a wiki page with a proposal from Daniel, but I don't know if it documents the way it turned out in the code. yes, looks

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread Olle E. Johansson
9 dec 2012 kl. 11:09 skrev Andreas Granig agra...@sipwise.com: Hi, On 12/09/2012 10:54 AM, j...@tutpro.com wrote: Olle E. Johansson writes: In addition: Xavps are not as well documented as avps. We need to add something. There's a wiki page with a proposal from Daniel, but I don't know

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread Olle E. Johansson
9 dec 2012 kl. 11:47 skrev Olle E. Johansson o...@edvina.net: 9 dec 2012 kl. 11:09 skrev Andreas Granig agra...@sipwise.com: Hi, On 12/09/2012 10:54 AM, j...@tutpro.com wrote: Olle E. Johansson writes: In addition: Xavps are not as well documented as avps. We need to add something.

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread Olle E. Johansson
9 dec 2012 kl. 11:52 skrev Olle E. Johansson o...@edvina.net: 9 dec 2012 kl. 11:47 skrev Olle E. Johansson o...@edvina.net: 9 dec 2012 kl. 11:09 skrev Andreas Granig agra...@sipwise.com: Hi, On 12/09/2012 10:54 AM, j...@tutpro.com wrote: Olle E. Johansson writes: In addition:

[sr-dev] couple of xavp questions

2012-12-09 Thread jh
wiki devel doc says about avp value: Generic data value It allows to store any type of data built in shared memory. but current modules that use xavp don't seem to do so. perhaps the wiki text is not up to date. it also uses api function xavp_add, which does not exist. and even if the doc

[sr-dev] couple of xavp questions

2012-12-09 Thread jh
as i mentioned, my proxy is crashing at timer after transaction when trying to free xavps: (gdb) where #0 xavp_destroy_list_unsafe (head=0xb4b07210) at xavp.c:354 #1 0xb68e2283 in free_cell (dead_cell=0xb4b065a8) at h_table.c:240 #2 0xb68fd7c9 in wait_handler (ti=1310418435,

[sr-dev] couple of xavp questions

2012-12-09 Thread jh
i got rid of the crash by changing xavp_rm(xavp, xavp_list); calls to xavp_rm(xavp, NULL); where xavp_list is xavp_list = xavp_get(contacts_avp, NULL); i.e., pointer to the first xavp with the given name, and xavp is also pointer to the first xavp in the list. looks like

Re: [sr-dev] couple of xavp questions

2012-12-09 Thread Olle E. Johansson
9 dec 2012 kl. 12:25 skrev j...@tutpro.com: wiki devel doc says about avp value: if you mean this page http://sip-router.org/wiki/devel/xavp It clearly says proposal. If there's another document I would like to get a pointer to it :-) If not, we need to make a page on the kamailio wiki that

[sr-dev] couple of xavp questions

2012-12-08 Thread jh
i'm trying to use xavps in new version of t serial functions and have a couple of questions: - when xavp value of type SR_XTYPE_STR is added using xavp_add_value function, do i need to make a copy of the string using pkg_malloc? in normal avps this is not needed, but for some reason a copy