Re: [sr-dev] git:master:6d87794c: ndb_redis: Added REDIS-Cluster support [BETA]

2017-04-04 Thread Carsten Bock
Hi Daniel, i've been testing it a little bit and it worked for me... I can use the same redis-Context from different workers without any issues. If it should fail badly for someone else, I can revert the commit; but however, it works for me. Thanks, Carsten 2017-04-04 17:02 GMT+02:00 Daniel-Cons

Re: [sr-dev] git:master:6d87794c: ndb_redis: Added REDIS-Cluster support [BETA]

2017-04-04 Thread Daniel-Constantin Mierla
Hi Carsten, On 04.04.17 14:43, Carsten Bock wrote: > Hi Daniel, > > i've just noticed, that in one line, I tried to free a reply from > shmem instead of pkgmem (fixed). ok, I see. > I only put the list of > REDIS-Connections into shmem, so other workers can access (and re-use) > the newly added

Re: [sr-dev] git:master:6d87794c: ndb_redis: Added REDIS-Cluster support [BETA]

2017-04-04 Thread Carsten Bock
Hi Daniel, i've just noticed, that in one line, I tried to free a reply from shmem instead of pkgmem (fixed). I only put the list of REDIS-Connections into shmem, so other workers can access (and re-use) the newly added connections to REDIS. Note to myself: I should add some locking to the list...

Re: [sr-dev] git:master:6d87794c: ndb_redis: Added REDIS-Cluster support [BETA]

2017-04-04 Thread Daniel-Constantin Mierla
Hello, I haven't checked the merged version, but if I spotted correctly from the patch, it moves the redis response structure in shared memory. Is is right? If yes, why? Having it in shared memory will create races between kamailio processes that store results on same container id -- one worker c

[sr-dev] git:master:6d87794c: ndb_redis: Added REDIS-Cluster support [BETA]

2017-04-04 Thread Carsten Bock
Module: kamailio Branch: master Commit: 6d87794cac3f6f3bb967d6e0bf6714a4d78f1bd5 URL: https://github.com/kamailio/kamailio/commit/6d87794cac3f6f3bb967d6e0bf6714a4d78f1bd5 Author: Carsten Bock Committer: Carsten Bock Date: 2017-04-04T12:55:26+02:00 ndb_redis: Added REDIS-Cluster support [BETA]