Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-20 Thread Daniel-Constantin Mierla
- >>> From: "Daniel-Constantin Mierla" <mico...@gmail.com> >>> To: "Kamailio (SER) - Users Mailing List" <sr-users@lists.kamailio.org>, >>> "Andrew Pogrebennyk" <apogreben...@sipwise.com> >>> Sent: Frida

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-20 Thread Marco Capetta
- Original Message - From: "Daniel-Constantin Mierla" <mico...@gmail.com> To: "Kamailio (SER) - Users Mailing List" <sr-users@lists.kamailio.org>, "Andrew Pogrebennyk" <apogreben...@sipwise.com> Sent: Friday, November 10, 2017 9:48:29

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-13 Thread Marco Capetta
...@gmail.com> To: "Kamailio (SER) - Users Mailing List" <sr-users@lists.kamailio.org>, "Andrew Pogrebennyk" <apogreben...@sipwise.com> Sent: Friday, November 10, 2017 9:48:29 AM Subject: Re: [SR-Users] 183 acc records even if early_media equals to 0 On 10.1

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-10 Thread Daniel-Constantin Mierla
On 10.11.17 09:42, Andrew Pogrebennyk wrote: > On 11/10/2017 09:34 AM, Marco Capetta wrote: >> +   >> if(relayed_msg->REPLY_STATUS==uas_rb->activ_type) { >> +   >> run_trans_callbacks_with_buf( TMCB_RESPONSE_OUT,

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-10 Thread Andrew Pogrebennyk
On 11/10/2017 09:34 AM, Marco Capetta wrote: > +   > if(relayed_msg->REPLY_STATUS==uas_rb->activ_type) { > +   > run_trans_callbacks_with_buf( TMCB_RESPONSE_OUT, uas_rb, t->uas.request, > +  

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-10 Thread Marco Capetta
Hi Daniel, due to other internal patches, the line number are a bit different. The issue seems located at the point where the patch was applied: --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -1965,8 +1965,10 @@ enum rps relay_reply( struct cell *t, st     if

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Marco Capetta
Thanks. Patch applied on the test system with kamailio 4.4.6. Just for documentation, an additional difference with 5.X is that variable  "TMCB_NONE_F" is called "relayed_code". I will leave the system running and I let you know if the issue is solved. Thanks Marco On 11/09/2017 04:18 PM,

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Daniel-Constantin Mierla
Forgot to add that for branch 4.4, the changes should be for line 1952 in modules/tm/t_reply.c On 09.11.17 16:06, Daniel-Constantin Mierla wrote: > > I just pushed to master, here is the link to the diff: > >   - >

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Daniel-Constantin Mierla
I just pushed to master, here is the link to the diff:   - https://github.com/kamailio/kamailio/commit/785a3ccc743f429107c3dfae78d43705918aa4e6.diff It will help to see if what I found was the source for the issue. If yes, there might be another patch to have a proper handling of the situation.

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Marco Capetta
Yes, I have a test system where I can deploy the patch. Thank you very much Marco On 11/09/2017 03:09 PM, Daniel-Constantin Mierla wrote: Are you able to reproduce as you need in a testbed or so? I may have a small patch and wondering if you would be able to test? Cheers, Daniel On

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Daniel-Constantin Mierla
Are you able to reproduce as you need in a testbed or so? I may have a small patch and wondering if you would be able to test? Cheers, Daniel On 09.11.17 14:32, Marco Capetta wrote: > I have the same issue on 4.4.5 and 4.4.6 > > Thanks > Marco > > On 11/09/2017 02:22 PM, Daniel-Constantin

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Marco Capetta
I have the same issue on 4.4.5 and 4.4.6 Thanks Marco On 11/09/2017 02:22 PM, Daniel-Constantin Mierla wrote: One more thing, have you seen it in latest versions from branch 4.4.x? Or was it on 4.4.1 only? Or from other perspective, on which versions you noticed this kind of issues?

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Daniel-Constantin Mierla
One more thing, have you seen it in latest versions from branch 4.4.x? Or was it on 4.4.1 only? Or from other perspective, on which versions you noticed this kind of issues? Cheers, Daniel On 09.11.17 14:02, Marco Capetta wrote: > Thank Daniel. > > Cheers > Marco > > On 11/09/2017 12:38 PM,

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Marco Capetta
Thank Daniel. Cheers Marco On 11/09/2017 12:38 PM, Daniel-Constantin Mierla wrote: Hello, I expect that the code value is taken from status of the transaction, which at that time has 200ok ranked with more priority. I will check the code and if it proves to be this case, I will come up

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Daniel-Constantin Mierla
Hello, I expect that the code value is taken from status of the transaction, which at that time has 200ok ranked with more priority. I will check the code and if it proves to be this case, I will come up with a fix. Cheers, Daniel On 09.11.17 10:42, Marco Capetta wrote: > Hello, > > no we

Re: [SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Daniel-Constantin Mierla
Hello, On 09.11.17 09:50, Marco Capetta wrote: > Dear All, > > I'm facing a strange problem with the call accounting module: even if > in my configuration I have the parameter: > modparam("acc", "early_media", 0) > I can find some ACC records with sip_code 180 or 183. > > > I investigated

[SR-Users] 183 acc records even if early_media equals to 0

2017-11-09 Thread Marco Capetta
Dear All, I'm facing a strange problem with the call accounting module: even if in my configuration I have the parameter: modparam("acc", "early_media", 0) I can find some ACC records with sip_code 180 or 183. I investigated those cases and this issue seems to happen when an endpoint