For now, I pushed the new uptime statistic to follow the naming
convention that was in place:
https://www.kamailio.org/docs/modules/devel/modules/xhttp_prom.html#xhttp_prom.p.xhttp_prom_uptime_stat
We could implement the following naming convention:
# This is the modparam for
; Henning
Westerholt
Subject: Re: [SR-Users] Re: RFC: uptime metric for xhttp_prom module
CAUTION: This email originated from outside the organization. Do not click
links or open attachments unless you recognize the sender and know the content
is safe.
Hi Ben,
You made m
imes, so:
> modparam("xhttp_prom", "stats", "stats.get_statistics sl:")
> modparam("xhttp_prom", "stats", "stats.get_statistics core:")
> modparam("xhttp_prom", "stats", "pkg.stats")
>
dparam("xhttp_prom", "stats", "corex.uptime")
Would get all sl module counters, all core module counters, the uptime and the
package memory stats for each child process. An advantage here is that other
counters can be implemented without any real thought to synt
Hello Henning,
I have nothing against using a single variable, except that it is confusing.
It is not backward compatible. If you enable all vars, then all new
stats will be enabled by default.
In the current stable version, the names of the stats vars and stats
groups are inherited from the
Hello Ovidiu,
nothing against it from my side. I would recommend using the existing variable
" xhttp_prom_stats" for activating/deactivation. Just think we should not
introduce to many single purpose variables, especially for a value which is
always available without any dependencies.
Cheers,
