Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-06-08 Thread Juha Heinanen
I let compile go through all modules that I use and noticed that now also tls module warning are gone! That is great. The only remaining ones are on cfg/cfg_ctx. -- Juha CC (gcc) [sip-proxy]cfg/cfg_ctx.o cfg/cfg_ctx.c: In function 'cfg_set_now': cfg/cfg_ctx.c:485:5: warning:

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-06-08 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > Can you try with master branch and see if the warning for tlsf malloc > disappeared? I changed the prototypes of malloc functions to use size_t > to be compatible with standard malloc(). Changes are only in master branch. The warning are now gone: CC (gcc)

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-06-08 Thread Daniel-Constantin Mierla
Can you try with master branch and see if the warning for tlsf malloc disappeared? I changed the prototypes of malloc functions to use size_t to be compatible with standard malloc(). Changes are only in master branch. Cheers, Daniel On 21/05/16 22:11, Juha Heinanen wrote: > I'll come back to

[SR-Users] 4.4 compiler warnings on debian jessie

2016-05-21 Thread Juha Heinanen
I'll come back to mem/tlsf_malloc.c issue. Camille asked if the compiler warnings on mem/tlsf_malloc.c were occurring on x86 32 bit machine. I now tried and, yes, they do not appear on i386 jessie, but not on amd64 jessie. So looks like this is the same issue that Ovidiu has reported. -- Juha

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-12 Thread Camille Oudot
Le Thu, 12 May 2016 12:30:15 +0300, Juha Heinanen a écrit : > I did 'apt-get dist-upgrade'. The following packages were upgraded > and the mem/tlsf_malloc.c warnings went away: > > apt apt-utils base-files gnupg gpgv libapt-inst1.5 libapt-pkg4.12 > libc-bin libc-dev-bin libc6

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-12 Thread Camille Oudot
Le Thu, 12 May 2016 12:03:59 +0300, Juha Heinanen a écrit : > Perhaps it has to do with some other defines. Do you remember what > to add to debian/rules in order to see all gcc parameters during > compilation? I add "Q=0" on the make command line to see the full compiler's

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-12 Thread Juha Heinanen
Juha Heinanen writes: > I have the same. Perhaps it has to do with some other defines. Do you > remember what to add to debian/rules in order to see all gcc parameters > during compilation? I did 'apt-get dist-upgrade'. The following packages were upgraded and the mem/tlsf_malloc.c warnings

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-12 Thread Juha Heinanen
Camille Oudot writes: > I'm also compiling on Debian 8, x86_64-linux-gnu architecture, but > cannot see these warnings, whether I run > > make MEMDBG=0 cfg > > or > > make MEMDBG=1 cfg > > before compiling. My gcc version is 4.9.2 (Debian 4.9.2-10). I have the same. Perhaps it has

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-12 Thread Camille Oudot
Hi, > > All I see is that we are assigning a > > void* (*)(tlsf_t, size_t) > > to a > > void* (*)(void* , unsigned long) > > yet tlsf_t is defined as `typedef void* tlsf_t`, and size_t and > > unsigned long have the same width on this architecture... > > Is that true also when

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-12 Thread Ovidiu Sas
If you have a patch, I can test it for you. -ovidiu On May 11, 2016 10:56, wrote: > > debian jessie c compiler complains about these in kamailio 4.4: > > > > CC (gcc) [sip-proxy]mem/tlsf_malloc.o > > mem/tlsf_malloc.c: In function

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-11 Thread Juha Heinanen
camille.ou...@orange.com writes: > All I see is that we are assigning a > void* (*)(tlsf_t, size_t) > to a > void* (*)(void* , unsigned long) > yet tlsf_t is defined as `typedef void* tlsf_t`, and size_t and unsigned long > have the same width on this architecture... Is that true also

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-11 Thread Juha Heinanen
camille.ou...@orange.com writes: > is this happening on a x86 32 bits machine? I'm getting the warning in x86_64-linux-gnu environment. > Do compiling with clang generates an error too? If yes, is the error message > more specific about the issue? I don't clang. -- Juha

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-11 Thread camille.oudot
> debian jessie c compiler complains about these in kamailio 4.4: > > CC (gcc) [sip-proxy]mem/tlsf_malloc.o > mem/tlsf_malloc.c: In function 'tlsf_malloc_init_pkg_manager': > mem/tlsf_malloc.c:1353:16: warning: assignment from incompatible pointer type > ma.xmalloc= tlsf_malloc;

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-11 Thread Juha Heinanen
Daniel-Constantin Mierla writes: > we try to address the warnings as soon as possible, but sometime is a > matter of resources. The author of the tlsf code is Camille, which may > have some vacation, be traveling or really busy with other things -- it > is less than one day since you reported.

Re: [SR-Users] 4.4 compiler warnings on debian jessie

2016-05-11 Thread Daniel-Constantin Mierla
Hello Juha, we try to address the warnings as soon as possible, but sometime is a matter of resources. The author of the tlsf code is Camille, which may have some vacation, be traveling or really busy with other things -- it is less than one day since you reported. Also, others may not have

[SR-Users] 4.4 compiler warnings on debian jessie

2016-05-11 Thread Juha Heinanen
I have not got any comments about getting rid of 4.4 compiler warnings in mem/tlsf_malloc.c. I'm afraid that if such warnings are tolerated, it will soon be difficult to distinguish real problems from all the warning noise during. In my opinion, a sign of high quality software project is that no