Re: [SR-Users] A question about the code

2016-05-03 Thread Daniel-Constantin Mierla
On 04/05/16 08:18, Alex Balashov wrote: > On 05/04/2016 02:09 AM, Daniel-Constantin Mierla wrote: > >> the new code example doesn't do exactly like the old one > > D'oh! You're right. I was careless in my analysis of that statement, > and didn't see that the negation was on the outside. > > It sou

Re: [SR-Users] A question about the code

2016-05-03 Thread Alex Balashov
On 05/04/2016 02:09 AM, Daniel-Constantin Mierla wrote: the new code example doesn't do exactly like the old one D'oh! You're right. I was careless in my analysis of that statement, and didn't see that the negation was on the outside. It sounds like the GRUU-related commit that introduced t

Re: [SR-Users] A question about the code

2016-05-03 Thread Daniel-Constantin Mierla
Hello, Alex is right, but the new code example doesn't do exactly like the old one ... On 04/05/16 06:19, Alex Balashov wrote: > Nathan, > > I think this is actually deliberate. The return value of an assignment > operation is always going to be true, so it's just an "overly clever" > way of comp

Re: [SR-Users] A question about the code

2016-05-03 Thread Alex Balashov
Nathan, I think this is actually deliberate. The return value of an assignment operation is always going to be true, so it's just an "overly clever" way of compactly setting the value of 'ret' to -2 within the same conditional evaluation. The aim there is compactness, though it does obscure

[SR-Users] A question about the code

2016-05-03 Thread ngregory
Greetings,I am a Kamailio user trying to get more deeply familiar with the platform. I have been digging through the code and spotted something that just seems wrong. I am not really a programmer (I dabble some, but...) so did not want to go down the path of reporting a bug, at least not just yet.