Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-12 Thread Daniel-Constantin Mierla
On 10/08/15 09:49, Juha Heinanen wrote: Daniel-Constantin Mierla writes: iirc, based on what was discussed on the mailing list, at least in some cases, the full sdp is sent to rtpengine and then full sdp would be returned. That is clear, but which full sdp: the original one or the one

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-12 Thread Juha Heinanen
Camille Oudot writes: i've created a merge request on the master branch to add the rtpengine input SDP pv. I'm not sure if modifying sdpops to work also on variables would be straightforward, but anyway, most operations can be done using transformations. thanks. yes, i looked at some sdpops

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-11 Thread Camille Oudot
Le Mon, 10 Aug 2015 18:33:47 +0200, Daniel Tryba d.tr...@pocos.nl a écrit : Only strange thing is that $var(sdp) is set to 0 on on the second passing of below during branch routing after handling a 302 redirect I don't know the full context here, but since $var()s are process-local, is the

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-11 Thread Camille Oudot
Le Mon, 10 Aug 2015 16:25:36 +0300, Juha Heinanen j...@tutpro.com a écrit : i think it would be useful especially if sdpops functions could also be made operate on the pv. then there would no need to call msg_apply_changes(). the pv could be initialized from $rb and when all calls that

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Camille Oudot
Le Mon, 10 Aug 2015 17:12:22 +0200, Daniel Tryba d.tr...@pocos.nl a écrit : But I'm still not getting how it works. The avp is always null (request/reply and onsend routes) after using rtpengine_manage. Does it really only work with rtpengine_(offer|answer)? I'm to lazy to replace _manage :)

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Daniel Tryba
On Monday 10 August 2015 19:23:26 Camille Oudot wrote: Should be working with rtpengine_manage() too. Can you see any meaningful log, while initializing the rtpengine module, or during the rtpengine_manage() call? If no pvar is set, then is the body of the SIP message modified with the new

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Camille Oudot
Le Mon, 10 Aug 2015 13:00:19 +0200, Daniel Tryba d.tr...@pocos.nl a écrit : 315 being modparam(rtpengine, write_sdp_avp, $avp(sdp)) version: kamailio 4.3.1 (x86_64/linux) you have to use the name write_sdp_pv, not ..._avp -- Camille ___ SIP

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Camille Oudot
Le Mon, 10 Aug 2015 12:38:57 +0300, Juha Heinanen j...@tutpro.com a écrit : if the pvar is set, will rtpengine use its value also as input when rtpengine_offer/answer is called? the current behaviour is to use this pvar for output only (the current message buffer will still be used as an

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Juha Heinanen
Camille Oudot writes: There is a `write_sdp_pv` parameter in the rtpengine module that makes rtpengine return the new SDP in a variable rather than in the message body. Personally I find it's more convenient to transform a variable several times than working directly on the message buffer and

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Camille Oudot
Le Mon, 10 Aug 2015 10:49:10 +0300, Juha Heinanen j...@tutpro.com a écrit : Daniel-Constantin Mierla writes: You should use msg_apply_changes() in between them in order to have previous changes visible for further processing. Do you mean that msg_apply_changes() needs to be called

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Juha Heinanen
Daniel-Constantin Mierla writes: iirc, based on what was discussed on the mailing list, at least in some cases, the full sdp is sent to rtpengine and then full sdp would be returned. That is clear, but which full sdp: the original one or the one changed by previous sdpops calls? It doesn't

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Daniel-Constantin Mierla
Hello, iirc, based on what was discussed on the mailing list, at least in some cases, the full sdp is sent to rtpengine and then full sdp would be returned. It doesn't do any use of sdpops module. You should use msg_apply_changes() in between them in order to have previous changes visible for

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Daniel Tryba
On Monday 10 August 2015 12:24:10 Camille Oudot wrote: There is a `write_sdp_pv` parameter in the rtpengine module that makes rtpengine return the new SDP in a variable rather than in the message body. How does that work? Setting the parameter like in the module doc results in: 0(21343)

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Camille Oudot
Le Mon, 10 Aug 2015 16:47:55 +0200, Camille Oudot camille.ou...@orange.com a écrit : Le Mon, 10 Aug 2015 13:00:19 +0200, Daniel Tryba d.tr...@pocos.nl a écrit : 315 being modparam(rtpengine, write_sdp_avp, $avp(sdp)) version: kamailio 4.3.1 (x86_64/linux) you have to use the name

Re: [SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-10 Thread Juha Heinanen
Camille Oudot writes: the current behaviour is to use this pvar for output only (the current message buffer will still be used as an input), but we could extend it to be used for input also if this is useful. i think it would be useful especially if sdpops functions could also be made operate

[SR-Users] sdp manipulation in connection with rtpengine_offer/answer calls

2015-08-09 Thread Juha Heinanen
it was not clear to me based on rtpengine module readme if rtpengine_offer/answer are same kind of sdp manipulation functions as, for example, sdpops module functions, i.e., will rtpengine functions pass to rtpengine the sdp as it is after possible earlier sdpops function calls and will possible