[SR-Users] siputils: E164 check is broken

2015-01-12 Thread Seudin Kasumovic
Hi, The fix below is wrong, condition must be '<' instead of '<='. https://github.com/kamailio/kamailio/commit/fbcfa198a2c89868fa021f6a63774425e480b27b and backported in 4.2 https://github.com/kamailio/kamailio/commit/2d1032b3c8a1184357615b37da99dfd76526afa7#diff-d7b03e3862e552e90fe6f958ec0f3a12

Re: [SR-Users] siputils: E164 check is broken

2015-01-12 Thread Daniel-Constantin Mierla
Hello, that fix was actually changing: if (c < '0' && c > '9') return -1; to: if (c < '0' || c > '9') return -1; The rest was auto-indentation by the editor. Providing the details of like or pasting the code where you refer would make it easier to understand what do you mean, but I guess you

Re: [SR-Users] siputils: E164 check is broken

2015-01-12 Thread Seudin Kasumovic
Hi Daniel, Yes. Improper length check. Regards, Seudin On Mon, Jan 12, 2015 at 3:44 PM, Daniel-Constantin Mierla wrote: > Hello, > > that fix was actually changing: > > if (c < '0' && c > '9') return -1; > > to: > > if (c < '0' || c > '9') return -1; > > The rest was auto-indentation by the e