Re: [SSSD] New Try to build SSSD on Karmic both as of 2009.08.04

2009-08-10 Thread Mathias Gug
Hi, On Fri, Aug 7, 2009 at 11:25 AM, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/07/2009 10:40 AM, Miguel P.C. wrote: >> Hi again, >> >>> International testing is always a good thing. On a related note, if you >>> would like to try your hand at translating

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Martin Nagy
Dmitri Pal wrote: > Stephen Gallagher wrote: > > On 08/10/2009 08:36 AM, Dmitri Pal wrote: > > > Martin Nagy wrote: > > >> On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher > > >> wrote: > > >> > > >> > > >>> -BEGIN PGP SIGNED MESSAGE- > > >>> Hash: SHA1 > > >>> > > >>> On 08/10/200

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 02:15 PM, Dmitri Pal wrote: >>> Thanks for review! New patches are attached. >>> Ack. Waiting for a reply from Jakub as well before pushing these patches. - -- Stephen Gallagher RHCE 804006346421761 Loo

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-10 Thread Dmitri Pal
Thanks for review. I did not include the file because it is empty. I would rather remove references to it. The patch will be sent shortly. > > > This code fails to build successfully. > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../common/elapi > -I../../../common/elapi/.. -I../../../common

Re: [SSSD] [PATCH] Revert build-breaking libsss_util_la change.

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 02:00 PM, Simo Sorce wrote: > On Mon, 2009-08-10 at 13:56 -0400, Stephen Gallagher wrote: >> Moving the common utility sources into a libtool convenience library >> caused problems with symbols when loading the plugin libraries. >> >> Thi

Re: [SSSD] [PATCH] fix ldap enumeration when user are out of range

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 01:59 PM, Stephen Gallagher wrote: > On 08/10/2009 01:15 PM, Simo Sorce wrote: >> return ERANGE and ignore if the user is to be excluded because of range >> filters. > >> Simo. > > >> ---

Re: [SSSD] [PATCH] Revert build-breaking libsss_util_la change.

2009-08-10 Thread Simo Sorce
On Mon, 2009-08-10 at 13:56 -0400, Stephen Gallagher wrote: > Moving the common utility sources into a libtool convenience library > caused problems with symbols when loading the plugin libraries. > > This is a straight revert of 00aa07816bfd4305ac94780a8c2b9e6609be39ea > except leaving the "make

Re: [SSSD] [Freeipa-devel] [PATCHES] one for INI another for ELAPI

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Comments on the reply inline, followed by new review comments at the end. On 08/07/2009 06:25 PM, Dmitri Pal wrote: >> Nack. >> >> Please squash the patch "ELAPI Adding Core Functionality" into this >> second patch. Neither one makes sense without the

Re: [SSSD] [PATCH] fix ldap enumeration when user are out of range

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 01:15 PM, Simo Sorce wrote: > return ERANGE and ignore if the user is to be excluded because of range > filters. > > Simo. > > > > >

[SSSD] [PATCH] Revert build-breaking libsss_util_la change.

2009-08-10 Thread Stephen Gallagher
Moving the common utility sources into a libtool convenience library caused problems with symbols when loading the plugin libraries. This is a straight revert of 00aa07816bfd4305ac94780a8c2b9e6609be39ea except leaving the "make check" logic in place. -- Stephen Gallagher RHCE 804006346421761 Loo

[SSSD] [PATCH] fix ldap enumeration when user are out of range

2009-08-10 Thread Simo Sorce
return ERANGE and ignore if the user is to be excluded because of range filters. Simo. 0001-Do-not-fail-enumerations-because-of-range-checks.patch Description: application/mbox ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedor

Re: [SSSD] [PATCH] Add configure checks for docbook XSL templates and XML tools

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 11:30 AM, Jakub Hrozek wrote: > See attachment, this should make diagnosing problems with missing > packages easier. > > Jakub Ack and pushed to master. -

Re: [SSSD] sssd [PATCH] Make socket paths a compile-time option

2009-08-10 Thread Stephen Gallagher
On 08/10/2009 10:57 AM, Stephen Gallagher wrote: > On 08/10/2009 09:58 AM, Stephen Gallagher wrote: >> On 08/10/2009 09:56 AM, Simo Sorce wrote: >>> On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote: %define servicename sssd +%define sssdstatedir %{_localstatedir}/lib/sss

Re: [SSSD] sssd Planning for SSSD 0.5.0 and beyond

2009-08-10 Thread Mathias Gug
Hi, On Thu, Aug 6, 2009 at 9:46 AM, Stephen Gallagher wrote: >> It seems that it may make more sense to maintain the debian packaging >> bits in a different branch. I've already setup an import of the git >> branch on LP [1]. My proposal is to maintain the debian packaging >> branch there as a bra

[SSSD] [PATCH] Add configure checks for docbook XSL templates and XML tools

2009-08-10 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 See attachment, this should make diagnosing problems with missing packages easier. Jakub -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqAPQUACgkQHs

Re: [SSSD] sssd [PATCH] Make socket paths a compile-time option

2009-08-10 Thread Stephen Gallagher
On 08/10/2009 09:58 AM, Stephen Gallagher wrote: > On 08/10/2009 09:56 AM, Simo Sorce wrote: >> On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote: >>> >>> %define servicename sssd >>> +%define sssdstatedir %{_localstatedir}/lib/sss >>> +%define dbpath %{sssdstatedir}/db >>> +%define pip

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Dmitri Pal
Stephen Gallagher wrote: > On 08/10/2009 08:36 AM, Dmitri Pal wrote: > > Martin Nagy wrote: > >> On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher > >> wrote: > >> > >> > >>> -BEGIN PGP SIGNED MESSAGE- > >>> Hash: SHA1 > >>> > >>> On 08/10/2009 03:38 AM, Martin Nagy wrote: > >>>

Re: [SSSD] [PATCH] Build and run SSSD tests with 'make check'

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 10:28 AM, Jakub Hrozek wrote: > On 08/05/2009 09:51 PM, Stephen Gallagher wrote: >> Be more compliant with GNU coding standards. Our unit and system tests >> will now be built and run by 'make check' instead of as part of our >> standard

Re: [SSSD] [PATCH] Build and run SSSD tests with 'make check'

2009-08-10 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/05/2009 09:51 PM, Stephen Gallagher wrote: > Be more compliant with GNU coding standards. Our unit and system tests > will now be built and run by 'make check' instead of as part of our > standard build. > > > > When --enable-tests is set by c

Re: [SSSD] sssd [PATCH] Make socket paths a compile-time option

2009-08-10 Thread Stephen Gallagher
On 08/10/2009 09:56 AM, Simo Sorce wrote: > On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote: >> >> %define servicename sssd >> +%define sssdstatedir %{_localstatedir}/lib/sss >> +%define dbpath %{sssdstatedir}/db >> +%define pipepath %{sssdstatedir}/lib/sss/pipes > > nack > > pipepa

Re: [SSSD] sssd [PATCH] Make socket paths a compile-time option

2009-08-10 Thread Simo Sorce
On Thu, 2009-08-06 at 14:16 -0400, Stephen Gallagher wrote: > > %define servicename sssd > +%define sssdstatedir %{_localstatedir}/lib/sss > +%define dbpath %{sssdstatedir}/db > +%define pipepath %{sssdstatedir}/lib/sss/pipes nack pipepath is wrong: as is resolves to /var/lib/sss/lib/sss/pipe

Re: [SSSD] [PATCHES] Cleanup, compact and simplify some sbus code

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 09:37 AM, Stephen Gallagher wrote: > On 08/06/2009 05:47 AM, Simo Sorce wrote: >> This set of patches is the result of my taking a second look at the sbus >> code. One of the driving factors was the removal of talloc_reference() >> given

Re: [SSSD] [PATCHES] Cleanup, compact and simplify some sbus code

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/2009 05:47 AM, Simo Sorce wrote: > This set of patches is the result of my taking a second look at the sbus > code. One of the driving factors was the removal of talloc_reference() > given the uncertainty about this API upstream. > > During t

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 08:36 AM, Dmitri Pal wrote: > Martin Nagy wrote: >> On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher >> wrote: >> >> >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 08/10/2009 03:38 AM, Martin Nagy wrote: >>>

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Dmitri Pal
Martin Nagy wrote: > On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher > wrote: > > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 08/10/2009 03:38 AM, Martin Nagy wrote: >> >>> On Fri, 07 Aug 2009 13:59:49 -0400, Stephen Gallagher >>> wrote: >>> When the bac

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Martin Nagy
On Mon, 10 Aug 2009 06:52:11 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 08/10/2009 03:38 AM, Martin Nagy wrote: > > On Fri, 07 Aug 2009 13:59:49 -0400, Stephen Gallagher > > wrote: > >> When the backends start up, the monitor was immediately sending

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/10/2009 03:38 AM, Martin Nagy wrote: > On Fri, 07 Aug 2009 13:59:49 -0400, Stephen Gallagher > wrote: >> When the backends start up, the monitor was immediately sending a >> getIdentity request. However, as we've added more processing to >> the

Re: [SSSD] [PATCH] Fix startup race condition causing backend restarts

2009-08-10 Thread Martin Nagy
On Fri, 07 Aug 2009 13:59:49 -0400, Stephen Gallagher wrote: > When the backends start up, the monitor was immediately sending a > getIdentity request. However, as we've added more processing to > the initialization routines over time, we started introducing > latency between when we open the conn