[SSSD] INI and ELAPI tickets

Hi, I have opened several tickets regarding ELAPI and INI. They are tickets 140-143. Please take a look. Note the priorities. Comments and suggestions are welcome. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. --- Looking to carve out IT co

Re: [SSSD] [PATCHES] python bindings for managing users in local domains

On Wed, 2009-08-26 at 11:01 +0200, Jakub Hrozek wrote: > One more change, while working on #138 I realized that the copyright > headers were incorrect -- I had a GPLv2 header in my personal c source > file template, while the rest of the project uses GPLv3. > > I also squashed in a fix for a typo

Re: [SSSD] [PATCH] check if gid attribute is empty

On Fri, 2009-08-28 at 11:49 +0200, Sumit Bose wrote: > this patch just makes sure that the LDAP backend does not die if the > group object returned by the LDAP server does not contain a gid. In a > previous patch I have sent the same fix for uid/gid in a returned user > object, but have forgotten t

Re: [SSSD] [PATCH] fix internal order of ldap user mapping options

On Fri, 2009-08-28 at 13:55 +0200, Sumit Bose wrote: > > a previous patch added a new attribute and also changed the internal > order of the existing attributes. This patch changes the numbering of > the attributes to match the new order. I wonder how it worked without this patch. Full ACK and p

Re: [SSSD] [PATCH] send SSSD_REALM and SSSD_KDCIP environment to the client

On Fri, 2009-08-28 at 13:44 +0200, Sumit Bose wrote: > On Fri, Aug 28, 2009 at 12:16:51PM +0200, Sumit Bose wrote: > > Hi, > > > > the environment variable which are send back by this patch are > currently > > needed in the user session of the client. When the DNS helper is > > available and used

Re: [SSSD] [PATCH] Speed up NSS enumeration code

On Fri, 2009-08-28 at 12:03 +0200, Sumit Bose wrote: > On Thu, Aug 27, 2009 at 01:58:15PM -0400, Simo Sorce wrote: > > This patch should make the enumeration code ~ O(log n) instead of > O(n) > > > > On my system it brought enumeration down from 12s to 4s with the > same > > data set. > > > > Al

Re: [SSSD] [Freeipa-devel] [PATCH] add configure check for errno_t

On Fri, 2009-08-28 at 11:53 +0200, Sumit Bose wrote: > > Sumit, > > I can't do a successful build with this patch, it says errno_t is > > re-defined in sss_cli.h when parsing util.h > > > > Does it depend on other patches ? > > Can you check it again against current master ? > > > > ah, sorry, t

Re: [SSSD] [PATCH] ELAPI sinks and providers

> > > I do not see any of those comments to be critical (unless of cause > > others do). > > I would prefer opening tickets to improve different areas and work on > > them later and take this patch as is. > > Any concerns or objections? > > No, none of this was critical, more like things I noticed

[SSSD] [PATCH] fix internal order of ldap user mapping options

Hi, a previous patch added a new attribute and also changed the internal order of the existing attributes. This patch changes the numbering of the attributes to match the new order. bye, Sumit >From a4e1484f0dc9297f9c609196e4356e97d244ad14 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Fri, 28

Re: [SSSD] [PATCH] send SSSD_REALM and SSSD_KDCIP environment to the client

On Fri, Aug 28, 2009 at 12:16:51PM +0200, Sumit Bose wrote: > Hi, > > the environment variable which are send back by this patch are currently > needed in the user session of the client. When the DNS helper is > available and used by the kerberos locator plugin they can be removed. > > bye, > Sum

[SSSD] [PATCH] send SSSD_REALM and SSSD_KDCIP environment to the client

Hi, the environment variable which are send back by this patch are currently needed in the user session of the client. When the DNS helper is available and used by the kerberos locator plugin they can be removed. bye, Sumit >From 8cc4ea16832b5997bb74d20f12ef5d8505c05e73 Mon Sep 17 00:00:00 2001 F

Re: [SSSD] [PATCH] Speed up NSS enumeration code

On Thu, Aug 27, 2009 at 01:58:15PM -0400, Simo Sorce wrote: > This patch should make the enumeration code ~ O(log n) instead of O(n) > > On my system it brought enumeration down from 12s to 4s with the same > data set. > Although I haven't measured it I see a speed-up, too. I have only one issu

Re: [SSSD] [Freeipa-devel] [PATCH] add configure check for errno_t

On Thu, Aug 27, 2009 at 09:38:14AM -0400, Simo Sorce wrote: > On Wed, 2009-08-26 at 13:25 +0200, Sumit Bose wrote: > > > > I have include the check in the sss_client directory, but I'm > > reluctant > > to add it to common, too. IMO the maintainers of the packages should > > decide if errno_t make

[SSSD] [PATCH] check if gid attribute is empty

Hi, this patch just makes sure that the LDAP backend does not die if the group object returned by the LDAP server does not contain a gid. In a previous patch I have sent the same fix for uid/gid in a returned user object, but have forgotten the group object. bye, Sumit >From a9a1c7e26b919c2edb6fa

Re: [SSSD] [PATCH] ELAPI sinks and providers

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > Thank you for the review. > My comments are inline. > >> Couple of comments: >> * Instead of putting libprovider.la into _SOURCES, maybe you wanted to >> add it to libelapi_la_LIBADD? >> > I consulted Steve on this one and showed him the makefile. >