Hi,
this patch adds some autotols cleanups.
bye,
Sumit
From 9775390adcaa7ad42f78930d9ffa5bbadb85cff5 Mon Sep 17 00:00:00 2001
From: Sumit Bose sb...@redhat.com
Date: Mon, 7 Sep 2009 18:06:21 +0200
Subject: [PATCH] fix libdbus configure check
- remove unneeded CFLAGS component
- do not leak
Hi,
valgrind told me that the sockaddr_in structure might be used
uninitialized. This patch fixes this and adds some debugging messages I
found useful to follow the usage of the plugin.
bye,
Sumit
From be17f8cefb0b2485fde334d60eddd3dababa1fb1 Mon Sep 17 00:00:00 2001
From: Sumit Bose
I can see only two warnings:
On Fri, Sep 04, 2009 at 07:32:40PM -0400, Dmitri Pal wrote:
Steve,
I ran a build today and saw some unpleasant warnings especially about
the uninitialized variables.
../../server/providers/ldap/sdap_async.c: In function
'sdap_get_users_save_done':
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/07/2009 07:38 AM, Jakub Hrozek wrote:
On 09/03/2009 02:27 AM, Dmitri Pal wrote:
Hi,
This patch is next significant chunk of code.
See patch comments for the main description.
It requires previous patch that has been reviewed but was not
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/07/2009 10:05 AM, Jakub Hrozek wrote:
On 09/05/2009 02:32 AM, Dmitri Pal wrote:
See patch comment.
This patch most likely will not apply cleanly without my previous ELAPI
patches.
So far it is 4 th pending patch.
More to come.
In
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 05:04 AM, Sumit Bose wrote:
Hi,
this patch adds some autotols cleanups.
bye,
Sumit
___
sssd-devel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 05:12 AM, Sumit Bose wrote:
Hi,
valgrind told me that the sockaddr_in structure might be used
uninitialized. This patch fixes this and adds some debugging messages I
found useful to follow the usage of the plugin.
bye,
Sumit
On Fri, Sep 04, 2009 at 06:02:09PM -0400, Simo Sorce wrote:
Hello list.
So far we have been using a single database file for all our caches as
well as for the local domain.
Initially I used a single database because I thought we could optimize
some search queries when it came to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 08/17/2009 10:30 AM, Stephen Gallagher wrote:
On 08/13/2009 07:34 PM, Karsten Wade wrote:
On Tue, Aug 11, 2009 at 06:09:24AM -0400, Simo Sorce wrote:
Given we use git it doesn't seem a great match.
If the Fedora facility do upgrade to the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I agree with Sumit's review, but I'd rather see his concerns addressed
in this patch, rather than in subsequent patches.
On 09/08/2009 07:04 AM, Sumit Bose wrote:
On Fri, Sep 04, 2009 at 06:02:09PM -0400, Simo Sorce wrote:
Hello list.
So far we
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 08:41 AM, Dmitri Pal wrote:
Thank you for review, comments inline.
Stephen Gallagher wrote:
On 09/07/2009 10:05 AM, Jakub Hrozek wrote:
On 09/05/2009 02:32 AM, Dmitri Pal wrote:
See patch comment.
This patch most likely will not
I am unclear about couple things here:
a) Is my solution acceptable for the given situation?
b) If not what is the preferred solution?
c) What is different about the given typecast and why this typecast
suppresses
warning (if it does) while others do not?
Please advise.
I think
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 05:12 AM, Sumit Bose wrote:
Hi,
valgrind told me that the sockaddr_in structure might be used
uninitialized. This patch fixes this and adds some debugging messages I
found useful to follow the usage of the plugin.
bye,
Sumit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 05:04 AM, Sumit Bose wrote:
Hi,
this patch adds some autotols cleanups.
bye,
Sumit
___
sssd-devel
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
The attached patch applies on top of Simo's two patches.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAkqmZcgACgkQHsardTLnvCWRbgCePRy9eDg32BZIW0DVu4NYJNGk
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 03:19 PM, Dmitri Pal wrote:
3) file_csv_data_len
I do not like the magic constants like 20 and such in the switch. I
would prefer #defining them as named constants.
Ok will do.
Martin also had this cool idea of using something
On Tue, 2009-09-08 at 16:10 +0200, Jakub Hrozek wrote:
The attached patch applies on top of Simo's two patches.
ack,
patch seem to work fin on top of my latest ones too.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
___
sssd-devel mailing list
On Tue, 2009-09-08 at 12:21 +0200, Sumit Bose wrote:
../../server/responder/nss/nsssrv_cmd.c: In function ‘fill_grent’:
../../server/responder/nss/nsssrv_cmd.c:1371: warning: ‘i’ may be
used
uninitialized in this function
The value of count might have an unexpected value, but in this
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 06:21 AM, Sumit Bose wrote:
I can see only two warnings:
On Fri, Sep 04, 2009 at 07:32:40PM -0400, Dmitri Pal wrote:
Steve,
I ran a build today and saw some unpleasant warnings especially about
the uninitialized variables.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 03:01 PM, Stephen Gallagher wrote:
On 09/08/2009 02:36 PM, Simo Sorce wrote:
On Tue, 2009-09-08 at 12:21 +0200, Sumit Bose wrote:
../../server/responder/nss/nsssrv_cmd.c: In function fill_grent:
On Tue, 2009-09-08 at 15:11 -0400, Stephen Gallagher wrote:
Merged Sumit's fix for the sdap timestamp = NULL into this patch and
pushed.
I hope you merged it in the proper patch ;-)
Simo.
--
Simo Sorce * Red Hat, Inc * New York
___
sssd-devel
Hi,
This patch corrects (hopefully last) set of issues found in the earlier
patches during review.
The ones that are not addressed yet are tracked via explicit tickets or
via FIXME
comments in the code.
The whole stack of the pending patches is:
* ELAPI sinks and providers
* ELAPI Adding file
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 06:47 AM, Stephen Gallagher wrote:
On 09/07/2009 08:05 AM, Jakub Hrozek wrote:
On 08/28/2009 11:40 AM, Jakub Hrozek wrote:
No, none of this was critical, more like things I noticed reading the code.
FWIW, while reviewing the ELAPI
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 06:45 PM, Dmitri Pal wrote:
Hi,
This patch corrects (hopefully last) set of issues found in the earlier
patches during review.
The ones that are not addressed yet are tracked via explicit tickets or
via FIXME
comments in the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 07:23 PM, Stephen Gallagher wrote:
On 09/08/2009 06:45 PM, Dmitri Pal wrote:
Hi,
This patch corrects (hopefully last) set of issues found in the earlier
patches during review.
The ones that are not addressed yet are tracked via
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/08/2009 09:19 AM, Dmitri Pal wrote:
Sorry for the belated review, the patch is big and took me some time to
read and digest.
My comments:
1) elapi_basic.h:40
#define SEDO struct elapi_data_out
I personally don't like this, this seems
I have refactored nsssrv_cmd.c and created a new patch for the
EntryCacheNoWaitRefreshTimeout.
I have created a new function, check_cache() which is a common entry
point for getpwnam, getpwuid, getgrnam and getgrgid to examine whether
the cache is still valid.
Addressing other points from the
27 matches
Mail list logo
