Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/13/2009 10:31 AM, Simo Sorce wrote: With this patch all the backend providers can share the same offline status. This means composite backends like what AD or IPA will be that use a mix of ldap and krb can share the offline status for both

Re: [SSSD] [PATCH] Make basic options typed

2009-09-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/13/2009 10:38 AM, Simo Sorce wrote: This patch finally allows us to define the type for basic options. It uses a union to store different types, and an enum to list the allowed types. It also provides for helper functions that always check

Re: [SSSD] [PATCH] Make basic options typed

2009-09-14 Thread Sumit Bose
On Mon, Sep 14, 2009 at 08:03:14AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/13/2009 10:38 AM, Simo Sorce wrote: This patch finally allows us to define the type for basic options. It uses a union to store different types, and an enum to list the

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 07:48 -0400, Stephen Gallagher wrote: Just a nitpick, but why did you replace sbus_conn_send_reply() in be_check_online with sbus_get_connection and dbus_connection_send()? They are functionally identical. (except that sbus_conn_send_reply() can get the connection in one

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Sumit Bose
On Mon, Sep 14, 2009 at 11:30:44AM -0400, Simo Sorce wrote: On Mon, 2009-09-14 at 07:48 -0400, Stephen Gallagher wrote: Just a nitpick, but why did you replace sbus_conn_send_reply() in be_check_online with sbus_get_connection and dbus_connection_send()? They are functionally identical.

Re: [SSSD] [PATCH 1/3] Let the PAM client send its PID -- 2nd version

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 10:09 +0200, Sumit Bose wrote: Hi, this is the new version of the cli_pid patch with the missing size added. There are two related patches. 0002 removes the unused client locale. It was added at a time where we talked about generating all messages the client should

Re: [SSSD] [PATCH] Make basic options typed

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 18:21 +0200, Sumit Bose wrote: On Mon, Sep 14, 2009 at 11:32:40AM -0400, Simo Sorce wrote: On Mon, 2009-09-14 at 14:34 +0200, Sumit Bose wrote: Nack. Generates a segfault running getent passwd u...@ldap I cannot reproduce this with my setup, but

Re: [SSSD] [PATCH] Make offline status backend global

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 18:10 +0200, Sumit Bose wrote: I agree, this patch is a good starting point and we can add fine tuning later. ACK. pushed Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list

Re: [SSSD] [PATCH 1/3] Let the PAM client send its PID -- 2nd version

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 11:36 -0400, Simo Sorce wrote: On Mon, 2009-09-14 at 10:09 +0200, Sumit Bose wrote: Hi, this is the new version of the cli_pid patch with the missing size added. There are two related patches. 0002 removes the unused client locale. It was added at a time where

Re: [SSSD] [PATCH] add krb5ccache_dir and krb5ccname_template option

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 13:32 +0200, Sumit Bose wrote: Hi, this patch add two new option to make the Kerberos provider of sssd more compatible with pam_krb5. rebased to apply over the other patches (there was only some fuzz, had to change no code), acked and pushed. There are some warnings

Re: [SSSD] [PATCH] fix the wrong usage of an offset

2009-09-14 Thread Simo Sorce
On Mon, 2009-09-14 at 21:26 +0200, Sumit Bose wrote: Hi, I hadn't checked a last minute change properly with the result that the detection if mkstemp should be used or not is broken. This patch should fix this. tested, acked, pushed Simo. -- Simo Sorce * Red Hat, Inc * New York

[SSSD] [PATCH] added child timeout handler

2009-09-14 Thread Sumit Bose
Hi, this patch adds a timeout handling for the kerberos children. If a child needs omre then krb5auth_timeout seconds to send a response it is killed and the baclend is marked offline. bye, Sumit From 4104863d945c66e947f47af6cde9141646bf51ce Mon Sep 17 00:00:00 2001 From: Sumit Bose