Hi,
Spotted some dhash warnings. Seems like worth fixing especially
shadowing ones...
dhash_test.c: In function ‘main’:
dhash_test.c:288: warning: declaration of ‘i’ shadows a previous local
dhash_test.c:115: warning: shadowed declaration is here
dhash_test.c:312: warning: declaration of ‘i’ shad
Dmitri Pal wrote:
> See patch comments for details.
> All three are not massive.
> 1) Comparison and sorting collections
> 2) Taking part of the code from long module and putting it into a new
> module for readability
> 3) Adding new functionality to the module created in previous patch
>
>
> --
Jakub Hrozek wrote:
> On 09/15/2009 09:20 PM, Dmitri Pal wrote:
> > 1) Comparison and sorting collections
>
> Did you maybe forget to git-add a file? Makefile.am references
> collection_cmp.c but that file is in none of the patches.
>
> Jakub
Thank you, yes I will resend.
_
Simo Sorce wrote:
> On Wed, 2009-09-16 at 14:33 -0400, Stephen Gallagher wrote:
>
>> Dmitri, it's a very simple change that will be very easy to resolve
>> with
>> 'git rebase' and 'git mergetool'.
>>
>> There's no reason that a complete fix should be held back for the
>> convenience of any one
On Wed, 2009-09-16 at 08:48 -0400, Simo Sorce wrote:
> > Please make it a macro or a subroutine instead of adding it three
> times.
>
> Yeah, will do.
Ok new patches attached, with members debug turned into a macro.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
>From b11ab80038ec140b0b6e5a4dfa
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/15/2009 09:20 PM, Dmitri Pal wrote:
> 1) Comparison and sorting collections
Did you maybe forget to git-add a file? Makefile.am references
collection_cmp.c but that file is in none of the patches.
Jakub
-BEGIN PGP SIGNATURE-
Ver
On Wed, 2009-09-16 at 14:33 -0400, Stephen Gallagher wrote:
> Dmitri, it's a very simple change that will be very easy to resolve
> with
> 'git rebase' and 'git mergetool'.
>
> There's no reason that a complete fix should be held back for the
> convenience of any one developer.
>
> Also, no. The
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 02:41 PM, Sumit Bose wrote:
> On Wed, Sep 16, 2009 at 02:29:09PM -0400, Stephen Gallagher wrote:
>> On 09/16/2009 01:29 PM, Stephen Gallagher wrote:
>>> On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
I haven't gotten Transifex to s
On Wed, Sep 16, 2009 at 02:29:09PM -0400, Stephen Gallagher wrote:
> On 09/16/2009 01:29 PM, Stephen Gallagher wrote:
> > On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
> >> I haven't gotten Transifex to send the patches to the sssd-devel list
> >> yet, so I'm forwarding this one on manually for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Dmitri, it's a very simple change that will be very easy to resolve with
'git rebase' and 'git mergetool'.
There's no reason that a complete fix should be held back for the
convenience of any one developer.
Also, no. The upstream SSSD repository is o
On 09/16/2009 01:29 PM, Stephen Gallagher wrote:
> On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
>> I haven't gotten Transifex to send the patches to the sssd-devel list
>> yet, so I'm forwarding this one on manually for the moment.
>
>> I give it an Ack, and a thank-you to Piotr Drg
>
>
>
Guys,
This is great, thank you for finding it.
But this will really mess up my merges.
Can it be undone?
Also I have a ticket open to explicitly return to this part of code and
sort things out with valgrind.
Thanks for finding the answer and cause of the problem, it will make the
fixes simple
but
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 11:53 AM, Stephen Gallagher wrote:
> On 09/16/2009 11:52 AM, Jakub Hrozek wrote:
>> On 09/16/2009 05:35 PM, Martin Nagy wrote:
>>> Obviously, valgrind was producing warnings precisely because of the bug
>>> that Jakub's patch fixes. There
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
> I haven't gotten Transifex to send the patches to the sssd-devel list
> yet, so I'm forwarding this one on manually for the moment.
>
> I give it an Ack, and a thank-you to Piotr Drąg
>
>
>
>
> --
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 07:32 AM, Stephen Gallagher wrote:
> On 09/16/2009 07:21 AM, Sumit Bose wrote:
>> Hi,
>
>> authentication via LDAPS currently fails, see bug #183. This patch
>> should fix it.
>
>> bye,
>> Sumit
>
>
>>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 11:52 AM, Jakub Hrozek wrote:
> On 09/16/2009 05:35 PM, Martin Nagy wrote:
>> Obviously, valgrind was producing warnings precisely because of the bug
>> that Jakub's patch fixes. Therefore it was right to complain. I think
>> the right th
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 05:35 PM, Martin Nagy wrote:
> Obviously, valgrind was producing warnings precisely because of the bug
> that Jakub's patch fixes. Therefore it was right to complain. I think
> the right thing to do right now is to remove all the explicit
I haven't gotten Transifex to send the patches to the sssd-devel list
yet, so I'm forwarding this one on manually for the moment.
I give it an Ack, and a thank-you to Piotr Drąg
--
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
From eff9496a
Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 09/16/2009 11:08 AM, Jakub Hrozek wrote:
> > The memset size_t parameter was wrong and the async_ctx param was not
> > manually zeroed resulting in random segfaults when the structure was freed.
> >
> > Jakub
>
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 05:16 PM, Stephen Gallagher wrote:
> If you're memsetting handle, then you don't need to also explicitly set
> handle->async_ctx (or any of the other pointers) to NULL.
>
> If Valgrind is later complaining that testing for NULL is an uni
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 11:08 AM, Jakub Hrozek wrote:
> The memset size_t parameter was wrong and the async_ctx param was not
> manually zeroed resulting in random segfaults when the structure was freed.
>
> Jakub
If you're memsetting handle, then you d
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
The memset size_t parameter was wrong and the async_ctx param was not
manually zeroed resulting in random segfaults when the structure was freed.
Jakub
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with F
On Wed, 2009-09-16 at 13:27 +0200, Sumit Bose wrote:
> On Tue, Sep 15, 2009 at 05:49:49PM -0400, Simo Sorce wrote:
> > This patch "should" fix a bug seen today in the wild concerning the
> > proxy provider.
> > I say should because I was not able to reproduce the bug in the first
> > place, but fro
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 07:21 AM, Sumit Bose wrote:
> Hi,
>
> authentication via LDAPS currently fails, see bug #183. This patch
> should fix it.
>
> bye,
> Sumit
>
>
>
>
> ___
On Tue, Sep 15, 2009 at 05:49:49PM -0400, Simo Sorce wrote:
> This patch "should" fix a bug seen today in the wild concerning the
> proxy provider.
> I say should because I was not able to reproduce the bug in the first
> place, but from the debug I've seen this should fix it.
>
> Simo.
ACK for 1
Hi,
authentication via LDAPS currently fails, see bug #183. This patch
should fix it.
bye,
Sumit
>From fe00b098f55e12e3ebb3e3a2f51a32e8b3919d67 Mon Sep 17 00:00:00 2001
From: Sumit Bose
Date: Wed, 16 Sep 2009 13:02:47 +0200
Subject: [PATCH] Check if SSL/TLS handler is already in place
Authentic
26 matches
Mail list logo
