Re: [SSSD] [PATCH] Package SSSDConfig API

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 17:21 -0400, Stephen Gallagher wrote: "" ACK -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Package SSSDConfig API

2009-10-12 Thread Stephen Gallagher
-- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From f5db2669075b92a636098c65d9e7acf630e87eb6 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Mon, 12 Oct 2009 17:20:22 -0400 Subject: [PATCH] Package SSSDConfig API --- contrib/sssd.

Re: [SSSD] [PATCH] fix startup of services

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 03:01 PM, Simo Sorce wrote: > When only LOCAL is configured I forgot to mark the services started at > startup, so they were started twice. > > Simo. > > > > > ___ > sssd-devel mailing list

[SSSD] [PATCH] fix startup of services

2009-10-12 Thread Simo Sorce
When only LOCAL is configured I forgot to mark the services started at startup, so they were started twice. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 06e29cdf515715646b8c273a17672ba98165a27a Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Mon, 12 Oct 2009 08:55:24 -0400 Subject: [PATC

Re: [SSSD] [PATCH] LDAP provider needs to link against krb libraries

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 06:32 AM, Sumit Bose wrote: > On Mon, Oct 12, 2009 at 12:20:37PM +0200, Ralf Haferkamp wrote: >> Hi, >> >> since the LDAP provider does calls into the krb5 libs it should also be >> linked >> against them :). Attached patch should fix t

Re: [SSSD] [PATCH] fix a wrong argument to unpack_buffer

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 07:48 AM, Stephen Gallagher wrote: > On 10/12/2009 06:35 AM, Sumit Bose wrote: >> Hi, > >> Martin was so nice to point me to a bug introduced by the short read >> patch. This patch should fix it. > >> bye, >> Sumit > > > >> _

Re: [SSSD] [PATCH] Add SSSDConfig python API

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 02:11 PM, Simo Sorce wrote: > On Mon, 2009-10-12 at 13:54 -0400, Stephen Gallagher wrote: >> >> New patch attached. > > Looks good to me. > > Ack. > > Simo. Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Looking to c

Re: [SSSD] [PATCH] Add SSSDConfig python API

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 13:54 -0400, Stephen Gallagher wrote: > > New patch attached. Looks good to me. Ack. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/l

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Sumit Bose
On Mon, Oct 12, 2009 at 12:10:43PM -0400, Dmitri Pal wrote: > Simo Sorce wrote: > > On Mon, 2009-10-12 at 10:47 -0400, Dmitri Pal wrote: > > > > > Just pass the fd to the client, it's simple and doesn't require us to > replicate logic to open/close debug files in the children. >

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Dmitri Pal
Simo Sorce wrote: > On Mon, 2009-10-12 at 12:10 -0400, Dmitri Pal wrote: > >> Yes this way it is standard. I thought you wanted to pass a socket >> between processes later after fork. >> But here is the question. If you have multiple children writing to the >> same fd at the same time how you th

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 12:10 -0400, Dmitri Pal wrote: > Yes this way it is standard. I thought you wanted to pass a socket > between processes later after fork. > But here is the question. If you have multiple children writing to the > same fd at the same time how you then sort which one has written

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Dmitri Pal
Simo Sorce wrote: > On Mon, 2009-10-12 at 10:47 -0400, Dmitri Pal wrote: > > Just pass the fd to the client, it's simple and doesn't require us to replicate logic to open/close debug files in the children. >>> I didn't realize you could do that. >>> >>> >> I am not

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 10:47 -0400, Dmitri Pal wrote: > > > Just pass the fd to the client, it's simple and doesn't require us to > > > replicate logic to open/close debug files in the children. > > > > I didn't realize you could do that. > > > > I am not sure this approach is portable. > I know S

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Dmitri Pal
Stephen Gallagher wrote: > On 10/12/2009 10:29 AM, Simo Sorce wrote: > > On Mon, 2009-10-12 at 09:49 -0400, Stephen Gallagher wrote: > >> This is what the ELAPI is for. > > No ELAPI is for logging not for the debug stuff, and an api can't > > overcome file permissions no more than anything else. >

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 10:29 AM, Simo Sorce wrote: > On Mon, 2009-10-12 at 09:49 -0400, Stephen Gallagher wrote: >> This is what the ELAPI is for. > > No ELAPI is for logging not for the debug stuff, and an api can't > overcome file permissions no more than an

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 09:49 -0400, Stephen Gallagher wrote: > This is what the ELAPI is for. No ELAPI is for logging not for the debug stuff, and an api can't overcome file permissions no more than anything else. Just pass the fd to the client, it's simple and doesn't require us to replicate logi

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 15:46 +0200, Sumit Bose wrote: > There is a problem with --debug-to-files. krb5_child runs as the user > requesting the ticket so the path to krb5_child.log needs to have > matching permissions. A possible solution would be to create the file > with 666 permissions during the

Re: [SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 09:46 AM, Sumit Bose wrote: > Hi, > > Although there are lots of DEBUG calls in krb5_child it always runs with > debug_level=0. This patch starts krb5_child with the debugging options > of the backend. > > There is a problem with --debu

[SSSD] [PATCH] enable debugging of krb5_child

2009-10-12 Thread Sumit Bose
Hi, Although there are lots of DEBUG calls in krb5_child it always runs with debug_level=0. This patch starts krb5_child with the debugging options of the backend. There is a problem with --debug-to-files. krb5_child runs as the user requesting the ticket so the path to krb5_child.log needs to ha

Re: [SSSD] [PATCH] use old password if available during password change

2009-10-12 Thread Simo Sorce
On Mon, 2009-10-12 at 14:49 +0200, Sumit Bose wrote: > > Do they skip checks or ignore if the provided password is valid or > not ? > > Should we think of forking a child in proxy and running it as the > user > > that is attempting the password change? (Assuming we know it ?) > > I think forking i

Re: [SSSD] [PATCH] use old password if available during password change

2009-10-12 Thread Sumit Bose
On Fri, Oct 09, 2009 at 04:29:42PM -0400, Simo Sorce wrote: > On Fri, 2009-10-09 at 21:02 +0200, Sumit Bose wrote: > > Hi, > > > > this one should fix #223. Because sshd runs as root the old password > > was > > not sent to sssd and changing the user password failed. Please review > > carefully. >

Re: [SSSD] [PATCH] fix a wrong argument to unpack_buffer

2009-10-12 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2009 06:35 AM, Sumit Bose wrote: > Hi, > > Martin was so nice to point me to a bug introduced by the short read > patch. This patch should fix it. > > bye, > Sumit > > > > ___ > sssd-devel maili

[SSSD] [PATCH] fix a wrong argument to unpack_buffer

2009-10-12 Thread Sumit Bose
Hi, Martin was so nice to point me to a bug introduced by the short read patch. This patch should fix it. bye, Sumit >From 190ac953255966ad49d915f9ce6741543a3fa824 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Mon, 12 Oct 2009 12:13:36 +0200 Subject: [PATCH] fix a wrong argument to unpack_buff

Re: [SSSD] [PATCH] LDAP provider needs to link against krb libraries

2009-10-12 Thread Sumit Bose
On Mon, Oct 12, 2009 at 12:20:37PM +0200, Ralf Haferkamp wrote: > Hi, > > since the LDAP provider does calls into the krb5 libs it should also be > linked > against them :). Attached patch should fix that. > > -- > regards, > Ralf Obviously correct. ACK Thanks. bye, Sumit __

[SSSD] [PATCH] LDAP provider needs to link against krb libraries

2009-10-12 Thread Ralf Haferkamp
Hi, since the LDAP provider does calls into the krb5 libs it should also be linked against them :). Attached patch should fix that. -- regards, Ralf From 6169242cc432b48d86eaae03fbee52af69527860 Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Mon, 12 Oct 2009 11:50:30 +0200 Subject

Re: [SSSD] [PATCH] Fix error messages in tools

2009-10-12 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2009 08:29 PM, Stephen Gallagher wrote: > Nack after all. Jenny noticed that there are some places where the > returned error code should be nonzero and it is not. > > Please fix these up and resubmit. I looked at the test cases and I think