Re: [SSSD] [PATCH] User home directories management

2009-10-22 Thread Martin Nagy
On Wed, 2009-10-21 at 20:30 +0200, Jakub Hrozek wrote: In main(): +switch (ret) { +case 'G': +groups = poptGetOptArg(pc); +if (!groups) { +ret = -1; +break; +} + +

Re: [SSSD] [PATCH] User home directories management

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 07:20 AM, Martin Nagy wrote: On Wed, 2009-10-21 at 20:30 +0200, Jakub Hrozek wrote: In main(): +switch (ret) { +case 'G': +groups = poptGetOptArg(pc); +if (!groups) { +

Re: [SSSD] [PATCH] fix offline detection/enumeration behavior in ldap_id

2009-10-22 Thread Simo Sorce
On Thu, 2009-10-22 at 08:20 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 01:33 AM, Simo Sorce wrote: I was seeing the ipa backend blocking on start trying to contact the KDC and when failing not going offline, causing some applications (su -)

Re: [SSSD] [PATCH] fix offline detection/enumeration behavior in ldap_id

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 09:35 AM, Simo Sorce wrote: On Thu, 2009-10-22 at 08:20 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 01:33 AM, Simo Sorce wrote: I was seeing the ipa backend blocking on start trying

Re: [SSSD] [PATCHES] Fix resolv bugs and improve test coverage

2009-10-22 Thread Simo Sorce
On Wed, 2009-10-21 at 14:29 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 12:24 PM, Martin Nagy wrote: Hi, the first patch breaks the test, the third one fixes them. The second one contains couple of functions that I found handy for test

Re: [SSSD] [PATCH] Add support for offline auth cache timeout

2009-10-22 Thread Stephen Gallagher
On 10/20/2009 06:04 PM, Stephen Gallagher wrote: I was extending it to behave the same way that the NSS responder does. Previously we didn't have any PAM-specific confdb options, so we never had a global PAM context. On Oct 20, 2009, at 4:52 PM, Simo Sorce sso...@redhat.com wrote: On Tue,

Re: [SSSD] [PATCH] Bring SSSDConfig API options up-to-date

2009-10-22 Thread Simo Sorce
On Thu, 2009-10-22 at 12:02 -0400, Stephen Gallagher wrote: Simo reviewed on IRC and realized that I was missing the 'chpass' type for the LDAP provider. I added this, and also updated the unit test to more gracefully handle changes in the control_provider_dict. Ack Simo. -- Simo Sorce *

Re: [SSSD] [PATCH] Add support for offline auth cache timeout

2009-10-22 Thread Stephen Gallagher
On 10/22/2009 12:04 PM, Stephen Gallagher wrote: On 10/20/2009 06:04 PM, Stephen Gallagher wrote: I was extending it to behave the same way that the NSS responder does. Previously we didn't have any PAM-specific confdb options, so we never had a global PAM context. On Oct 20, 2009, at 4:52

[SSSD] fix setting schema in ipa provider

2009-10-22 Thread Simo Sorce
one liner -- Simo Sorce * Red Hat, Inc * New York From 86e1b6c35ed196140f25235a3e1a9610133696fc Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Thu, 22 Oct 2009 12:33:14 -0400 Subject: [PATCH] Fix setting the schema in the ipa provider --- server/providers/ipa/ipa_common.c |

Re: [SSSD] fix setting schema in ipa provider

2009-10-22 Thread Sumit Bose
On Thu, Oct 22, 2009 at 12:39:57PM -0400, Simo Sorce wrote: one liner -- Simo Sorce * Red Hat, Inc * New York From 86e1b6c35ed196140f25235a3e1a9610133696fc Mon Sep 17 00:00:00 2001 From: Simo Sorce sso...@redhat.com Date: Thu, 22 Oct 2009 12:33:14 -0400 Subject: [PATCH] Fix setting the

Re: [SSSD] [PATCH] added generic LDAP search sdap_get_generic_send/_recv

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/20/2009 07:38 PM, Simo Sorce wrote: On Mon, 2009-10-19 at 14:45 +0200, Sumit Bose wrote: done, new patch attached. ack Simo. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Use correct talloc context in sss_names_init()

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 12:31 PM, Stephen Gallagher wrote: On 10/21/2009 12:17 PM, Martin Nagy wrote: Martin ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Fix potential memory leaks in the data provider

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 12:49 PM, Stephen Gallagher wrote: On 10/21/2009 12:18 PM, Martin Nagy wrote: Martin ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Resolver: Use talloc_get_type() for type safety

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 12:50 PM, Stephen Gallagher wrote: On 10/21/2009 12:19 PM, Martin Nagy wrote: Martin ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] add store/search/delete interface for custom sysdb objects

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 09:28 AM, Simo Sorce wrote: On Thu, 2009-10-22 at 12:22 +0200, Sumit Bose wrote: ok, the attached version adds new objects or replaces existing and adds new attributes to existing objects. I like this version. Ack Simo.

Re: [SSSD] [PATCH] fix offline detection/enumeration behavior in ldap_id

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 09:37 AM, Stephen Gallagher wrote: On 10/22/2009 09:35 AM, Simo Sorce wrote: On Thu, 2009-10-22 at 08:20 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 01:33 AM, Simo Sorce wrote: I was

Re: [SSSD] [PATCH] Fix up header file names in util.h and add sssd-i18n.h

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 04:59 PM, Stephen Gallagher wrote: On 10/21/2009 04:26 PM, Martin Nagy wrote: Martin Nagy wrote: On Tue, 2009-10-20 at 23:36 -0400, Simo Sorce wrote: On Wed, 2009-10-21 at 20:21 +0200, Martin Nagy wrote: On Tue, 2009-10-20 at 22:16

Re: [SSSD] [PATCH] New option code for krb5 and ipa auth

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 02:15 PM, Sumit Bose wrote: On Tue, Oct 20, 2009 at 07:20:51PM -0400, Simo Sorce wrote: On Tue, 2009-10-20 at 14:24 +0200, Sumit Bose wrote: +dummy = dp_opt_get_cstring(opts, KRB5_CHANGEPW_PRINC); +if (strchr(dummy, '@') ==

Re: [SSSD] [PATCHES] Fix resolv bugs and improve test coverage

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 10:37 AM, Simo Sorce wrote: On Wed, 2009-10-21 at 14:29 -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/21/2009 12:24 PM, Martin Nagy wrote: Hi, the first patch breaks the test, the third one

Re: [SSSD] [PATCH] Bring SSSDConfig API options up-to-date

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 12:08 PM, Simo Sorce wrote: On Thu, 2009-10-22 at 12:02 -0400, Stephen Gallagher wrote: Simo reviewed on IRC and realized that I was missing the 'chpass' type for the LDAP provider. I added this, and also updated the unit test to

Re: [SSSD] fix setting schema in ipa provider

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 01:46 PM, Sumit Bose wrote: On Thu, Oct 22, 2009 at 12:39:57PM -0400, Simo Sorce wrote: one liner -- Simo Sorce * Red Hat, Inc * New York From 86e1b6c35ed196140f25235a3e1a9610133696fc Mon Sep 17 00:00:00 2001 From: Simo Sorce

Re: [SSSD] [PATCH] User home directories management

2009-10-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/22/2009 01:53 PM, Martin Nagy wrote: On Thu, 2009-10-22 at 19:48 +0200, Jakub Hrozek wrote: A more serious bug I see in files.c: +while ((cnt = read(ifd, buf, sizeof(buf))) 0) { +while (cnt 0) { +written =

Re: [SSSD] [PATCH] Add support for offline auth cache timeout

2009-10-22 Thread Simo Sorce
On Thu, 2009-10-22 at 12:09 -0400, Stephen Gallagher wrote: Whoops, forgot to convert days to seconds. New patch 0004 attached. ack to both. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org