Re: [SSSD] [PATCH] Support logrotate for SSSD DEBUG logs

2010-03-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2010 06:50 PM, Stephen Gallagher wrote: > Jakub, I think you may have sent the wrong patch. 0001 does not apply > cleanly on top of the current master. Please check your rebase. Sorry for the inconvenience, it looks I have sent the first patc

Re: [SSSD] [PATCH] Do not run negative resolv test with no network

2010-03-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2010 06:27 PM, Jakub Hrozek wrote: > The attached patch also moves the localhost test into the networked > tests so we can safely build on systems that lack the localhost > definition in /etc/hosts. > > Also prints a warning when running in n

Re: [SSSD] [PATCH] Support logrotate for SSSD DEBUG logs

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/2010 10:00 AM, Jakub Hrozek wrote: > On 02/26/2010 05:33 PM, Stephen Gallagher wrote: >> Nack. > >> This is partly my fault. update_monitor_config() is broken and >> dangerous. I thought I had disabled all access to it. I didn't realize >> it

Re: [SSSD] [PATCH] unbreak setting debug_timestamps to 0

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2010 06:43 AM, Jakub Hrozek wrote: > On 03/03/2010 09:32 PM, Simo Sorce wrote: > >> See patch. > > > ACK Pushed to master and 1-1-0 - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value

Re: [SSSD] [PATCH] Add forgotten \n in DEBUG statements

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/03/2010 07:58 AM, Jakub Hrozek wrote: > On 03/03/2010 09:31 AM, Martin Nagy wrote: >> Logs from confdb with missing '\n' in the DEBUG statements annoyed me so >> I decided to fix them. I also made a quick grep through the code and >> found other

Re: [SSSD] [PATCH] Make confdb_init's confdb_location parameter const

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/03/2010 07:24 AM, Jakub Hrozek wrote: > On 03/03/2010 09:29 AM, Martin Nagy wrote: >> SSIA > >> Martin > > Pushed to master and 1-1-0 - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value

Re: [SSSD] [PATCH] Fully eliminate live reconfiguration

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/2010 08:18 AM, Jakub Hrozek wrote: > On 03/02/2010 01:40 PM, Stephen Gallagher wrote: >> Jakub, please review > > > Looks good to me, ACK. > >> and if you ack this, rebase your logrotate patch >> atop it. > > > Will do! Pushed to master

Re: [SSSD] [PATCH] Add --with-test-dir option to configure

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/02/2010 07:39 AM, Sumit Bose wrote: > On Tue, Mar 02, 2010 at 07:24:27AM -0500, Stephen Gallagher wrote: > On 03/02/2010 07:20 AM, Sumit Bose wrote: > ahh, sorry, NACK, there is another #ifdef SYSDB_TEST where ABS_BUILD_DIR needs

Re: [SSSD] [Transifex] File submitted via email to SSSD | master

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/26/2010 07:50 AM, Stephen Gallagher wrote: > On 02/25/2010 02:07 PM, ad...@transifex.net wrote: >> Hello sssd, this is Transifex at http://www.transifex.net. > >> The following attached files were submitted to SSSD | master by ruigo >> > >>

Re: [SSSD] [Transifex] File submitted via email to SSSD | master

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/26/2010 07:50 AM, Stephen Gallagher wrote: > On 02/25/2010 02:15 PM, ad...@transifex.net wrote: >> Hello sssd, this is Transifex at http://www.transifex.net. > >> The following attached files were submitted to SSSD | master by raven >> > >>

Re: [SSSD] [PATCH] Define _GNU_SOURCE in pam_sss.c.

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/01/2010 05:18 AM, Sumit Bose wrote: > On Fri, Feb 26, 2010 at 12:07:29PM -0600, George McCollister wrote: >> Hi, >> >> The latest version of sssd failed to compile for me until I applied this >> patch. >> >> Regards, >> George McCollister > > AC

Re: [SSSD] [PATCH] Run 'make check' during rpmbuild

2010-03-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/01/2010 05:18 AM, Sumit Bose wrote: > On Fri, Feb 26, 2010 at 12:25:38PM -0500, Stephen Gallagher wrote: > Regression test failures should be considered build breakages. > > ACK Pushed to master and 1-1-0 - -- Stephen Gallagher RHCE 8040063

Re: [SSSD] [PATCH] Do not run negative resolv test with no network

2010-03-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/04/2010 06:03 PM, Martin Nagy wrote: > On Wed, 2010-03-03 at 14:49 +0100, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> One of our resolv tests tries to resolve a nonexistent hostname. Do not >> run this test unles

Re: [SSSD] [PATCH] Do not run negative resolv test with no network

2010-03-04 Thread Martin Nagy
On Wed, 2010-03-03 at 14:49 +0100, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > One of our resolv tests tries to resolve a nonexistent hostname. Do not > run this test unless we are explicitly told that a network connection > is available (-n). > > Our tests now pass

Re: [SSSD] [PATCH] Make filter_users and filter_groups also per-domain

2010-03-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/03/2010 08:44 PM, Jakub Hrozek wrote: > Fixes: 290 Self-nack, the attached patch fixes a bug related to error handling in the patch. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigm

Re: [SSSD] [PATCH] Fixed alignment problems in nss client/server

2010-03-04 Thread George McCollister
I've attached a new version of the patch that uses the macros. Regards, George McCollister On 03/03/2010 10:14 AM, Sumit Bose wrote: > On Mon, Mar 01, 2010 at 09:52:12AM -0600, George McCollister wrote: > >> I fixed a handful of alignment problems in sss_client and nss responder. >> Enumeratin

Re: [SSSD] [PATCH] unbreak setting debug_timestamps to 0

2010-03-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/03/2010 09:32 PM, Simo Sorce wrote: > > See patch. > ACK -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkuPnNwACgkQHsardTLnvCVPqQCdGqxURfM8TJL5e1FEt

Re: [SSSD] [PATCH] Add simple access provider

2010-03-04 Thread Sumit Bose
On Thu, Mar 04, 2010 at 12:38:43PM +1000, David O'Brien wrote: > Sumit Bose wrote: > > On Thu, Feb 25, 2010 at 08:50:43PM +0100, Sumit Bose wrote: > >> On Thu, Feb 25, 2010 at 01:27:34PM -0500, Stephen Gallagher wrote: > >>> -BEGIN PGP SIGNED MESSAGE- > >>> Hash: SHA1 > >>> > >>> On 02/25/2