Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-26 Thread Sumit Bose
On Fri, Apr 23, 2010 at 02:37:01PM +0200, Martin Nagy wrote: On Fri, 2010-04-23 at 11:28 +0200, Sumit Bose wrote: On Thu, Apr 22, 2010 at 11:58:10PM +0200, Martin Nagy wrote: On 04/16/2010 12:22 PM, Sumit Bose wrote: Hi, to support the current effort to make the LDAP provider

Re: [SSSD] [PATCH] Make the handling of fd events opaque

2010-04-26 Thread Martin Nagy
On Fri, Apr 23, 2010 at 02:37:01PM +0200, Martin Nagy wrote: On Fri, 2010-04-23 at 11:28 +0200, Sumit Bose wrote: On Thu, Apr 22, 2010 at 11:58:10PM +0200, Martin Nagy wrote: On 04/16/2010 12:22 PM, Sumit Bose wrote: [snip] Thanks for the review, new version attached. bye, Sumit

Re: [SSSD] [PATCH] Two enhancements for PAM client

2010-04-26 Thread Sumit Bose
On Thu, Apr 22, 2010 at 09:03:25AM -0400, Stephen Gallagher wrote: On 04/22/2010 06:08 AM, Sumit Bose wrote: Hi, the two patches attached should fix #446 and #417 respectively. For #417 a different solution, where the message is generated by SSSD and send to the client, would be

Re: [SSSD] [PATCH] Two enhancements for PAM client

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 07:41 AM, Sumit Bose wrote: On Thu, Apr 22, 2010 at 09:03:25AM -0400, Stephen Gallagher wrote: On 04/22/2010 06:08 AM, Sumit Bose wrote: Hi, the two patches attached should fix #446 and #417 respectively. For #417 a different solution, where the message is generated by SSSD

Re: [SSSD] [PATCH] Two enhancements for PAM client

2010-04-26 Thread Sumit Bose
On Mon, Apr 26, 2010 at 08:13:40AM -0400, Stephen Gallagher wrote: On 04/26/2010 07:41 AM, Sumit Bose wrote: On Thu, Apr 22, 2010 at 09:03:25AM -0400, Stephen Gallagher wrote: On 04/22/2010 06:08 AM, Sumit Bose wrote: Hi, the two patches attached should fix #446 and #417 respectively.

Re: [SSSD] [PATCH] IPA password migration (sssd-1-2 only)

2010-04-26 Thread Stephen Gallagher
On 04/23/2010 05:08 AM, Sumit Bose wrote: A new version is attached. bye, Sumit Ack. There is one minor whitespace issue, but I'll correct that when I push. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors.

Re: [SSSD] [PATCH] Two enhancements for PAM client

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 08:50 AM, Sumit Bose wrote: I removed the fallback path and made a missing domain name an error. bye, Sumit Ack. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

Re: [SSSD] [PATCH] Set LDAP_OPT_RESTART for all LDAP connections

2010-04-26 Thread Stephen Gallagher
On 04/21/2010 03:49 PM, Stephen Gallagher wrote: On 04/15/2010 06:01 AM, Sumit Bose wrote: Hi, this patch moves the setting of LDAP_OPT_RESTART from the SASL authentication code to the general connect call. I think chances are that it might be needed when the LDAP provider is used together

Re: [SSSD] [PATCH] Do not mark a request as failed twice

2010-04-26 Thread Stephen Gallagher
On 04/22/2010 12:51 PM, Stephen Gallagher wrote: On 04/22/2010 12:26 PM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This was causing occasional crashes during SRV testing as the callback got called twice Ack. Pushed to master and sssd-1-2. -- Stephen Gallagher

Re: [SSSD] [PATCH] Treat server names as case-insensitive in failover code

2010-04-26 Thread Stephen Gallagher
On 04/22/2010 07:28 AM, Stephen Gallagher wrote: On 04/22/2010 06:44 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It didn't cause any issues, but I think hostnames should be treated as case-insensitive It hasn't caused any issues YET. I agree, this should be

Re: [SSSD] [PATCH] IPA password migration (sssd-1-2 only)

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 08:54 AM, Stephen Gallagher wrote: On 04/23/2010 05:08 AM, Sumit Bose wrote: A new version is attached. bye, Sumit Ack. There is one minor whitespace issue, but I'll correct that when I push. Whitespace error fixed and pushed to sssd-1-2 -- Stephen Gallagher RHCE

Re: [SSSD] [PATCH] Two enhancements for PAM client

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 09:14 AM, Stephen Gallagher wrote: On 04/26/2010 08:50 AM, Sumit Bose wrote: I removed the fallback path and made a missing domain name an error. bye, Sumit Ack. Pushed to master as-is. Rebased atop the IPA password migration patches on sssd-1-2 and pushed. -- Stephen

Re: [SSSD] [PATCH] Remove the NSS_LIBS and KRB5_LIBS variables from sssd.spec

2010-04-26 Thread Stephen Gallagher
On 04/14/2010 10:10 AM, Stephen Gallagher wrote: Due to the way RPM processes the %configure macro, these variables were not actually being passed down to recursive configure invocations. In other words, they were useless. Futhermore, in more recent Fedora versions (13+), some of the

Re: [SSSD] [PATCH] Remove the NSS_LIBS and KRB5_LIBS variables from sssd.spec

2010-04-26 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/2010 04:10 PM, Stephen Gallagher wrote: Ping. This has been in the review queue for about two weeks. ACK -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [SSSD] [PATCH] Check for root in sysv init script

2010-04-26 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/2010 04:31 PM, Stephen Gallagher wrote: If the user running the init script is not root, immediately report Permission denied and exit with EPERM. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=584575 This works around a bug in

Re: [SSSD] [PATCH] Check for root in sysv init script

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 10:59 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/2010 04:31 PM, Stephen Gallagher wrote: If the user running the init script is not root, immediately report Permission denied and exit with EPERM. Addresses:

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-26 Thread Martin Nagy
On Fri, 2010-04-23 at 11:57 +0200, Jakub Hrozek wrote: [PATCH 1/2] Remove freed server_common entities from list We didn't hit this before as we never removed common entities. When using service requests, we remove the resolved fo_servers when we hit a timeout, so the server_common can be

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-26 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 New patches are attached, comments are inline. On 04/26/2010 05:54 PM, Martin Nagy wrote: On Fri, 2010-04-23 at 11:57 +0200, Jakub Hrozek wrote: [PATCH 1/2] Remove freed server_common entities from list We didn't hit this before as we never

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-26 Thread Stephen Gallagher
On 04/26/2010 04:38 PM, Dmitri Pal wrote: Hello, Patch 1: New functionality for refarray. Some basic functionality was missing. Now it is added. Nitpick: in ref_array_replace(), your trace message lists ref_array_insert(). It might not be a bad idea in a separate patch to change

Re: [SSSD] pam_pkcs11.so is missing for LOCAL domain?

2010-04-26 Thread David O'Brien
Stephen Gallagher wrote: On 04/24/2010 02:27 AM, David O'Brien wrote: Stephen Gallagher wrote: On 04/21/2010 08:35 AM, David O'Brien wrote: Stephen Gallagher wrote: On 04/21/2010 03:10 AM, Tomas Mraz wrote: On Wed, 2010-04-21 at 14:04 +1000, David O'Brien wrote: Tomas Mraz wrote: On Thu,