Re: [SSSD] [PATCH] Make sss_userdel check for logged in users

2010-04-27 Thread David O'Brien
Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/06/2010 04:34 PM, Stephen Gallagher wrote: >> Sorry, I hate to say this, but I realized that killall returns nonzero >> if there are no processes running by that user name. So this warning is >> going to look wrong if

Re: [SSSD] [PATCH] Add callback when the ID provider switches from offline to online

2010-04-27 Thread Stephen Gallagher
The point of this callback is that it should only fire when transitioning from offline to online. We don't have a way at present to tell the difference in proxy. On Apr 27, 2010, at 4:22 PM, Simo Sorce wrote: > On Tue, 27 Apr 2010 15:40:36 -0400 > Stephen Gallagher wrote: > >> I forgot to menti

Re: [SSSD] [PATCH] Add callback when the ID provider switches from offline to online

2010-04-27 Thread Simo Sorce
On Tue, 27 Apr 2010 15:40:36 -0400 Stephen Gallagher wrote: > I forgot to mention: I didn't implement this callback for the proxy > ID provider, because it's basically impossible to identify when it is > actually going online. you can mark it online when it replies successfully to a call. Simo

Re: [SSSD] [PATCH] Add callback when the ID provider switches from offline to online

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 03:37 PM, Stephen Gallagher wrote: > Allow backends to set a callback in the be_ctx that should be > invoked when the ID provider goes online. > > This can be used to perform regular maintenance tasks that are > valid only when going online. > > Specifically, we can use this to perfor

[SSSD] [PATCH] Add callback when the ID provider switches from offline to online

2010-04-27 Thread Stephen Gallagher
Allow backends to set a callback in the be_ctx that should be invoked when the ID provider goes online. This can be used to perform regular maintenance tasks that are valid only when going online. Specifically, we can use this to perform a deferred kinit on behalf of the user when we go online.

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 01:10 PM, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/27/2010 06:16 PM, Stephen Gallagher wrote: >> On 04/27/2010 11:04 AM, Jakub Hrozek wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 04/27/2010 02:48 PM, Martin Nagy wrote:

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/27/2010 06:16 PM, Stephen Gallagher wrote: > On 04/27/2010 11:04 AM, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 04/27/2010 02:48 PM, Martin Nagy wrote: >>> Uh-huh, I wanted you to add the current year, not to

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 12:32 PM, Dmitri Pal wrote: > Stephen Gallagher wrote: >> On 04/26/2010 04:38 PM, Dmitri Pal wrote: >> >>> Hello, >>> >>> Patch 1: New functionality for refarray. Some basic functionality was >>> missing. Now it is added. >>> >> >> Nitpick: in ref_array_replace(), your trace message l

Re: [SSSD] [PATCHES] New functionality for refarray and new comment object

2010-04-27 Thread Dmitri Pal
Stephen Gallagher wrote: > On 04/26/2010 04:38 PM, Dmitri Pal wrote: > >> Hello, >> >> Patch 1: New functionality for refarray. Some basic functionality was >> missing. Now it is added. >> > > Nitpick: in ref_array_replace(), your trace message lists > ref_array_insert(). It might not be

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 11:04 AM, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/27/2010 02:48 PM, Martin Nagy wrote: >> Uh-huh, I wanted you to add the current year, not to bump it :) Oh well. >> >> Ack for 0002. >> >> Thanks. >> Martin > > Stephen found out that the patch d

[SSSD] [PATCH] Add more warnings about nearly expired passwords

2010-04-27 Thread Sumit Bose
Hi, this patch is (hopefully) the final patch in a series of patches to fix #420 '[RFE] Password Expiration Notification'. The other patch in this series are: - 'Improvements for LDAP Password Policy support' which is already commited and handles the case of LDAP server password policies - 'Han

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/27/2010 02:48 PM, Martin Nagy wrote: > Uh-huh, I wanted you to add the current year, not to bump it :) Oh well. > > Ack for 0002. > > Thanks. > Martin Stephen found out that the patch did not work with c-ares versions prior to 1.7. The attache

Re: [SSSD] [PATCH] Sort SRV replies according to RFC 2782

2010-04-27 Thread Stephen Gallagher
On 04/22/2010 12:25 PM, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 04/22/2010 02:43 PM, Stephen Gallagher wrote: >> Nack. >> >> While this is clearly not a case where random values need to be highly >> random, on some implementations rand() is not uniformly distrib

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/27/2010 02:48 PM, Martin Nagy wrote: > Ack for 0002. Please note that this patch requires the "Sort SRV replies according to RFC 2782" patch which is still under review. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: U

Re: [SSSD] [PATCH] Support SRV servers in failover

2010-04-27 Thread Martin Nagy
On Mon, 2010-04-26 at 23:14 +0200, Jakub Hrozek wrote: > New patches are attached, comments are inline. > > On 04/26/2010 05:54 PM, Martin Nagy wrote: > > On Fri, 2010-04-23 at 11:57 +0200, Jakub Hrozek wrote: > >> > [PATCH 1/2] Remove freed server_common entities from list > >> > We didn't hit th

Re: [SSSD] [PATCH] Silence warnings with -O2

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 08:10 AM, Jakub Hrozek wrote: > tools/sss_sync_ops.c: In function ‘groupmod’: > tools/sss_sync_ops.c:262: warning: ‘member_dn’ may be used uninitialized > in this function > tools/sss_sync_ops.c: In function ‘usermod’: > tools/sss_sync_ops.c:202: warning: ‘member_dn’ may be used unini

[SSSD] [PATCH] Add dns_resolver_timeout option

2010-04-27 Thread Stephen Gallagher
We had a hard-coded timeout of five seconds for DNS lookups in the async resolver. This patch adds an option 'dns_resolver_timeout' to specify this value (Default: 5) -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. htt

Re: [SSSD] [PATCH] Silence warnings with -O2

2010-04-27 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/27/2010 01:19 PM, Stephen Gallagher wrote: > On 04/27/2010 05:25 AM, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> I noticed there were some warnings when compiling with the default >> Fedora CFLAGS. > > > I don'

[SSSD] [PATCH] Handle Krb5 password expiration warning

2010-04-27 Thread Sumit Bose
Hi, this two patches add the support to display a warning to the user that the Kerberos password is about to expire. The first patch just moves some utility functions to a separate file to avoid linking the krb5_child against libdbus. I the second patch a prompter function is introduced to catch

Re: [SSSD] [PATCH] Fix wrong return value

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 07:57 AM, Sumit Bose wrote: > > Ah, thanks for catching this. > > New version attached, Ack. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ _

Re: [SSSD] [PATCH] Fix wrong return value

2010-04-27 Thread Sumit Bose
On Tue, Apr 27, 2010 at 07:44:24AM -0400, Stephen Gallagher wrote: > On 04/27/2010 07:18 AM, Sumit Bose wrote: > > Hi, > > > > the patch which removes the authentication tokens from the PAM stack > > didn't return the right status code if a password change fails. To make > > it easier to read I int

Re: [SSSD] pam_pkcs11.so is missing for LOCAL domain?

2010-04-27 Thread Stephen Gallagher
On 04/26/2010 09:33 PM, David O'Brien wrote: > Stephen Gallagher wrote: >> >> There's no reason to change the manpage. The functionality is still >> present, and it's perfectly fine to use it. However, in RHEL6 it is not >> an interesting case, and thus should be removed from the deployment guide.

Re: [SSSD] [PATCH] Fix wrong return value

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 07:18 AM, Sumit Bose wrote: > Hi, > > the patch which removes the authentication tokens from the PAM stack > didn't return the right status code if a password change fails. To make > it easier to read I introduced a new variable. > > bye, > Sumit > Nack. Under SSS_PAM_AUTHENTICATE:

Re: [SSSD] [PATCH] Silence warnings with -O2

2010-04-27 Thread Stephen Gallagher
On 04/27/2010 05:25 AM, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I noticed there were some warnings when compiling with the default > Fedora CFLAGS. I don't see any warnings when building on Fedora 13 with the default CFLAGS. Could you please identify the warning

[SSSD] [PATCH] Fix wrong return value

2010-04-27 Thread Sumit Bose
Hi, the patch which removes the authentication tokens from the PAM stack didn't return the right status code if a password change fails. To make it easier to read I introduced a new variable. bye, Sumit From 5a17478b0cdee8309bd018be85dec62b33e92322 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date:

[SSSD] [PATCH] Silence warnings with -O2

2010-04-27 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I noticed there were some warnings when compiling with the default Fedora CFLAGS. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEUEARECAAYFAkvWrXMACgkQHsardTLnvCVkxgCXa