Re: [SSSD] [PATCH] Add dynamic DNS updates to FreeIPA

2010-05-04 Thread Sumit Bose
Hi, my comments are in line. bye, Sumit On Mon, May 03, 2010 at 04:02:38PM -0400, Stephen Gallagher wrote: On 05/03/2010 11:32 AM, Stephen Gallagher wrote: Addresses https://fedorahosted.org/sssd/ticket/368 This adds two new options: ipa_dyndns_update: Boolean value to select whether

[SSSD] [PATCH] Compare the full service name

2010-05-04 Thread Sumit Bose
Hi, this patch fixes an issue discussed on the freeipa-user mailing list. Now the service names should be compared properly. bye, Sumit From 04106537c8df884457b14d99c3767dc3a6516d33 Mon Sep 17 00:00:00 2001 From: Sumit Bose sb...@redhat.com Date: Mon, 3 May 2010 23:25:27 +0200 Subject: [PATCH]

Re: [SSSD] [PATCH] Add dynamic DNS updates to FreeIPA

2010-05-04 Thread Stephen Gallagher
On 05/04/2010 06:44 AM, Sumit Bose wrote: Hi, my comments are in line. bye, Sumit @@ -727,6 +728,7 @@ libsss_ldap_la_SOURCES = \ providers/ldap/sdap_child_helpers.c \ providers/ldap/sdap_fd_events.c \ providers/ldap/sdap.c \ +providers/ipa/ipa_dyndns.c \ Why

Re: [SSSD] [PATCH] Compare the full service name

2010-05-04 Thread Stephen Gallagher
On 05/04/2010 06:59 AM, Sumit Bose wrote: Hi, this patch fixes an issue discussed on the freeipa-user mailing list. Now the service names should be compared properly. bye, Sumit Ack, but please open a bug for this as well. -- Stephen Gallagher RHCE 804006346421761 Delivering value

Re: [SSSD] SSSD and community development

2010-05-04 Thread Jeff Schroeder
On Tue, May 4, 2010 at 3:34 AM, Eugene Indenbom einden...@gmail.com wrote: Dear SSSD developers, I am writing this e-mail to express my utter disappointment and disillusionment with bazaar or community development at least as it applies to SSSD. I started a new project in the middle of

Re: [SSSD] [PATCH] Use service discovery in backends (sssd 1.2)

2010-05-04 Thread Sumit Bose
On Tue, May 04, 2010 at 01:40:03PM +0200, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2010 03:16 PM, Sumit Bose wrote: On Fri, Apr 30, 2010 at 05:42:46PM +0200, Jakub Hrozek wrote: This is a rebased version of the patch that applies on top of the recent

[SSSD] [PATCH] Improve the offline authentication message

2010-05-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #455 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkvgWXYACgkQHsardTLnvCWhgQCgoYTkrDlp38GYN6liv9ZOtvYF SRUAoJ1TUo7AIEriMeiOudVXhyg0hPKF =FpZk

Re: [SSSD] [PATCH] Add dynamic DNS updates to FreeIPA

2010-05-04 Thread Sumit Bose
On Tue, May 04, 2010 at 01:01:37PM -0400, Stephen Gallagher wrote: On 05/04/2010 08:29 AM, Stephen Gallagher wrote: Thanks for the review. Updated patch coming soon. Updated patch should address both Sumit's and Jakub's concerns. There is a typo in SSSDConfig.py: +

Re: [SSSD] [PATCH] Use all available servers in LDAP provider

2010-05-04 Thread Stephen Gallagher
On 05/04/2010 02:54 PM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/03/2010 08:19 PM, Jakub Hrozek wrote: I forgot to add that this is sssd-1.2 material Rebased on top of Stephen's 1.2 patches - it's way easier to rebase my patch that the other way around.

Re: [SSSD] [PATCH] Use all available servers in LDAP provider

2010-05-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/04/2010 08:58 PM, Stephen Gallagher wrote: Please identify the exact set of dependent patches. Add callback when the ID provider switches from offline to online -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using

Re: [SSSD] [PATCH] Handle Krb5 password expiration warning

2010-05-04 Thread Stephen Gallagher
On 05/03/2010 04:44 PM, Sumit Bose wrote: On Mon, May 03, 2010 at 10:39:57PM +0200, Sumit Bose wrote: On Mon, May 03, 2010 at 02:29:39PM -0400, Stephen Gallagher wrote: On 04/30/2010 12:10 PM, Sumit Bose wrote: On Fri, Apr 30, 2010 at 10:18:39AM -0400, Stephen Gallagher wrote: On 04/29/2010

Re: [SSSD] [PATCH] Improve the offline authentication message

2010-05-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/04/2010 08:59 PM, Stephen Gallagher wrote: On 05/04/2010 01:29 PM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #455 Nack. - _(Offline authentication, authentication is denied until: ), + _(Authenticated

[SSSD] [PATCH] Clean up kdcinfo and kpasswdinfo files when exiting

2010-05-04 Thread Stephen Gallagher
https://fedorahosted.org/sssd/ticket/452 This patch adds a signal handler for SIGTERM that will remove the kdcinfo.REALM and kpasswd.REALM files before exiting. I had to move the definition of krb5_ctx into krb5_common.h so I could dereference it to get the realm name. I also made the

Re: [SSSD] [PATCH] Add dynamic DNS updates to FreeIPA

2010-05-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/04/2010 08:54 PM, Stephen Gallagher wrote: New patch attached. fwiw, I don't have any more concerns, ack from me. Let's see if Sumit has any more comments :) -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG

Re: [SSSD] [PATCH] Clean up kdcinfo and kpasswdinfo files when exiting

2010-05-04 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/04/2010 10:54 PM, Stephen Gallagher wrote: https://fedorahosted.org/sssd/ticket/452 This patch adds a signal handler for SIGTERM that will remove the kdcinfo.REALM and kpasswd.REALM files before exiting. I had to move the definition of