Re: [SSSD] [PATCH] Remove the krb5_changepw_principal option

2010-06-14 Thread David O'Brien
Simo Sorce wrote: > On Fri, 11 Jun 2010 11:19:32 +0200 > Jakub Hrozek wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 06/10/2010 09:54 PM, Simo Sorce wrote: >>> On Thu, 10 Jun 2010 20:34:13 +0200 >>> Jakub Hrozek wrote: >>> +#define SSSD_KRB5_CHANGEPW_PRINCIPLE

Re: [SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:41 AM, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/14/2010 04:13 PM, Stephen Gallagher wrote: >> On 06/14/2010 10:10 AM, Stephen Gallagher wrote: >>> https://fedorahosted.org/sssd/ticket/540 >>> >>> It was unlikely, but if the path to the socket

Re: [SSSD] [PATCH] Remove the krb5_changepw_principal option

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:45 AM, Stephen Gallagher wrote: > On 06/11/2010 05:19 AM, Jakub Hrozek wrote: >> On 06/10/2010 10:08 PM, Stephen Gallagher wrote: >>> Rescinding my ack. I should have tested more carefully. You removed the >>> setting of the environment variable, but you're using the ENV var name >

Re: [SSSD] [PATCH] Remove the krb5_changepw_principal option

2010-06-14 Thread Stephen Gallagher
On 06/10/2010 03:18 PM, Stephen Gallagher wrote: > On 06/10/2010 02:34 PM, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> For 1.2 just undocument it, remove it altogether for master. >> >> Fixes: #531 > > Ack. > Pushed to sssd-1-2. -- Stephen Gallagher RHCE 8040063

Re: [SSSD] [PATCH] get_uid_from_pid should use fstat rather than lstat

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:43 AM, Stephen Gallagher wrote: > On 06/11/2010 06:50 AM, Jakub Hrozek wrote: >> >> Fixes: #541 > > > Ack. There's a minor typo in the DEBUG message (lstat instead of fstat), > which I will fix when I push. > > Typo fixed and pushed to master and sssd-1-2. -- Stephen Gallagher R

Re: [SSSD] [PATCH] Add ldap_force_upper_case_realm to example AD config

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:13 AM, Stephen Gallagher wrote: > On 06/14/2010 10:09 AM, Stephen Gallagher wrote: >> Trivial patch adds ldap_force_upper_case_realm = True to the example >> sssd.conf for AD. >> >> A more complete fix for Active Directory users will come in the future >> as https://fedorahosted.or

Re: [SSSD] [PATCH] Don't segfault if ldap_access_filter is unspecified

2010-06-14 Thread Stephen Gallagher
On 06/11/2010 05:42 AM, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/10/2010 07:07 PM, Stephen Gallagher wrote: >> On 06/10/2010 01:04 PM, Stephen Gallagher wrote: >>> Coverity caught another potential segfault. This one would be >>> highly-visible. See https://fe

Re: [SSSD] [PATCH] Assorted patches for Coverity issues

2010-06-14 Thread Stephen Gallagher
On 06/10/2010 03:25 PM, Stephen Gallagher wrote: > On 06/10/2010 02:33 PM, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> All of these patches apply on top of both master and 1-2. I'll send the >> ones that are different separately. > > > Ack to all four. > Pushed to

Re: [SSSD] [PATCH] Remove the -g option from useradd

2010-06-14 Thread Stephen Gallagher
On 06/10/2010 03:19 PM, Stephen Gallagher wrote: > On 06/10/2010 02:33 PM, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> When working on #522 I realized that since the local domain is now >> MPG-only, it doesn't make sense to offer an option to set the primary >> GID

Re: [SSSD] [PATCH] Fix invalid talloc_move in groupshow

2010-06-14 Thread Stephen Gallagher
On 06/10/2010 03:15 PM, Stephen Gallagher wrote: > On 06/10/2010 02:33 PM, Jakub Hrozek wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> This patch applies to 1.2 only > > > Ack. > Pushed to sssd-1-2. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Re

Re: [SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Dmitri Pal
Stephen Gallagher wrote: > On 06/14/2010 10:48 AM, Dmitri Pal wrote: > >> Jakub Hrozek wrote: >> >>> On 06/14/2010 04:13 PM, Stephen Gallagher wrote: >>> On 06/14/2010 10:10 AM, Stephen Gallagher wrote: > https://fedorahosted.org/sssd/ticket/540 > > It

Re: [SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:48 AM, Dmitri Pal wrote: > Jakub Hrozek wrote: >> On 06/14/2010 04:13 PM, Stephen Gallagher wrote: >>> On 06/14/2010 10:10 AM, Stephen Gallagher wrote: https://fedorahosted.org/sssd/ticket/540 It was unlikely, but if the path to the socket file exceeded 108 char

Re: [SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Dmitri Pal
Jakub Hrozek wrote: > On 06/14/2010 04:13 PM, Stephen Gallagher wrote: > > On 06/14/2010 10:10 AM, Stephen Gallagher wrote: > >> https://fedorahosted.org/sssd/ticket/540 > >> > >> It was unlikely, but if the path to the socket file exceeded 108 > >> characters, this strncpy would be unterminated an

Re: [SSSD] [PATCH] Remove the krb5_changepw_principal option

2010-06-14 Thread Stephen Gallagher
On 06/11/2010 05:19 AM, Jakub Hrozek wrote: > On 06/10/2010 10:08 PM, Stephen Gallagher wrote: >> Rescinding my ack. I should have tested more carefully. You removed the >> setting of the environment variable, but you're using the ENV var name >> instead of kadmin/changepw for the principal. That j

Re: [SSSD] [PATCH] get_uid_from_pid should use fstat rather than lstat

2010-06-14 Thread Stephen Gallagher
On 06/11/2010 06:50 AM, Jakub Hrozek wrote: > > Fixes: #541 Ack. There's a minor typo in the DEBUG message (lstat instead of fstat), which I will fix when I push. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. htt

Re: [SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/14/2010 04:13 PM, Stephen Gallagher wrote: > On 06/14/2010 10:10 AM, Stephen Gallagher wrote: >> https://fedorahosted.org/sssd/ticket/540 >> >> It was unlikely, but if the path to the socket file exceeded 108 >> characters, this strncpy would be

Re: [SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:10 AM, Stephen Gallagher wrote: > https://fedorahosted.org/sssd/ticket/540 > > It was unlikely, but if the path to the socket file exceeded 108 > characters, this strncpy would be unterminated and the results could be > unexpected. This was not an exploitable vulnerability. > I fo

Re: [SSSD] [PATCH] Add ldap_force_upper_case_realm to example AD config

2010-06-14 Thread Stephen Gallagher
On 06/14/2010 10:09 AM, Stephen Gallagher wrote: > Trivial patch adds ldap_force_upper_case_realm = True to the example > sssd.conf for AD. > > A more complete fix for Active Directory users will come in the future > as https://fedorahosted.org/sssd/ticket/537 > > No need to ack this. It will be pu

[SSSD] [PATCH] Properly null-terminate socket path

2010-06-14 Thread Stephen Gallagher
https://fedorahosted.org/sssd/ticket/540 It was unlikely, but if the path to the socket file exceeded 108 characters, this strncpy would be unterminated and the results could be unexpected. This was not an exploitable vulnerability. -- Stephen Gallagher RHCE 804006346421761 Delivering value

[SSSD] [PATCH] Add ldap_force_upper_case_realm to example AD config

2010-06-14 Thread Stephen Gallagher
Trivial patch adds ldap_force_upper_case_realm = True to the example sssd.conf for AD. A more complete fix for Active Directory users will come in the future as https://fedorahosted.org/sssd/ticket/537 No need to ack this. It will be pushed under the one-liner rule with the next set. It chan