[SSSD] Announcing the release of SSSD 1.3.0

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The SSSD team is proud to announce the enhancement release 1.3.0 of the System Security Services Daemon. As usual, it can be downloaded from https://fedorahosted.org/sssd/ == Highlights == * Rewrote the internal LDB cache API. As a synchronous API i

Re: [SSSD] [PATCH] Fix incorrect NULL check (sssd-1-2)

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 01:43 PM, Jakub Hrozek wrote: > On 08/03/2010 07:33 PM, Stephen Gallagher wrote: >> Discovered with Coverity, the recent patch for RFC2307bis had an >> incorrect NULL check. > > Ack Pushed to sssd-1-2. - -- Stephen Gallagher RHCE 8040

Re: [SSSD] [PATCHES] Fix severe performance problems with initgroups (master)

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 01:34 PM, Jakub Hrozek wrote: > On 08/03/2010 07:12 PM, Stephen Gallagher wrote: >> On 08/03/2010 12:34 PM, Jakub Hrozek wrote: >>> On 08/02/2010 05:58 PM, Stephen Gallagher wrote: Attached are the patches to fix the initgroups perfo

Re: [SSSD] [PATCH] be_pam_handler(): Fix potential NULL dereference

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 01:42 PM, Jakub Hrozek wrote: > On 08/03/2010 07:30 PM, Stephen Gallagher wrote: >> Discovered with Coverity, if we failed to allocate be_req in >> be_pam_handler(), we would attempt to dereference a NULL value. > > >> This patch is for

Re: [SSSD] Fix two bugs found by clang

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 01:37 PM, Stephen Gallagher wrote: > On 08/03/2010 12:47 PM, Jakub Hrozek wrote: >> The attached patches fix two bugs found by the clang static analyser. >> Both of them masked potential errors, the first one when parsing of a >> HBAC rul

Re: [SSSD] [PATCH] Require -ltalloc for tevent configure check

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 11:35 AM, Jakub Hrozek wrote: > On 08/03/2010 05:11 PM, Stephen Gallagher wrote: > >> This configure check doesn't work when --as-needed is passed as a >> configure flag to LDFLAGS. We need to explicitly include -ltalloc here. > > > Lo

Re: [SSSD] [PATCH] Validate keytab at startup

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/27/2010 10:57 AM, Stephen Gallagher wrote: > On 07/27/2010 10:53 AM, Jakub Hrozek wrote: >> On 07/26/2010 06:34 PM, Stephen Gallagher wrote: >>> Nack. If an error is returned from krb5_init_context, the memory for >>> tmp_ctx is leaked. > >>> Ot

Re: [SSSD] [PATCH] Fix incorrect NULL check (sssd-1-2)

2010-08-03 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 07:33 PM, Stephen Gallagher wrote: > Discovered with Coverity, the recent patch for RFC2307bis had an > incorrect NULL check. Ack -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://

Re: [SSSD] [PATCH] be_pam_handler(): Fix potential NULL dereference

2010-08-03 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 07:30 PM, Stephen Gallagher wrote: > Discovered with Coverity, if we failed to allocate be_req in > be_pam_handler(), we would attempt to dereference a NULL value. > > > This patch is for both 1.2 and master. > > Ack -BEGIN PGP S

Re: [SSSD] Fix two bugs found by clang

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 12:47 PM, Jakub Hrozek wrote: > The attached patches fix two bugs found by the clang static analyser. > Both of them masked potential errors, the first one when parsing of a > HBAC rule fails, the second one when unexpected status of a se

Re: [SSSD] [PATCHES] Fix severe performance problems with initgroups (master)

2010-08-03 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 07:12 PM, Stephen Gallagher wrote: > On 08/03/2010 12:34 PM, Jakub Hrozek wrote: >> On 08/02/2010 05:58 PM, Stephen Gallagher wrote: >>> Attached are the patches to fix the initgroups performance issue for the >>> master branch. Patches 0

[SSSD] [PATCH] Fix incorrect NULL check (sssd-1-2)

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Discovered with Coverity, the recent patch for RFC2307bis had an incorrect NULL check. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

[SSSD] [PATCH] be_pam_handler(): Fix potential NULL dereference

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Discovered with Coverity, if we failed to allocate be_req in be_pam_handler(), we would attempt to dereference a NULL value. This patch is for both 1.2 and master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red

Re: [SSSD] [PATCHES] Fix severe performance problems with initgroups (master)

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 12:34 PM, Jakub Hrozek wrote: > On 08/02/2010 05:58 PM, Stephen Gallagher wrote: >> Attached are the patches to fix the initgroups performance issue for the >> master branch. Patches 0001-0004 applied trivially to the master, >> patches 0

[SSSD] Fix two bugs found by clang

2010-08-03 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The attached patches fix two bugs found by the clang static analyser. Both of them masked potential errors, the first one when parsing of a HBAC rule fails, the second one when unexpected status of a service lookup..the routines would return EOK instea

Re: [SSSD] [PATCHES] Fix severe performance problems with initgroups (master)

2010-08-03 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/02/2010 05:58 PM, Stephen Gallagher wrote: > Attached are the patches to fix the initgroups performance issue for the > master branch. Patches 0001-0004 applied trivially to the master, > patches 0005 and 0006 had to be rewritten to take advantag

Re: [SSSD] [PATCH] Require -ltalloc for tevent configure check

2010-08-03 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/03/2010 05:11 PM, Stephen Gallagher wrote: > > This configure check doesn't work when --as-needed is passed as a > configure flag to LDFLAGS. We need to explicitly include -ltalloc here. > Looks OK, config.log indicates that we also link again

[SSSD] [PATCH] Require -ltalloc for tevent configure check

2010-08-03 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This configure check doesn't work when --as-needed is passed as a configure flag to LDFLAGS. We need to explicitly include -ltalloc here. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among