-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/20/2010 06:46 AM, Sumit Bose wrote:
>> The patches apply fine. There is a whitespace issue, 0001 adds an empty
>> line at the end of sysdb_search.c . All tests passed, please find some
>> comments below.
Fixed.
> ret is undefined
Good catch.
On Friday 17 September 2010 19:56:15 Stephen Gallagher wrote:
> On 09/17/2010 12:16 PM, Ralf Haferkamp wrote:
> > Find a new version attached. Does that look better? If that is not
> > what you were referring to lets discuss it in IRC on monday.
> >
> > Note, I needed to implement sdap_process_gro
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Thanks for the review, Sumit. I will fix these in the next iteration.
I also realized that just returning the final triples won't work, as our
NSS responder code needs other attributes to determine whether the cache
is expired. I'm planning to split t
Jan Zelený wrote:
> Stephen Gallagher wrote:
>
>> On 09/17/2010 07:18 PM, Jan Zeleny wrote:
>>
>>> I went through the code of the first patch and there are some things
>>> which don't seem to be right.
>>>
>>> First of all, the code is missing the memory hierarchy entirely. Here are
>>> so
On Fri, Sep 17, 2010 at 11:21:40AM -0400, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 09/17/2010 11:16 AM, Dmitri Pal wrote:
> > Stephen Gallagher wrote:
> >> On 09/16/2010 05:05 PM, Stephen Gallagher wrote:
> >>> I've rewritten these patches. Now, instead of
Stephen Gallagher wrote:
> On 09/17/2010 07:18 PM, Jan Zeleny wrote:
> > I went through the code of the first patch and there are some things
> > which don't seem to be right.
> >
> > First of all, the code is missing the memory hierarchy entirely. Here are
> > some examples:
> > src/db/sys_ops.c
