[SSSD] Announcing SSSD 1.2.4

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The SSSD team is proud to announce the immediate release of version 1.2.4 of the System Security Services Daemon. This update fixes several serious bugs in the 1.2.x line of SSSD and is a recommended update for all users. It can be downloaded at https

Re: [SSSD] [PATCHES] Initgroups support for RFC2307bis nested groups (sssd-1-2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 05:37 PM, Jakub Hrozek wrote: > On 10/08/2010 10:14 PM, Stephen Gallagher wrote: >> Jakub discovered a bug with deep nesting. I only fixed the direct >> membership lookup for users, but not for other groups. > >> This version of the patc

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 05:29 PM, Sumit Bose wrote: > On Fri, Oct 08, 2010 at 05:12:32PM +0200, Jakub Hrozek wrote: > > I don't have any more comments and my testing went alright. So ack from > me, although I'm not sure if someone else is reviewing the patch, t

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 04:48 PM, Stephen Gallagher wrote: > On 10/08/2010 04:45 PM, Jakub Hrozek wrote: >> Attaching all three patches for clarity. Thank you for the review. > > > Ack to all three. Good work! > Pushed to sssd-1-2. - -- Stephen Gallagher R

Re: [SSSD] [PATCH] Fix initgroup processing for RFC2307 (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 07:35 AM, Stephen Gallagher wrote: > On 10/08/2010 07:28 AM, Stephen Gallagher wrote: >> Sorry, you are correct. I was only seeing things disappearing on me >> because I was in the middle of trying to debug why the group memberships >> we

Re: [SSSD] [PATCH] Add common hash table setup

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2010 12:22 PM, Simo Sorce wrote: > On Wed, 06 Oct 2010 12:17:01 -0400 > Stephen Gallagher wrote: > >> Self-nack. >> >> I just realized that freeing the table won't clean up all of its >> memory, because all of the values will have been alloc

Re: [SSSD] [PATCHES] Initgroups support for RFC2307bis nested groups (sssd-1-2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 10:14 PM, Stephen Gallagher wrote: > Jakub discovered a bug with deep nesting. I only fixed the direct > membership lookup for users, but not for other groups. > > This version of the patch combines this into a common routine so that > b

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Sumit Bose
On Fri, Oct 08, 2010 at 05:12:32PM +0200, Jakub Hrozek wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/08/2010 02:32 PM, Stephen Gallagher wrote: > > On 10/08/2010 08:09 AM, Jakub Hrozek wrote: > >> On 10/08/2010 01:13 PM, Stephen Gallagher wrote: > >>> On 10/08/2010 05:25 AM, J

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 04:45 PM, Jakub Hrozek wrote: > On 10/08/2010 10:25 PM, Stephen Gallagher wrote: >> On 10/08/2010 03:45 PM, Jakub Hrozek wrote: >>> On 10/08/2010 04:57 PM, Stephen Gallagher wrote: On 10/08/2010 05:09 AM, Jakub Hrozek wrote:

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 10:25 PM, Stephen Gallagher wrote: > On 10/08/2010 03:45 PM, Jakub Hrozek wrote: >> On 10/08/2010 04:57 PM, Stephen Gallagher wrote: >>> On 10/08/2010 05:09 AM, Jakub Hrozek wrote: >>> [PATCH 1/3] sysdb interface for adding expired us

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 03:45 PM, Jakub Hrozek wrote: > On 10/08/2010 04:57 PM, Stephen Gallagher wrote: >> On 10/08/2010 05:09 AM, Jakub Hrozek wrote: >> [PATCH 1/3] sysdb interface for adding expired user entries >> These are added instead of looking u

Re: [SSSD] [PATCH] Fix log filling with error message

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/05/2010 12:19 PM, Sumit Bose wrote: > On Mon, Oct 04, 2010 at 05:34:20PM +0200, Jan Zelený wrote: >> >> Thanks for the feedback. Actually using remove_ldap_connection_callbacks() >> was >> my original idea. I don't remember why, but I dropped i

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 02:32 PM, Stephen Gallagher wrote: > On 10/08/2010 08:09 AM, Jakub Hrozek wrote: >> On 10/08/2010 01:13 PM, Stephen Gallagher wrote: >>> On 10/08/2010 05:25 AM, Jakub Hrozek wrote: On 10/07/2010 03:18 PM, Stephen Gallagher wrote: >>>

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 05:09 AM, Jakub Hrozek wrote: [PATCH 1/3] sysdb interface for adding expired user entries These are added instead of looking up the members. Ack. [PATCH 2/3] Shortcut for save_group() to accept sysdb DNs as member at

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 11:09 AM, Jakub Hrozek wrote: > Another round of patches that apply cleanly on top of Stephen's > RFC2307bis nested group work in the thread named "[PATCHES] Handle > nested groups in RFC2307bis". Yet another rebase, I moved invocation o

Re: [SSSD] [PATCH] Do not remove man pages in released tar balls

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/07/2010 09:44 AM, Sumit Bose wrote: > Hi, > > make clean removes the generated man pages even in the distributed > version where they cannot be recreated because we do not ship the xml > sources. This patch checks if src/man/include, which we do

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 08:09 AM, Jakub Hrozek wrote: > On 10/08/2010 01:13 PM, Stephen Gallagher wrote: >> On 10/08/2010 05:25 AM, Jakub Hrozek wrote: >>> On 10/07/2010 03:18 PM, Stephen Gallagher wrote: Whoops, I guess I missed a few spots. I meant to rem

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 01:13 PM, Stephen Gallagher wrote: > On 10/08/2010 05:25 AM, Jakub Hrozek wrote: >> On 10/07/2010 03:18 PM, Stephen Gallagher wrote: >>> Whoops, I guess I missed a few spots. I meant to remove references to >>> that option, because we're

Re: [SSSD] [PATCH] Fix initgroup processing for RFC2307 (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 07:28 AM, Stephen Gallagher wrote: > On 10/08/2010 03:52 AM, Jakub Hrozek wrote: >> On 10/08/2010 02:18 AM, Stephen Gallagher wrote: >>> Something I've been noticing during my testing: these fake groups are >>> created with a dataExpireTi

Re: [SSSD] [PATCH] Fix initgroup processing for RFC2307 (sssd-1.2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 03:52 AM, Jakub Hrozek wrote: > On 10/08/2010 02:18 AM, Stephen Gallagher wrote: >> Something I've been noticing during my testing: these fake groups are >> created with a dataExpireTimestamp of "one second ago". This means >> they're bei

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 05:25 AM, Jakub Hrozek wrote: > On 10/07/2010 03:18 PM, Stephen Gallagher wrote: >> Whoops, I guess I missed a few spots. I meant to remove references to >> that option, because we're not using it for now. > > Update patch attached. I ho

Re: [SSSD] [PATCHES] Initgroups support for RFC2307bis nested groups (sssd-1-2)

2010-10-08 Thread Sumit Bose
On Thu, Oct 07, 2010 at 09:24:43PM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > These patches must be applied atop my patches in the thread "Handle > nested groups in RFC2307bis (sssd-1-2)", which in turn must be applied > atop Jakub's patches in the thread

Re: [SSSD] [PATCHES] Handle nested groups in RFC2307bis (sssd-1-2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/07/2010 03:18 PM, Stephen Gallagher wrote: > Whoops, I guess I missed a few spots. I meant to remove references to > that option, because we're not using it for now. Update patch attached. I hope you don't mind me touching your patches but I did

Re: [SSSD] [PATCH] Return all user members for RFC2307 groups (sssd-1.2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/06/2010 01:18 PM, Jakub Hrozek wrote: > On 10/05/2010 11:12 PM, Simo Sorce wrote: >> On Tue, 05 Oct 2010 19:11:02 +0200 >> Jakub Hrozek wrote: > >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> [PATCH 1/3] sysdb interface for addin

Re: [SSSD] [PATCH] Fix initgroup processing for RFC2307 (sssd-1.2)

2010-10-08 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/08/2010 02:18 AM, Stephen Gallagher wrote: > Something I've been noticing during my testing: these fake groups are > created with a dataExpireTimestamp of "one second ago". This means > they're being reaped by the cleanup task. Is there any reaso