Re: [SSSD] [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-17 Thread Endi Sukma Dewata
On 11/17/2010 5:24 PM, Endi Sukma Dewata wrote: > Will the user need to be aware of this issue? In other words, will the > UI enforce the user to split a schedule that crosses midnight manually? > > If yes, there are some issues: > > 1. Some schedules that have to be split because of local time zon

Re: [SSSD] [Freeipa-devel] Proposed changes to the HBAC grammar

2010-11-17 Thread Endi Sukma Dewata
On 11/17/2010 3:21 PM, Dmitri Pal wrote: >> In a related note, we also discussed how to handle describing activity >> windows that cross the midnight boundary. It's my recommendation that we >> should handle examples like the following by breaking them into two >> separate accessTime attributes, on

Re: [SSSD] Proposed changes to the HBAC grammar

2010-11-17 Thread Sumit Bose
On Wed, Nov 17, 2010 at 04:07:24PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > During a discussion today about how to represent the HBAC grammar in the > FreeIPA GUI, it became apparent that there was a limitation in the > grammar. Specifically, it's not p

Re: [SSSD] [PATCH] Ensure that SSSD shuts down completely before restarting

2010-11-17 Thread Sumit Bose
On Wed, Nov 17, 2010 at 08:36:54AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I think this finally solves: > https://bugzilla.redhat.com/show_bug.cgi?id=606887 > > killproc only sends SIGTERM, but doesn't check whether the process > actually exited befor

Re: [SSSD] [PATCH] Wait for all children to exit

2010-11-17 Thread Sumit Bose
On Wed, Nov 17, 2010 at 10:08:13PM +0100, Sumit Bose wrote: > On Thu, Nov 11, 2010 at 09:05:57AM -0500, Stephen Gallagher wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > Previously, there was a race-condition where the monitor might > > terminate before its children. > > > >

Re: [SSSD] Proposed changes to the HBAC grammar

2010-11-17 Thread Dmitri Pal
Stephen Gallagher wrote: > During a discussion today about how to represent the HBAC grammar in the > FreeIPA GUI, it became apparent that there was a limitation in the > grammar. Specifically, it's not possible to describe in a non-ambiguous > way "The first Wednesday of the month". > > Right now,

Re: [SSSD] [PATCH] Wait for all children to exit

2010-11-17 Thread Sumit Bose
On Thu, Nov 11, 2010 at 09:05:57AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Previously, there was a race-condition where the monitor might > terminate before its children. > > Resolves https://fedorahosted.org/sssd/ticket/555 ACK bye, Sumit > > - -

[SSSD] Proposed changes to the HBAC grammar

2010-11-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 During a discussion today about how to represent the HBAC grammar in the FreeIPA GUI, it became apparent that there was a limitation in the grammar. Specifically, it's not possible to describe in a non-ambiguous way "The first Wednesday of the month".

Re: [SSSD] [PATCH] Fix authentication queue code for proxy auth

2010-11-17 Thread Sumit Bose
On Wed, Nov 17, 2010 at 02:58:17PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/17/2010 02:38 PM, Sumit Bose wrote: > > On Wed, Nov 17, 2010 at 02:32:39PM -0500, Stephen Gallagher wrote: > > On 11/17/2010 04:22 AM, Sumit Bose wrote: > > Can you ca

Re: [SSSD] [PATCH] Fix authentication queue code for proxy auth

2010-11-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/17/2010 02:38 PM, Sumit Bose wrote: > On Wed, Nov 17, 2010 at 02:32:39PM -0500, Stephen Gallagher wrote: > On 11/17/2010 04:22 AM, Sumit Bose wrote: > Can you call 'client_ctx->auth_ctx->running--;' directly after > 'proxy_child_recv()' ?

Re: [SSSD] [PATCH] Fix authentication queue code for proxy auth

2010-11-17 Thread Sumit Bose
On Wed, Nov 17, 2010 at 02:32:39PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/17/2010 04:22 AM, Sumit Bose wrote: > >> Can you call 'client_ctx->auth_ctx->running--;' directly after > >> 'proxy_child_recv()' ? > > > > Sure, I just moved the decrem

Re: [SSSD] [PATCH] Fix authentication queue code for proxy auth

2010-11-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/17/2010 04:22 AM, Sumit Bose wrote: >> Can you call 'client_ctx->auth_ctx->running--;' directly after >> 'proxy_child_recv()' ? > Sure, I just moved the decrement and the creation of the immediate event to before the return value check, so now

[SSSD] [PATCH] Ensure that SSSD shuts down completely before restarting

2010-11-17 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think this finally solves: https://bugzilla.redhat.com/show_bug.cgi?id=606887 killproc only sends SIGTERM, but doesn't check whether the process actually exited before returning success. So we were trying to start up a new SSSD process before the pr

Re: [SSSD] [PATCH] Wait for all children to exit

2010-11-17 Thread Sumit Bose
On Wed, Nov 17, 2010 at 10:15:25AM +0100, Sumit Bose wrote: > On Thu, Nov 11, 2010 at 09:05:57AM -0500, Stephen Gallagher wrote: ... > > +/* Kill all of our known children manually */ > > +DLIST_FOR_EACH(svc, mt_ctx->svc_list) { > > +if (svc->pid == 0) { > > +/* The lo

Re: [SSSD] [PATCH] Fix authentication queue code for proxy auth

2010-11-17 Thread Sumit Bose
On Tue, Nov 16, 2010 at 04:12:40PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/16/2010 04:09 PM, Stephen Gallagher wrote: > > We weren't decrementing the count of in-progress authentication > > request child processes when they completed successfully

Re: [SSSD] [PATCH] Wait for all children to exit

2010-11-17 Thread Sumit Bose
On Thu, Nov 11, 2010 at 09:05:57AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Previously, there was a race-condition where the monitor might > terminate before its children. > > Resolves https://fedorahosted.org/sssd/ticket/555 Hi, please find my comme