Re: [SSSD] [PATCHES] Better default logging of access denials

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 03:02 PM, Stephen Gallagher wrote: > On 01/06/2011 09:20 AM, Sumit Bose wrote: >> Hi, > >> in trac ticket #751 it was requested to add syslog messages telling the >> admin why access was denied for a specific user with LDAP access >> pro

Re: [SSSD] [PATCH] Do not call nspr_nss_cleanup() in sss_password_decrypt()

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 02:38 PM, Stephen Gallagher wrote: > On 01/06/2011 07:22 AM, Sumit Bose wrote: >>> This new patch converts the obfuscated password at startup and replaces >>> it with the cleartext version in the option array. This should fix >>> https://

Re: [SSSD] [PATCHES] Enumeration fixes

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 02:10 PM, Stephen Gallagher wrote: > On 01/06/2011 06:11 AM, Sumit Bose wrote: > 0002: should fix #757. If only the local provider was configured the > code did not return to the main loop during execution and the callback > o

Re: [SSSD] [PATCHES] Better default logging of access denials

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 09:20 AM, Sumit Bose wrote: > Hi, > > in trac ticket #751 it was requested to add syslog messages telling the > admin why access was denied for a specific user with LDAP access > provider. > > The following two patches add this for the

Re: [SSSD] [PATCH] Do not call nspr_nss_cleanup() in sss_password_decrypt()

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 07:22 AM, Sumit Bose wrote: >> This new patch converts the obfuscated password at startup and replaces >> it with the cleartext version in the option array. This should fix >> https://fedorahosted.org/sssd/ticket/761 and >> https://fedora

Re: [SSSD] [PATCHES] Enumeration fixes

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 06:11 AM, Sumit Bose wrote: 0002: should fix #757. If only the local provider was configured the code did not return to the main loop during execution and the callback of the corresponding tevent request was never called.I

[SSSD] [PATCHES] Better default logging of access denials

2011-01-06 Thread Sumit Bose
Hi, in trac ticket #751 it was requested to add syslog messages telling the admin why access was denied for a specific user with LDAP access provider. The following two patches add this for the check based on the shadow expire attribute and the authorized service check. bye, Sumit From 31d15a605

Re: [SSSD] [INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 08:36 AM, Dmitri Pal wrote: > >> >>> 0001--INI-Making-Coverity-happy.patch <- this is the patch I submitted >>> earlier that I merged by mistake. I was supposed to merge it with patch >>> 25 but picked the wrong one instead. >>> Patch 2

Re: [SSSD] [INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...

2011-01-06 Thread Dmitri Pal
> > > 0001--INI-Making-Coverity-happy.patch <- this is the patch I submitted > > earlier that I merged by mistake. I was supposed to merge it with patch > > 25 but picked the wrong one instead. > > Patch 25 addresses the real issue found by Coverity as mentioned in > > Stephen's review mail but i

Re: [SSSD] [INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...

2011-01-06 Thread Dmitri Pal
Stephen Gallagher wrote: > On 01/06/2011 03:02 AM, Sumit Bose wrote: > > On Wed, Jan 05, 2011 at 04:03:38PM -0500, Dmitri Pal wrote: > >> Stephen Gallagher wrote: > >>> On 01/05/2011 03:40 PM, Dmitri Pal wrote: > 0003--BUILD-Allow-trace-per-component.patch <- This patch allows > > trac

Re: [SSSD] [PATCH] Do not call nspr_nss_cleanup() in sss_password_decrypt()

2011-01-06 Thread Sumit Bose
On Wed, Jan 05, 2011 at 08:31:57AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/05/2011 06:12 AM, Sumit Bose wrote: > > Hi, > > > > Shanks found an issue with obfuscated password which led to > > https://fedorahosted.org/sssd/ticket/762 > > > > This

Re: [SSSD] [INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...

2011-01-06 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/06/2011 03:02 AM, Sumit Bose wrote: > On Wed, Jan 05, 2011 at 04:03:38PM -0500, Dmitri Pal wrote: >> Stephen Gallagher wrote: >>> On 01/05/2011 03:40 PM, Dmitri Pal wrote: 0003--BUILD-Allow-trace-per-component.patch <- This patch allows

Re: [SSSD] [PATCHES] Enumeration fixes

2011-01-06 Thread Sumit Bose
On Tue, Jan 04, 2011 at 12:08:01PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/04/2011 08:18 AM, Sumit Bose wrote: > > Hi, > > > > based on an issue found by Shanks (#757) I had a closer look at some > > parts of the enumeration code in the nss resp

Re: [SSSD] [INI] Patches for ding-libs: Merging config sections, handling metadata, remaining Coverity issues...

2011-01-06 Thread Sumit Bose
On Wed, Jan 05, 2011 at 04:03:38PM -0500, Dmitri Pal wrote: > Stephen Gallagher wrote: > > On 01/05/2011 03:40 PM, Dmitri Pal wrote: > > > 0003--BUILD-Allow-trace-per-component.patch <- This patch allows > > >> tracing > > > per component > > Nack. Requiring a file doesn't make sense.