Re: [SSSD] [PATCHES] Fixes for user lookup during PAM actions

2011-01-19 Thread Simo Sorce
On Wed, 19 Jan 2011 15:59:16 -0500 Stephen Gallagher wrote: > -subreq = sdap_get_initgr_send(state, state->ev, > +subreq = sdap_get_initgr_send(state, > + state->ev, >state->ctx->be->domain, >

[SSSD] [PATCHES] Fixes for user lookup during PAM actions

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Patch 0001: Add the user's primary group to the initgroups lookup The user may not be a direct member of their primary group, but we still want to make sure that group is cached on the system. Patch 0002: Perform initgroups lookup for PAM Previously w

Re: [SSSD] [PATCH] Fix return value check

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 07:50 AM, Stephen Gallagher wrote: > On 01/19/2011 07:42 AM, Sumit Bose wrote: >> On Wed, Jan 19, 2011 at 06:49:26AM -0500, Stephen Gallagher wrote: >> On 01/19/2011 06:42 AM, Sumit Bose wrote: > On Wed, Jan 19, 2011 at 06:29:17AM -05

Re: [SSSD] [PATCHES] Add AD and RHDS/IPA expire policy

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 09:34 AM, Stephen Gallagher wrote: > On 01/19/2011 09:31 AM, Sumit Bose wrote: >> On Wed, Jan 19, 2011 at 08:34:09AM -0500, Stephen Gallagher wrote: >> On 01/18/2011 05:24 AM, Sumit Bose wrote: > Hi, > > the following two patc

Re: [SSSD] [PATCHES] Add pam_pwd_expiration_warning config option

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 09:17 AM, Stephen Gallagher wrote: > On 01/19/2011 08:56 AM, Sumit Bose wrote: >> Hi, > >> another new option, this time it is pam_pwd_expiration_warning the >> number of days a warning should be displayed before the password >> expires.

Re: [SSSD] [PATCH] Don't double-sanitize member DNs

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 09:02 AM, Sumit Bose wrote: > On Tue, Jan 18, 2011 at 12:20:44PM -0500, Stephen Gallagher wrote: > After asking the cache for the list of member DNs for groups > during an initgroups request, we were passing it through the > sanitization

Re: [SSSD] [PATCH] Fix incorrect example file

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 08:57 AM, Sumit Bose wrote: > On Tue, Jan 18, 2011 at 12:19:31PM -0500, Stephen Gallagher wrote: > The example sssd.conf still had entry_cache_timeout listed in the > [nss] section, and did not have correct values for > entry_cache_nowait

Re: [SSSD] New IRC channel for SSSD

2011-01-19 Thread Kashyap Chamarthy
On 01/19/2011 08:00 PM, Jenny Galipeau wrote: > Stephen Gallagher wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> The time has finally come for SSSD to have its own IRC channel. The >> project has grown rapidly in the last year, and we feel that it would >> now be better to separat

Re: [SSSD] [PATCH] Add ipa_hbac_search_base config option

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 08:45 AM, Stephen Gallagher wrote: > On 01/18/2011 09:40 AM, Sumit Bose wrote: >> Hi, > >> this patch makes the IPA HBAC access provider more flexible and should >> fix trac ticket #777. > > > Ack. > Pushed to master. - -- Stephen

Re: [SSSD] [PATCHES] Add AD and RHDS/IPA expire policy

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 09:31 AM, Sumit Bose wrote: > On Wed, Jan 19, 2011 at 08:34:09AM -0500, Stephen Gallagher wrote: > On 01/18/2011 05:24 AM, Sumit Bose wrote: Hi, the following two patches add expired policies for AD and RHDS/IPA and sh

Re: [SSSD] [PATCHES] Add AD and RHDS/IPA expire policy

2011-01-19 Thread Sumit Bose
On Wed, Jan 19, 2011 at 08:34:09AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/18/2011 05:24 AM, Sumit Bose wrote: > > Hi, > > > > the following two patches add expired policies for AD and RHDS/IPA and > > should fix trac ticket #674 and #679, respe

Re: [SSSD] [PATCHES] Add pam_pwd_expiration_warning config option

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 09:30 AM, Jenny Galipeau wrote: > Stephen Gallagher wrote: > On 01/19/2011 08:56 AM, Sumit Bose wrote: > Hi, another new option, this time it is pam_pwd_expiration_warning the number of days a warning should be disp

Re: [SSSD] New IRC channel for SSSD

2011-01-19 Thread Jenny Galipeau
Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > The time has finally come for SSSD to have its own IRC channel. The > project has grown rapidly in the last year, and we feel that it would > now be better to separate from #freeipa (which has also grown). > > The proper

Re: [SSSD] [PATCHES] Add pam_pwd_expiration_warning config option

2011-01-19 Thread Jenny Galipeau
Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/19/2011 08:56 AM, Sumit Bose wrote: > >> Hi, >> >> another new option, this time it is pam_pwd_expiration_warning the >> number of days a warning should be displayed before the password >> expires. >> >> While w

Re: [SSSD] [PATCHES] Add pam_pwd_expiration_warning config option

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 08:56 AM, Sumit Bose wrote: > Hi, > > another new option, this time it is pam_pwd_expiration_warning the > number of days a warning should be displayed before the password > expires. > > While writing this patch I realized that it might

[SSSD] New IRC channel for SSSD

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The time has finally come for SSSD to have its own IRC channel. The project has grown rapidly in the last year, and we feel that it would now be better to separate from #freeipa (which has also grown). The proper IRC venue for the discussion of SSSD-r

Re: [SSSD] [PATCH] Don't double-sanitize member DNs

2011-01-19 Thread Sumit Bose
On Tue, Jan 18, 2011 at 12:20:44PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > After asking the cache for the list of member DNs for groups > during an initgroups request, we were passing it through the > sanitization function. Since this had already been

Re: [SSSD] [PATCH] Fix incorrect example file

2011-01-19 Thread Sumit Bose
On Tue, Jan 18, 2011 at 12:19:31PM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > The example sssd.conf still had entry_cache_timeout listed in the > [nss] section, and did not have correct values for > entry_cache_nowait_percentage (it was listed as > entry_

[SSSD] [PATCHES] Add pam_pwd_expiration_warning config option

2011-01-19 Thread Sumit Bose
Hi, another new option, this time it is pam_pwd_expiration_warning the number of days a warning should be displayed before the password expires. While writing this patch I realized that it might not be a good idea to set pam_verbosity to 0 (no message at all) if confdb_get_int() fails. The second

Re: [SSSD] [PATCH] Add ipa_hbac_search_base config option

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/18/2011 09:40 AM, Sumit Bose wrote: > Hi, > > this patch makes the IPA HBAC access provider more flexible and should > fix trac ticket #777. > Ack. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks

Re: [SSSD] [PATCHES] Add AD and RHDS/IPA expire policy

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/18/2011 05:24 AM, Sumit Bose wrote: > Hi, > > the following two patches add expired policies for AD and RHDS/IPA and > should fix trac ticket #674 and #679, respectively. > Patch 0001: Ack. Patch 0002: Nack. Could we please use "389ds" instea

Re: [SSSD] [PATCH] Fix return value check

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 07:42 AM, Sumit Bose wrote: > On Wed, Jan 19, 2011 at 06:49:26AM -0500, Stephen Gallagher wrote: > On 01/19/2011 06:42 AM, Sumit Bose wrote: On Wed, Jan 19, 2011 at 06:29:17AM -0500, Stephen Gallagher wrote: On 01/19/2011 06:16

Re: [SSSD] [PATCH] Fix return value check

2011-01-19 Thread Sumit Bose
On Wed, Jan 19, 2011 at 06:49:26AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/19/2011 06:42 AM, Sumit Bose wrote: > > On Wed, Jan 19, 2011 at 06:29:17AM -0500, Stephen Gallagher wrote: > > On 01/19/2011 06:16 AM, Sumit Bose wrote: > Hi, >

Re: [SSSD] [PATCH] Fix return value check

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 06:42 AM, Sumit Bose wrote: > On Wed, Jan 19, 2011 at 06:29:17AM -0500, Stephen Gallagher wrote: > On 01/19/2011 06:16 AM, Sumit Bose wrote: Hi, this patch fixes a typo which leads to irritation log messages. > > > As a g

Re: [SSSD] [PATCH] Fix return value check

2011-01-19 Thread Sumit Bose
On Wed, Jan 19, 2011 at 06:29:17AM -0500, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 01/19/2011 06:16 AM, Sumit Bose wrote: > > Hi, > > > > this patch fixes a typo which leads to irritation log messages. > > > As a general rule, I prefer explicit (ret != E

Re: [SSSD] [PATCH] Fix return value check

2011-01-19 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/19/2011 06:16 AM, Sumit Bose wrote: > Hi, > > this patch fixes a typo which leads to irritation log messages. As a general rule, I prefer explicit (ret != EOK) checks. Yes, I know they're identical, but it reads better. - -- Stephen Gallaghe

[SSSD] [PATCH] Fix return value check

2011-01-19 Thread Sumit Bose
Hi, this patch fixes a typo which leads to irritation log messages. bye, Sumit From c530a022096338a7c7e4e09da96afa3398e599a3 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Wed, 19 Jan 2011 09:31:31 +0100 Subject: [PATCH] Fix return value check --- src/providers/ldap/ldap_auth.c |2 +- 1 f