Re: [SSSD] [PATCH] Require existence of GID number in group searches

2011-03-14 Thread Sumit Bose
On Mon, Mar 14, 2011 at 10:00:12AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/11/2011 10:51 AM, Sumit Bose wrote: On Fri, Mar 11, 2011 at 05:56:57AM -0500, Stephen Gallagher wrote: This is most commonly seen with ActiveDirectory?. The 'group'

Re: [SSSD] [PATCH] Fix one unlikely case of failure in sdap_id_op module

2011-03-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/11/2011 08:18 AM, Jan Zelený wrote: There can be an unlikely scenario when the first part of sdap_id_op_connect_done works fine and there is no need to mark backend offline. But right after the check, the memory allocation can fail in which

Re: [SSSD] [PATCH] Fix one unlikely case of failure in sdap_id_op module

2011-03-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2011 02:13 PM, Stephen Gallagher wrote: On 03/11/2011 08:18 AM, Jan Zelený wrote: There can be an unlikely scenario when the first part of sdap_id_op_connect_done works fine and there is no need to mark backend offline. But right after

Re: [SSSD] [PATCH] Require existence of GID number in group searches

2011-03-14 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2011 10:29 AM, Sumit Bose wrote: On Mon, Mar 14, 2011 at 10:00:12AM -0400, Stephen Gallagher wrote: After some discussion in IRC, we decided that the correct behavior is to skip groups that are missing mandatory arguments to play better