Re: [SSSD] [PATCH] HBAC: fix typos preventing proper hostgroup evaluation

2011-09-27 Thread Jakub Hrozek
On Tue, Sep 27, 2011 at 04:01:44PM -0400, Stephen Gallagher wrote: > Two stupid typos on my part broke host group support in the HBAC > rewrite. ACK ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/s

[SSSD] [PATCH] HBAC: fix typos preventing proper hostgroup evaluation

2011-09-27 Thread Stephen Gallagher
Two stupid typos on my part broke host group support in the HBAC rewrite. From 52debcfac8f73629cd7ad3dabc428c3a6a652ba4 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Tue, 27 Sep 2011 15:04:33 -0400 Subject: [PATCH] HBAC: fix typos preventing proper hostgroup evaluation --- src/providers

Re: [SSSD] [PATCH] improve handling of users with multiple names

2011-09-27 Thread Jakub Hrozek
On Tue, Sep 27, 2011 at 11:39:51AM -0400, Stephen Gallagher wrote: > On Mon, 2011-09-26 at 18:20 +0200, Jakub Hrozek wrote: > > > > After discussing the approach with Simo on #sssd, I added a comment > > explaining what sysdb_attrs_get_aliases() does. > > > > New patches attached. > > Patch 0001

Re: [SSSD] [PATCH] improve handling of users with multiple names

2011-09-27 Thread Stephen Gallagher
On Mon, 2011-09-26 at 18:20 +0200, Jakub Hrozek wrote: > > After discussing the approach with Simo on #sssd, I added a comment > explaining what sysdb_attrs_get_aliases() does. > > New patches attached. Patch 0001: What's the value of returning NULL for the aliases list if there are none? Wouldn

Re: [SSSD] [PATCH] Fixed bad logic in LDAP netgroups

2011-09-27 Thread Stephen Gallagher
On Tue, 2011-09-27 at 16:28 +0200, Jan Zelený wrote: > Found it when writing IPA netgroups. It causes no serious harm, it just > causes > some addition queries to the LDAP server being made. Ack signature.asc Description: This is a digitally signed message part

Re: [SSSD] [PATCH] Multiline macro cleanup

2011-09-27 Thread Stephen Gallagher
On Fri, 2011-09-23 at 09:47 +0200, Jakub Hrozek wrote: > This is mostly a cosmetic patch. > > The purpose of wrapping a multi-line macro in a do { } while(0) is to > make the macro usable as a regular statement, not a compound statement. > > When the while(0) is terminated with a semicolon, the d

Re: [SSSD] Fast reply - offline

2011-09-27 Thread Stephen Gallagher
On Tue, 2011-09-27 at 16:26 +0200, Jan Zelený wrote: > > On Tue, Sep 27, 2011 at 03:56:57PM +0200, Ondrej Valousek wrote: > > >Hi List, > > > > > >I experience sometimes sssd reports certain users as not existing - > > > > >symptoms in log are the following: > > That's because at t

[SSSD] [PATCH] Fixed bad logic in LDAP netgroups

2011-09-27 Thread Jan Zelený
Found it when writing IPA netgroups. It causes no serious harm, it just causes some addition queries to the LDAP server being made. Jan From bdbb430ceb5ab5e027e5d6e1b5ab6e681a987feb Mon Sep 17 00:00:00 2001 From: Jan Zeleny Date: Tue, 27 Sep 2011 10:19:56 -0400 Subject: [PATCH] Fixed bad logic i

Re: [SSSD] Fast reply - offline

2011-09-27 Thread Jan Zelený
> On Tue, Sep 27, 2011 at 03:56:57PM +0200, Ondrej Valousek wrote: > >Hi List, > > > >I experience sometimes sssd reports certain users as not existing - > > >symptoms in log are the following: > That's because at the time the request came, the SSSD back end was > marked as "offlin

Re: [SSSD] Fast reply - offline

2011-09-27 Thread Jakub Hrozek
On Tue, Sep 27, 2011 at 03:56:57PM +0200, Ondrej Valousek wrote: >Hi List, > >I experience sometimes sssd reports certain users as not existing - >symptoms in log are the following: That's because at the time the request came, the SSSD back end was marked as "offline" and the user was

Re: [SSSD] Fast reply - offline

2011-09-27 Thread Jakub Hrozek
On Tue, Sep 27, 2011 at 03:56:57PM +0200, Ondrej Valousek wrote: >(Tue Sep 27 15:38:40 2011) [sssd[be[default]]] [sysdb_attrs_primary_name] >(1): Could not determine primary name: [22][Invalid argument] Actually this is interesting as well. What version exactly are you running? There was

[SSSD] Fast reply - offline

2011-09-27 Thread Ondrej Valousek
Hi List, I experience sometimes sssd reports certain users as not existing - symptoms in log are the following: (Tue Sep 27 15:30:17 2011) [sssd[nss]] [accept_fd_handler] (4): Client connected! (Tue Sep 27 15:30:17 2011) [sssd[nss]] [sss_cmd_get_version] (5): Received client version [1]. (Tue

Re: [SSSD] [PATCH] The new memberof plugin

2011-09-27 Thread Trond Hasle Amundsen
Jan Zelený writes: >> > As you described it, it looks like issue similar to what Stephen found >> > earlier and is now fixed. It probably isn't caused by the size of >> > groups but rather membership structure. Could you be more specific how >> > the structure is organized? Do you use rfc2307 or

Re: [SSSD] [PATCH] The new memberof plugin

2011-09-27 Thread Jan Zelený
> Jan Zelený writes: > > As you described it, it looks like issue similar to what Stephen found > > earlier and is now fixed. It probably isn't caused by the size of > > groups but rather membership structure. Could you be more specific how > > the structure is organized? Do you use rfc2307 or rfc