Re: [SSSD] [PATCH 0/4]: Actual memory cache implementation

2012-01-09 Thread Stephen Gallagher
On Mon, 2012-01-09 at 18:24 -0500, Simo Sorce wrote: > On Mon, 2012-01-09 at 16:30 -0500, Stephen Gallagher wrote: > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > > > 0/4: Actual memory cache implementation > > > The

Re: [SSSD] [PATCH] old glibc compat

2012-01-09 Thread Stephen Gallagher
On Mon, 2012-01-09 at 18:00 -0500, Simo Sorce wrote: > The murmurhash3.c file is using macros from endian.h that are not > available in glibc 2.5 apparently. > > The attached patch fixes the build on such machines (like RHEL5). Ack and pushed to master. signature.asc Description: This is a digi

[SSSD] [PATCH] NSS: Add sss_readrep_copy_string

2012-01-09 Thread Stephen Gallagher
There were many places in the client code where we were duplicating a loop to copy data in from the response buffer. This patch turns those loops into a function for easier maintenance and easier-to-read *readrep() routines. The netgroup code required the addition of a "temp" string while doing th

Re: [SSSD] [PATCH 0/4]: Actual memory cache implementation

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 18:24 -0500, Simo Sorce wrote: > > I will review the other patches tomorrow. > > Thanks! Oh btw I just found a bug in the client libs that would cause libnss_sss.so to reopen the fast cache file at every operation until it ran out of file descriptors, oops :-) New patch at

Re: [SSSD] [PATCH 0/4]: Actual memory cache implementation

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 16:30 -0500, Stephen Gallagher wrote: > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > 0/4: Actual memory cache implementation > > These is the bulk of the work, these patches are still a bit rough a

[SSSD] [PATCH] old glibc compat

2012-01-09 Thread Simo Sorce
The murmurhash3.c file is using macros from endian.h that are not available in glibc 2.5 apparently. The attached patch fixes the build on such machines (like RHEL5). Simo. -- Simo Sorce * Red Hat, Inc * New York >From 1862aa87ed353befd59fc04c82277c4c239c5647 Mon Sep 17 00:00:00 2001 From: Simo

Re: [SSSD] [PATCH 0/4]: Actual memory cache implementation

2012-01-09 Thread Stephen Gallagher
On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > >From [PATCH 0/0] A shared memory cache to perform better: > > 0/4: Actual memory cache implementation > These is the bulk of the work, these patches are still a bit rough at > the edges, grep for FIXMEs and TODOs and you'll see some plumbing

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 14:45 -0500, Stephen Gallagher wrote: > On Mon, 2012-01-09 at 14:34 -0500, Simo Sorce wrote: > > On Mon, 2012-01-09 at 13:52 -0500, Simo Sorce wrote: > > > On Mon, 2012-01-09 at 13:37 -0500, Stephen Gallagher wrote: > > > > On Mon, 2012-01-09 at 13:36 -0500, Simo Sorce wrote:

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Stephen Gallagher
On Mon, 2012-01-09 at 14:34 -0500, Simo Sorce wrote: > On Mon, 2012-01-09 at 13:52 -0500, Simo Sorce wrote: > > On Mon, 2012-01-09 at 13:37 -0500, Stephen Gallagher wrote: > > > On Mon, 2012-01-09 at 13:36 -0500, Simo Sorce wrote: > > > > On Mon, 2012-01-09 at 13:27 -0500, Simo Sorce wrote: > > > >

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 13:52 -0500, Simo Sorce wrote: > On Mon, 2012-01-09 at 13:37 -0500, Stephen Gallagher wrote: > > On Mon, 2012-01-09 at 13:36 -0500, Simo Sorce wrote: > > > On Mon, 2012-01-09 at 13:27 -0500, Simo Sorce wrote: > > > > On Mon, 2012-01-09 at 12:58 -0500, Stephen Gallagher wrote:

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 13:49 -0500, Stephen Gallagher wrote: > > > > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > > > > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > > > > > I have one other question about this patch. Would you mind identifying > why you chose

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 13:37 -0500, Stephen Gallagher wrote: > On Mon, 2012-01-09 at 13:36 -0500, Simo Sorce wrote: > > On Mon, 2012-01-09 at 13:27 -0500, Simo Sorce wrote: > > > On Mon, 2012-01-09 at 12:58 -0500, Stephen Gallagher wrote: > > > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote:

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Stephen Gallagher
> > > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > > > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > > I have one other question about this patch. Would you mind identifying why you chose to go with the murmurhash3 algorithm instead of expanding dhash to expo

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Stephen Gallagher
On Mon, 2012-01-09 at 13:36 -0500, Simo Sorce wrote: > On Mon, 2012-01-09 at 13:27 -0500, Simo Sorce wrote: > > On Mon, 2012-01-09 at 12:58 -0500, Stephen Gallagher wrote: > > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > > > >From [PATCH 0/0] A shared memory cache to perform better: >

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 13:27 -0500, Simo Sorce wrote: > On Mon, 2012-01-09 at 12:58 -0500, Stephen Gallagher wrote: > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > > > 0/3: New utility functions/headers > > > These ar

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Stephen Gallagher
On Mon, 2012-01-09 at 13:27 -0500, Simo Sorce wrote: > On Mon, 2012-01-09 at 12:58 -0500, Stephen Gallagher wrote: > > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > > > 0/3: New utility functions/headers > > > These ar

Re: [SSSD] [PATCH 0/2] changes to make life easier for later patches

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 12:01 -0500, Stephen Gallagher wrote: > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > 0/2: changes to make life easier for later patches > > These change some internals of fill_pwent() and fiull_gre

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Simo Sorce
On Mon, 2012-01-09 at 12:58 -0500, Stephen Gallagher wrote: > On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > > >From [PATCH 0/0] A shared memory cache to perform better: > > > > 0/3: New utility functions/headers > > These are also quite straightforward but they are useless without the > >

Re: [SSSD] [DESIGN]SELinux user roles

2012-01-09 Thread Dmitri Pal
On 01/09/2012 12:18 PM, Jan Zelený wrote: > Hello everybody, > I'm sending a rough design of SELinux rules and the architecture of how I > plan > to implement them. This a plan that I came up with kinda quickly, so it's > rather crude, please consider it only aguidance to show concepts, don't lo

Re: [SSSD] [PATCH 0/3]: New utility functions/headers

2012-01-09 Thread Stephen Gallagher
On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > >From [PATCH 0/0] A shared memory cache to perform better: > > 0/3: New utility functions/headers > These are also quite straightforward but they are useless without the > later patches Nack. Your implementation doesn't match the original:

[SSSD] [DESIGN]SELinux user roles

2012-01-09 Thread Jan Zelený
Hello everybody, I'm sending a rough design of SELinux rules and the architecture of how I plan to implement them. This a plan that I came up with kinda quickly, so it's rather crude, please consider it only aguidance to show concepts, don't look for exact attribute names and similar stuff. Wha

Re: [SSSD] [PATCH 0/2] changes to make life easier for later patches

2012-01-09 Thread Stephen Gallagher
On Tue, 2012-01-03 at 18:00 -0500, Simo Sorce wrote: > >From [PATCH 0/0] A shared memory cache to perform better: > > 0/2: changes to make life easier for later patches > These change some internals of fill_pwent() and fiull_grent() and can be > applied on their own. I think they also simplify, sl

Re: [SSSD] FS location for 3rd party modules?

2012-01-09 Thread Simo Sorce
On Sun, 2012-01-08 at 17:40 -0500, Stephen Gallagher wrote: > > On Jan 8, 2012, at 5:09 PM, Jakub Hrozek wrote: > > > Hi, > > > > starting with sssd 1.8 we are going to support two third party applications > > - > > sudo and autofs. In both cases we are going to provide a library these > > app