[SSSD] [PATCH] Refactor sss_result into sss_sudo_result

2012-02-13 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/1159 I sent this patch to Daniel so the patched sudo package should come in shortly. From 43eea9c6574e400a5617dd3047fdbdd1326b3847 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 13 Feb 2012 09:42:03 +0100 Subject: [PATCH] Refactor

Re: [SSSD] [PATCH] Redesign purging of the sudo cache

2012-02-13 Thread Pavel Březina
Dne 13.2.2012 17:32, Jakub Hrozek napsal(a): On Fri, Feb 10, 2012 at 02:32:06PM +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1173 sysdb_sudo_build_sudouser(): Are there any cases where username would be unset but there would be UID and groups? Probably not. Can we simpl

Re: [SSSD] [PATCHES] Assorted issues discovered by Coverity

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 17:52 +0100, Jakub Hrozek wrote: > On Mon, Feb 13, 2012 at 10:59:57AM -0500, Stephen Gallagher wrote: > > All of these patches are being submitted for both master and sssd-1-8. > > > > Patch 0001: Remove some leftover code that was unreachable > > > > Ack > > > Patch 0002:

Re: [SSSD] [PATCHES] Assorted issues discovered by Coverity

2012-02-13 Thread Jakub Hrozek
On Mon, Feb 13, 2012 at 10:59:57AM -0500, Stephen Gallagher wrote: > All of these patches are being submitted for both master and sssd-1-8. > > Patch 0001: Remove some leftover code that was unreachable > Ack > Patch 0002: Make sure to check for NULL on malloc() in pam_sss.c Ack > > Patch 00

[SSSD] [PATCH] SSH: Build man pages conditionally

2012-02-13 Thread Jan Cholasta
https://fedorahosted.org/sssd/ticket/1175 Honza -- Jan Cholasta >From 677766cd27ff8221632423629ee120e69a49ee0d Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 13 Feb 2012 11:48:31 -0500 Subject: [PATCH] SSH: Build man pages conditionally https://fedorahosted.org/sssd/ticket/1175 --- co

Re: [SSSD] [PATCH] Free memory properly during setent operations

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 11:42 -0500, Stephen Gallagher wrote: > On Mon, 2012-02-13 at 15:14 +0100, Jakub Hrozek wrote: > > The attached two patches fix https://fedorahosted.org/sssd/ticket/1189 > > that was mostly manifested by ""BUG: a callback did not free its > > request." during enumeration (and

Re: [SSSD] [PATCH] SSH: Verify that names received from client are valid UTF-8 in responder

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 11:35 -0500, Stephen Gallagher wrote: > On Mon, 2012-02-13 at 17:22 +0100, Jan Cholasta wrote: > > Also added a comment describing the wire format of client requests and > > responses. > > > > https://fedorahosted.org/sssd/ticket/1177 > > Ack for master and sssd-1-8. Pushe

Re: [SSSD] [PATCH] Free memory properly during setent operations

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 15:14 +0100, Jakub Hrozek wrote: > The attached two patches fix https://fedorahosted.org/sssd/ticket/1189 > that was mostly manifested by ""BUG: a callback did not free its > request." during enumeration (and reading of the autofs map). > > [PATCH 1/2] Remove setent structure

Re: [SSSD] [PATCH] SSH: Verify that names received from client are valid UTF-8 in responder

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 17:22 +0100, Jan Cholasta wrote: > Also added a comment describing the wire format of client requests and > responses. > > https://fedorahosted.org/sssd/ticket/1177 Ack for master and sssd-1-8. signature.asc Description: This is a digitally signed message part ___

Re: [SSSD] [PATCH] Redesign purging of the sudo cache

2012-02-13 Thread Jakub Hrozek
On Fri, Feb 10, 2012 at 02:32:06PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1173 sysdb_sudo_build_sudouser(): Are there any cases where username would be unset but there would be UID and groups? Can we simplify the logic by always allocating one of the three (or maybe two

[SSSD] [PATCH] SSH: Verify that names received from client are valid UTF-8 in responder

2012-02-13 Thread Jan Cholasta
Also added a comment describing the wire format of client requests and responses. https://fedorahosted.org/sssd/ticket/1177 Honza -- Jan Cholasta >From b1007b1c911c804bb70caf0fdd0fe3962be64374 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Mon, 13 Feb 2012 10:10:40 -0500 Subject: [PATCH] S

[SSSD] [PATCHES] Assorted issues discovered by Coverity

2012-02-13 Thread Stephen Gallagher
All of these patches are being submitted for both master and sssd-1-8. Patch 0001: Remove some leftover code that was unreachable Patch 0002: Make sure to check for NULL on malloc() in pam_sss.c Patch 0003: Avoid an uninitialized value comparison on ret in check_cache() Patch 0004: Add missing

Re: [SSSD] [PATCH] Don't give memory context in confdb where not needed

2012-02-13 Thread Jakub Hrozek
On Fri, Feb 10, 2012 at 02:21:01PM +0100, Jan Zelený wrote: > > This will make confdb coherent with changes made in sysdb. Not using > > context hierarchy will help detecting memory leaks if there are some. > > Self nack on the first version, I skipped one call of confdb_get_int() in ssh > module

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Simo Sorce
On Mon, 2012-02-13 at 07:49 -0500, Stephen Gallagher wrote: > Modify the file. Then do a 'git add '. Then instead of doing > regular 'git commit', you can do 'git commit --amend'. This will add the > changes you just made to the previous commit in the list. Now just 'git > format-patch -M -C --pat

[SSSD] [PATCH] SSH: Continue connecting to SSH server even when SSSD is not running in sss_ssh_knownhostsproxy

2012-02-13 Thread Jan Cholasta
Additionally, don't drop the connection when the sss_ssh_knownhostsproxy process receives a signal. https://fedorahosted.org/sssd/ticket/1179 https://fedorahosted.org/sssd/ticket/1184 Honza -- Jan Cholasta >From 1638b90baf391ee1db9b88eb9ba96f5125be3d59 Mon Sep 17 00:00:00 2001 From: Jan Cholas

[SSSD] [PATCH] Free memory properly during setent operations

2012-02-13 Thread Jakub Hrozek
The attached two patches fix https://fedorahosted.org/sssd/ticket/1189 that was mostly manifested by ""BUG: a callback did not free its request." during enumeration (and reading of the autofs map). [PATCH 1/2] Remove setent structure when callback is called The setent_remove_ref() destructor was o

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Marco Pizzoli
2012/2/13 Pavel Březina > Dne 13.2.2012 14:14, Stephen Gallagher napsal(a): > > On Mon, 2012-02-13 at 14:10 +0100, Pavel Březina wrote: >> >>> Dne 13.2.2012 14:05, Stephen Gallagher napsal(a): >>> On Mon, 2012-02-13 at 13:58 +0100, Pavel Březina wrote: > Hi, >>> Ok, I understan

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Pavel Březina
Dne 13.2.2012 14:14, Stephen Gallagher napsal(a): On Mon, 2012-02-13 at 14:10 +0100, Pavel Březina wrote: Dne 13.2.2012 14:05, Stephen Gallagher napsal(a): On Mon, 2012-02-13 at 13:58 +0100, Pavel Březina wrote: Hi, Ok, I understand and agree. Now it's time for a second lesson of git :-) How

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 14:10 +0100, Pavel Březina wrote: > Dne 13.2.2012 14:05, Stephen Gallagher napsal(a): > > On Mon, 2012-02-13 at 13:58 +0100, Pavel Březina wrote: > Hi, > Ok, I understand and agree. > > Now it's time for a second lesson of git :-) > How can I correct t

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Pavel Březina
Dne 13.2.2012 14:05, Stephen Gallagher napsal(a): On Mon, 2012-02-13 at 13:58 +0100, Pavel Březina wrote: Hi, Ok, I understand and agree. Now it's time for a second lesson of git :-) How can I correct the patch? What steps do I have to follow? re-clone from scratch? Editing the file again produ

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 13:58 +0100, Pavel Březina wrote: > >> Hi, > >> Ok, I understand and agree. > >> > >> Now it's time for a second lesson of git :-) > >> How can I correct the patch? What steps do I have to follow? > >> re-clone from scratch? Editing the file again produce me a diff with > >> m

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Pavel Březina
Hi, Ok, I understand and agree. Now it's time for a second lesson of git :-) How can I correct the patch? What steps do I have to follow? re-clone from scratch? Editing the file again produce me a diff with modified only one file... Modify the file. Then do a 'git add'. Then instead of doing r

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Stephen Gallagher
On Mon, 2012-02-13 at 13:40 +0100, Marco Pizzoli wrote: > > > On Mon, Feb 13, 2012 at 12:31 PM, Jakub Hrozek > wrote: > On Sun, Feb 12, 2012 at 12:29:36PM +0100, Marco Pizzoli wrote: > >As I reported on the mailing list: > >- sssd.conf man page does not include "a

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Marco Pizzoli
On Mon, Feb 13, 2012 at 12:31 PM, Jakub Hrozek wrote: > On Sun, Feb 12, 2012 at 12:29:36PM +0100, Marco Pizzoli wrote: > >As I reported on the mailing list: > >- sssd.conf man page does not include "autofs" and "ssh" as supported > >services. https://fedorahosted.org/sssd/ticket/1183

Re: [SSSD] [PATCH] Two manual pages fixes

2012-02-13 Thread Jakub Hrozek
On Sun, Feb 12, 2012 at 12:29:36PM +0100, Marco Pizzoli wrote: >As I reported on the mailing list: >- sssd.conf man page does not include "autofs" and "ssh" as supported >services. https://fedorahosted.org/sssd/ticket/1183 >- sssd-ldap.conf man page should have "not set" instead of