Thanks to comments
From: sgall...@redhat.com
To: sssd-devel@lists.fedorahosted.org
Date: Mon, 14 May 2012 07:22:16 -0400
Subject: Re: [SSSD] [PATCH] 1332-Abort unit test when open() fails
On Mon, 2012-05-14 at 10:22 +0200, Jakub Hrozek wrote:
> On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Bar
On Mon, May 14, 2012 at 06:39:30PM +0200, Pavel Březina wrote:
> On 9.5.2012 17:07, Pavel Březina wrote:
> >On 05/07/2012 07:13 PM, Pavel Březina wrote:
> >>On 04/23/2012 06:34 PM, Pavel Březina wrote:
> >>>On 04/23/2012 05:04 PM, Pavel Březina wrote:
> Hello everybody,
> here is the first
On 14.5.2012 20:40, Stephen Gallagher wrote:
On Mon, 2012-05-14 at 13:16 -0400, Simo Sorce wrote:
On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote:
- it ignores modifyTimestamp - simo suggested to use it in smart
refresh when enabled in configuration and USN not available, but
do
On Mon, 2012-05-14 at 16:05 +0200, Jakub Hrozek wrote:
> I found two sssd_nss bugs pretty much by accident.
>
> [PATCH 1/2] NSS: keep a pointer to body after body is reallocated
> When a memory is reallocated with talloc_realloc, the original pointer
> might be relocated elsewhere. The "fullname"
On Mon, 2012-05-14 at 13:16 -0400, Simo Sorce wrote:
> On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote:
> > - it ignores modifyTimestamp - simo suggested to use it in smart
> > refresh when enabled in configuration and USN not available, but
> > do
> > we really want to use it? There
On Mon, 2012-05-14 at 18:39 +0200, Pavel Březina wrote:
> - it ignores modifyTimestamp - simo suggested to use it in smart
> refresh when enabled in configuration and USN not available, but
> do
> we really want to use it? There is no other part in sssd that uses
> it
> (or am I wrong?)
On Mon, May 14, 2012 at 05:55:09PM +0200, Pavel Březina wrote:
> On 11.5.2012 12:23, Pavel Březina wrote:
> >On 05/07/2012 07:17 PM, Pavel Březina wrote:
> >>On 05/03/2012 10:30 PM, Pavel Březina wrote:
> >>>On 3.5.2012 13:48, Jakub Hrozek wrote:
> On Fri, Apr 27, 2012 at 01:21:30PM +0200, Jaku
On Mon, 2012-05-14 at 09:48 -0400, Stephen Gallagher wrote:
> On Mon, 2012-05-14 at 15:38 +0200, Sumit Bose wrote:
> > Hi,
> >
> > while checking the version of libsss_idmap I found that there is a typo
> > for libsss_hbac as well. This patch should fix it.
>
>
> Ack.
>
> As with libsss_idmap,
On Mon, 2012-05-14 at 09:47 -0400, Stephen Gallagher wrote:
> On Mon, 2012-05-14 at 15:37 +0200, Sumit Bose wrote:
> > On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote:
> > > On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote:
> > > > On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose
On Mon, 2012-05-14 at 09:45 -0400, Stephen Gallagher wrote:
> On Mon, 2012-05-14 at 10:13 +0200, Jan Zelený wrote:
> > > On Thu, 2012-05-10 at 11:15 +0200, Jakub Hrozek wrote:
> > > > On Wed, May 09, 2012 at 07:19:29PM -0400, Stephen Gallagher wrote:
> > > > > On Wed, 2012-05-09 at 22:20 +0200, Jak
On Mon, 2012-05-14 at 09:34 +0200, Jan Zelený wrote:
> > A patch by Yuri Chornoivan. I had to look up supercede vs. supersede but
> > it seems Yuri is right.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=821088
>
> Ack
Pushed to master.
signature.asc
Description: This is a digitally sig
On Sun, 2012-05-13 at 20:42 +0200, Jakub Hrozek wrote:
> On Sat, May 12, 2012 at 11:05:30AM -0500, Ariel Barria wrote:
> >https://fedorahosted.org/sssd/ticket/1333
>
> Ack, thanks for the patch!
Pushed to master and sssd-1-8.
signature.asc
Description: This is a digitally signed message par
Joshua Roys submitted a patch in
https://bugzilla.redhat.com/show_bug.cgi?id=726456 to add support for
the Netscape password warning expiration control. I've made some
modifications to his original patch to clean it up, so now I'm sending
it to the list for further code-review.
Fixes https://fedor
On Mon, 2012-05-14 at 10:09 -0400, Stephen Gallagher wrote:
> On Mon, 2012-05-14 at 15:58 +0200, Daniel Löw wrote:
> > Hello!
> >
> > I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login
> > even when I am offline.
> > Everyting works great, but if I take the laptop home with me, a
On 05/14/2012 09:58 AM, Daniel Löw wrote:
> Hello!
>
> I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login
> even when I am offline.
> Everyting works great, but if I take the laptop home with me, and
> connect it to my home network, i cant login.
> Then it says that i have the wrong
On Mon, 2012-05-14 at 15:58 +0200, Daniel Löw wrote:
> Hello!
>
> I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login
> even when I am offline.
> Everyting works great, but if I take the laptop home with me, and
> connect it to my home network, i cant login.
> Then it says that i
I found two sssd_nss bugs pretty much by accident.
[PATCH 1/2] NSS: keep a pointer to body after body is reallocated
When a memory is reallocated with talloc_realloc, the original pointer
might be relocated elsewhere. The "fullname" pointer used to point to
the original location before realloc whi
Hello!
I'am using sssd 1.8 on an Ubuntu 12.04 laptop. So that I can login even
when I am offline.
Everyting works great, but if I take the laptop home with me, and
connect it to my home network, i cant login.
Then it says that i have the wrong password. then if I want to be able
to login i nee
On Mon, 2012-05-14 at 15:38 +0200, Sumit Bose wrote:
> Hi,
>
> while checking the version of libsss_idmap I found that there is a typo
> for libsss_hbac as well. This patch should fix it.
Ack.
As with libsss_idmap, this is NOT a soname bump. It only changes the
revision number.
signature.asc
On Mon, 2012-05-14 at 15:37 +0200, Sumit Bose wrote:
> On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote:
> > On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote:
> > > On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote:
> > > > Hi,
> > > >
> > > > although we currently use the sa
On Mon, 2012-05-14 at 10:13 +0200, Jan Zelený wrote:
> > On Thu, 2012-05-10 at 11:15 +0200, Jakub Hrozek wrote:
> > > On Wed, May 09, 2012 at 07:19:29PM -0400, Stephen Gallagher wrote:
> > > > On Wed, 2012-05-09 at 22:20 +0200, Jakub Hrozek wrote:
> > > > > Nack, the way ldap_get_dn is used leaks m
Hi,
while checking the version of libsss_idmap I found that there is a typo
for libsss_hbac as well. This patch should fix it.
bye,
Sumit
From 8f5dd8730af5ba3d0d9941909e692094170a Mon Sep 17 00:00:00 2001
From: Sumit Bose
Date: Mon, 14 May 2012 15:04:38 +0200
Subject: [PATCH] Fix libsss_hbac
On Mon, May 14, 2012 at 08:52:16AM -0400, Simo Sorce wrote:
> On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote:
> > On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote:
> > > Hi,
> > >
> > > although we currently use the same internal representation for struct
> > > dom_sid as samba does
On Mon, 2012-05-14 at 08:41 -0400, Dmitri Pal wrote:
>
> foo.conf is no different that other test config files that reside in
> the ini.d directory. I do not understand why the change needed for one
> and not for the others. Can you please elaborate?
Foo.conf is a special case. It's the only fil
On 05/14/2012 09:31 AM, Jan Zelený wrote:
>> On 05/14/2012 07:13 AM, Stephen Gallagher wrote:
>>> On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote:
> On 05/11/2012 04:21 PM, Dmitri Pal wrote:
>> On 05/11/2012 10:04 AM, Stephen Gallagher wrote:
>>> Patch 0001: The unit tests for libin
> On 05/14/2012 07:13 AM, Stephen Gallagher wrote:
> > On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote:
> >>> On 05/11/2012 04:21 PM, Dmitri Pal wrote:
> On 05/11/2012 10:04 AM, Stephen Gallagher wrote:
> > Patch 0001: The unit tests for libini_config need to be able to
> > validat
On 05/14/2012 07:13 AM, Stephen Gallagher wrote:
> On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote:
>>> On 05/11/2012 04:21 PM, Dmitri Pal wrote:
On 05/11/2012 10:04 AM, Stephen Gallagher wrote:
> Patch 0001: The unit tests for libini_config need to be able to validate
> specific p
On Mon, 2012-05-14 at 08:33 -0400, Stephen Gallagher wrote:
> On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote:
> > Hi,
> >
> > although we currently use the same internal representation for struct
> > dom_sid as samba does this might not be the case in future. To avoid
> > irritations this pat
On Mon, 2012-05-14 at 14:08 +0200, Sumit Bose wrote:
> Hi,
>
> although we currently use the same internal representation for struct
> dom_sid as samba does this might not be the case in future. To avoid
> irritations this patch changes the name to struct sss_dom_sid.
This qualifies as an ABI br
Hi,
although we currently use the same internal representation for struct
dom_sid as samba does this might not be the case in future. To avoid
irritations this patch changes the name to struct sss_dom_sid.
bye,
Sumit
From 4f383cf8758e3d92a456346d9e0a8e08d5cf8ed2 Mon Sep 17 00:00:00 2001
From: Sum
On Fri, 2012-05-11 at 23:02 +0200, Jan Engelhardt wrote:
> On Friday 2012-05-11 20:31, Stephen Gallagher wrote:
> >> sssd_be_LDADD = \
> >> -$(SSSD_LIBS) \
> >> +-ldl $(SSSD_LIBS) \
> >> $(CARES_LIBS) \
> >> libsss_util.la
> >> sssd_be_LDFLAGS = \
> >
> >While there's nothing wr
On Mon, 2012-05-14 at 10:22 +0200, Jakub Hrozek wrote:
> On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Barria wrote:
> >https://fedorahosted.org/sssd/ticket/1332
>
> > +if ( fd < 0 ){
>
> Thanks for the patch Ariel, but would you also mind amending the
> whitespace? We don't put whitesp
On Mon, 2012-05-14 at 09:19 +0200, Jan Zelený wrote:
> > On 05/11/2012 04:21 PM, Dmitri Pal wrote:
> > > On 05/11/2012 10:04 AM, Stephen Gallagher wrote:
> > >> Patch 0001: The unit tests for libini_config need to be able to validate
> > >> specific permissions on some sample data. However, 'make d
On Friday 2012-05-11 20:31, Stephen Gallagher wrote:
>> sssd_be_LDADD = \
>> -$(SSSD_LIBS) \
>> +-ldl $(SSSD_LIBS) \
>> $(CARES_LIBS) \
>> libsss_util.la
>> sssd_be_LDFLAGS = \
>
>While there's nothing wrong with this patch, you SHOULD be picking up
>the -ldl requirement from p
> On Thu, 2012-05-10 at 11:15 +0200, Jakub Hrozek wrote:
> > On Wed, May 09, 2012 at 07:19:29PM -0400, Stephen Gallagher wrote:
> > > On Wed, 2012-05-09 at 22:20 +0200, Jakub Hrozek wrote:
> > > > Nack, the way ldap_get_dn is used leaks memory:
> > > >
> > > > +DEBUG(SSSDBG_TRACE_I
> On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Barria wrote:
> >https://fedorahosted.org/sssd/ticket/1332
> >
> > +if ( fd < 0 ){
>
> Thanks for the patch Ariel, but would you also mind amending the
> whitespace? We don't put whitespace between brackets and the expression
> inside, but
On Sun, May 13, 2012 at 04:18:39PM -0500, Ariel Barria wrote:
>https://fedorahosted.org/sssd/ticket/1332
> +if ( fd < 0 ){
Thanks for the patch Ariel, but would you also mind amending the
whitespace? We don't put whitespace between brackets and the expression
inside, but we do put a space
> https://fedorahosted.org/sssd/ticket/1332
Obvious Ack,
Jan
signature.asc
Description: This is a digitally signed message part.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
> A patch by Yuri Chornoivan. I had to look up supercede vs. supersede but
> it seems Yuri is right.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=821088
Ack
Jan
signature.asc
Description: This is a digitally signed message part.
___
sssd-devel mai
> On Fri, 2012-05-11 at 09:41 +0200, Jan Zelený wrote:
> > > On Fri, 2012-05-11 at 09:10 +0200, Jan Zelený wrote:
> > > > > On Fri, 2012-05-11 at 08:38 +0200, Jan Zelený wrote:
> > > > > > I guess SSSD cache is probably the reason why you still have the
> > > > > > old GID. Try running sss_cache -G
> On 5/11/12 10:22 AM, Stephen Gallagher wrote:
> > On Fri, 2012-05-11 at 10:19 -0400, Braden McDaniel wrote:
> >> As I mentioned at the top of the thread, I changed the local group GID
> >> on the Fedora 16 installation to 989 (from 990) to match the Fedora 17
> >> installation. Things appear to
> On 05/11/2012 04:21 PM, Dmitri Pal wrote:
> > On 05/11/2012 10:04 AM, Stephen Gallagher wrote:
> >> Patch 0001: The unit tests for libini_config need to be able to validate
> >> specific permissions on some sample data. However, 'make distcheck'
> >> always removes the 'write' permissions on data
42 matches
Mail list logo