Re: [SSSD] [PATCHES] Add support for multiple servers in the Kerberos locator plugin

2012-07-18 Thread Stephen Gallagher
On Wed, 2012-07-18 at 10:11 -0400, Simo Sorce wrote: > > This is sadly a final NACK. > > We discussed this on IRC, and we agreed this approach is a dead end. > There are various reasons. > > The concurrency issue comes in in threaded applications where multiple > threads use kerberos at the same

Re: [SSSD] [PATCH] First Boot Seed Tool

2012-07-18 Thread Stephen Gallagher
On Wed, 2012-07-18 at 12:22 -0400, Nick Guay wrote: > This tool is used to seed the cache with user information and a > temporary password if the system does not have direct connectivity to a > IPA/AD/LDAP provider at first boot. It requires a username and domain to > be specified, and the corre

[SSSD] Announcing SSSD 1.9.0 beta 5

2012-07-18 Thread Jakub Hrozek
The SSSD team is proud to announce the fifth of six preview releases of version 1.9 of the System Security Services Daemon. Beta 6 will be released on July 31st and will contain a new tool for "seeding" accounts with a temporary password for sending machines to remotees as well as introducing a co

Re: [SSSD] [PATCH] PAM: Fix off-by-one-error in the SELinux session code

2012-07-18 Thread Stephen Gallagher
On Wed, 2012-07-18 at 14:40 -0400, Stephen Gallagher wrote: > On Wed, 2012-07-18 at 20:37 +0200, Jakub Hrozek wrote: > > This was causing unpredictable behaviour when writing the SELinux user > > -- because the string wasn't NULL-terminated, the PAM module sometimes > > wrote junk into the logins f

Re: [SSSD] [PATCH] AD: Fix defaults for krb5_canonicalize

2012-07-18 Thread Stephen Gallagher
On Wed, 2012-07-18 at 20:28 +0200, Jakub Hrozek wrote: > On Wed, Jul 18, 2012 at 02:23:31PM -0400, Stephen Gallagher wrote: > > The AD provider cannot function with canonicalization because of > > a bug in Active Directory rendering it unable to complete a > > password-change while canonicalization

Re: [SSSD] [PATCH] PAM: Fix off-by-one-error in the SELinux session code

2012-07-18 Thread Stephen Gallagher
On Wed, 2012-07-18 at 20:37 +0200, Jakub Hrozek wrote: > This was causing unpredictable behaviour when writing the SELinux user > -- because the string wasn't NULL-terminated, the PAM module sometimes > wrote junk into the logins file. Obvious ack. signature.asc Description: This is a digitally

[SSSD] [PATCH] PAM: Fix off-by-one-error in the SELinux session code

2012-07-18 Thread Jakub Hrozek
This was causing unpredictable behaviour when writing the SELinux user -- because the string wasn't NULL-terminated, the PAM module sometimes wrote junk into the logins file. >From 94e643a5edd8396c150ef31296499b8e632b8aa5 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 18 Jul 2012 20:35:45

Re: [SSSD] [PATCH] AD: Fix defaults for krb5_canonicalize

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 02:23:31PM -0400, Stephen Gallagher wrote: > The AD provider cannot function with canonicalization because of > a bug in Active Directory rendering it unable to complete a > password-change while canonicalization is enabled. > > I had set the default properly in the LDAP op

[SSSD] [PATCH] AD: Fix defaults for krb5_canonicalize

2012-07-18 Thread Stephen Gallagher
The AD provider cannot function with canonicalization because of a bug in Active Directory rendering it unable to complete a password-change while canonicalization is enabled. I had set the default properly in the LDAP options, but forgot to set it the same in the Kerberos options, resulting in un

Re: [SSSD] [PATCH]Fix uninitialized values

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 07:03:00PM +0200, Pavel Březina wrote: > On 18.7.2012 18:13, Nick Guay wrote: > >On 18/07/12 06:44, Pavel Březina wrote: > >>On 07/17/2012 11:21 PM, Nick Guay wrote: > >>>On 17/07/12 16:09, Jakub Hrozek wrote: > On Mon, Jul 16, 2012 at 04:41:22PM -0400, Nick Guay wrote:

Re: [SSSD] [PATCH] Fixed: Unchecked return value from dp_opt_set_int.

2012-07-18 Thread Dmitri Pal
On 07/19/2012 06:18 AM, Michal Zidek wrote: > Fixed unchecked return value from function dp_opt_set_int in file > src/tests/krb5_child-test.c. > > > ___ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listi

Re: [SSSD] [PATCH]Fix uninitialized values

2012-07-18 Thread Pavel Březina
On 18.7.2012 18:13, Nick Guay wrote: On 18/07/12 06:44, Pavel Březina wrote: On 07/17/2012 11:21 PM, Nick Guay wrote: On 17/07/12 16:09, Jakub Hrozek wrote: On Mon, Jul 16, 2012 at 04:41:22PM -0400, Nick Guay wrote: Patch for uninitialized values when building with -Wmaybe-uninitialized. Hi

[SSSD] [PATCH] First Boot Seed Tool

2012-07-18 Thread Nick Guay
This tool is used to seed the cache with user information and a temporary password if the system does not have direct connectivity to a IPA/AD/LDAP provider at first boot. It requires a username and domain to be specified, and the corresponding domain must be configured in sssd.conf. https://f

Re: [SSSD] [PATCH]Fix uninitialized values

2012-07-18 Thread Nick Guay
On 18/07/12 06:44, Pavel Březina wrote: On 07/17/2012 11:21 PM, Nick Guay wrote: On 17/07/12 16:09, Jakub Hrozek wrote: On Mon, Jul 16, 2012 at 04:41:22PM -0400, Nick Guay wrote: Patch for uninitialized values when building with -Wmaybe-uninitialized. Hi Nick, the patch fixes most of the w

Re: [SSSD] [PATCH] IPA: Return and save all SELinux rules in the provider

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 10:39:56AM -0400, Stephen Gallagher wrote: > On Wed, 2012-07-18 at 13:24 +0200, Jakub Hrozek wrote: > > The IPA session code used to download all enabled SELinux rules, but > > then filter out those that match to the current user and save only > > those. This meant that if a

Re: [SSSD] [PATCH] IPA: Return and save all SELinux rules in the provider

2012-07-18 Thread Stephen Gallagher
On Wed, 2012-07-18 at 13:24 +0200, Jakub Hrozek wrote: > The IPA session code used to download all enabled SELinux rules, but > then filter out those that match to the current user and save only > those. This meant that if a rule was deleted or disabled on the server, > it remained in the cache and

Re: [SSSD] [PATCHES] Modify priority evaluation in SELinux user maps

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 12:33:14PM +0200, Jakub Hrozek wrote: > On Wed, Jul 18, 2012 at 12:19:00PM +0200, Jan Zelený wrote: > > Ack Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo

Re: [SSSD] [PATCHES] Add support for multiple servers in the Kerberos locator plugin

2012-07-18 Thread Simo Sorce
On Wed, 2012-07-18 at 08:05 -0400, Stephen Gallagher wrote: > On Tue, 2012-07-17 at 17:46 -0400, Simo Sorce wrote: > > On Tue, 2012-07-17 at 13:36 -0400, Stephen Gallagher wrote: > > > This is the first half of the work necessary to resolve > > > https://fedorahosted.org/sssd/ticket/941 > > > > >

Re: [SSSD] [PATCHES] Add support for multiple servers in the Kerberos locator plugin

2012-07-18 Thread Stephen Gallagher
On Tue, 2012-07-17 at 17:46 -0400, Simo Sorce wrote: > On Tue, 2012-07-17 at 13:36 -0400, Stephen Gallagher wrote: > > This is the first half of the work necessary to resolve > > https://fedorahosted.org/sssd/ticket/941 > > > > This patch largely rewrites the Kerberos locator plugin so that it can

[SSSD] [PATCH] IPA: Return and save all SELinux rules in the provider

2012-07-18 Thread Jakub Hrozek
The IPA session code used to download all enabled SELinux rules, but then filter out those that match to the current user and save only those. This meant that if a rule was deleted or disabled on the server, it remained in the cache and was still evaluated. The attached patch changes that behaviou

Re: [SSSD] [PATCH] LDAP: Properly cast type for MINSSF value

2012-07-18 Thread Jakub Hrozek
On Tue, Jul 17, 2012 at 10:14:54PM +0200, Jakub Hrozek wrote: > On Mon, Jul 16, 2012 at 09:13:20AM -0400, Stephen Gallagher wrote: > > This patch was submitted by Jan Vcelak through Bugzilla > > https://bugzilla.redhat.com/show_bug.cgi?id=825837 > > > > Fixes https://fedorahosted.org/sssd/ticket/1

Re: [SSSD] [PATCH] Fixed: Unchecked return value from dp_opt_set_int.

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 01:02:22PM +0200, Jakub Hrozek wrote: > On Thu, Jul 19, 2012 at 12:18:03PM +0200, Michal Zidek wrote: > > Fixed unchecked return value from function dp_opt_set_int in file > > src/tests/krb5_child-test.c. > > Ack > > Welcome aboard! Pushed to master. _

Re: [SSSD] [PATCH] Fixed: Uninitialized value in krb5_child-test if ccname was specified.

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 01:02:42PM +0200, Jakub Hrozek wrote: > On Thu, Jul 19, 2012 at 12:44:22PM +0200, Michal Zidek wrote: > > Variable private was used initialized when ccname was specified. The > > value now defaults to false. > > Ack Pushed to master

Re: [SSSD] [PATCH] Fixed: Uninitialized value in krb5_child-test if ccname was specified.

2012-07-18 Thread Jakub Hrozek
On Thu, Jul 19, 2012 at 12:44:22PM +0200, Michal Zidek wrote: > Variable private was used initialized when ccname was specified. The > value now defaults to false. Ack ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org

Re: [SSSD] [PATCH] Fixed: Unchecked return value from dp_opt_set_int.

2012-07-18 Thread Jakub Hrozek
On Thu, Jul 19, 2012 at 12:18:03PM +0200, Michal Zidek wrote: > Fixed unchecked return value from function dp_opt_set_int in file > src/tests/krb5_child-test.c. Ack Welcome aboard! ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fe

Re: [SSSD] [PATCH]Fix uninitialized values

2012-07-18 Thread Pavel Březina
On 07/17/2012 11:21 PM, Nick Guay wrote: On 17/07/12 16:09, Jakub Hrozek wrote: On Mon, Jul 16, 2012 at 04:41:22PM -0400, Nick Guay wrote: Patch for uninitialized values when building with -Wmaybe-uninitialized. Hi Nick, the patch fixes most of the warnings, but I still saw a couple: src/db

[SSSD] [PATCH] Fixed: Uninitialized value in krb5_child-test if ccname was specified.

2012-07-18 Thread Michal Zidek
Variable private was used initialized when ccname was specified. The value now defaults to false. >From 2ba229815ab8293cf7ef2f14ac22cfc8de2e0bbf Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Thu, 19 Jul 2012 12:28:13 +0200 Subject: [PATCH] Fixed: Uninitialized value in krb5_child-test if ccna

Re: [SSSD] [PATCHES] Modify priority evaluation in SELinux user maps

2012-07-18 Thread Jakub Hrozek
On Wed, Jul 18, 2012 at 12:19:00PM +0200, Jan Zelený wrote: Ack ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] Modify priority evaluation in SELinux user maps

2012-07-18 Thread Jan Zelený
Dne úterý 17 července 2012 16:27:40, Jakub Hrozek napsal(a): > On Tue, Jul 17, 2012 at 04:07:27PM +0200, Jan Zelený wrote: > > Dne úterý 17 července 2012 15:53:48, Jakub Hrozek napsal(a): > > > On Tue, Jul 17, 2012 at 09:14:14AM +0200, Jan Zelený wrote: > > > > Dne pondělí 16 července 2012 17:45:05

[SSSD] [PATCH] Fixed: Unchecked return value from dp_opt_set_int.

2012-07-18 Thread Michal Zidek
Fixed unchecked return value from function dp_opt_set_int in file src/tests/krb5_child-test.c. >From a10a4378727d153f6cea3db33d5dbe5f4624b67e Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Thu, 19 Jul 2012 11:52:13 +0200 Subject: [PATCH] Fixed: Unchecked return value from dp_opt_set_int. ---