On Wed, Aug 08, 2012 at 09:24:50AM -0400, Simo Sorce wrote:
> Ack from me, however if you do not like the if statement inside the loop
> you can also change it to be:
>
> while (true) {
> status =
> if (status != NSS_STATUS_TRYAGAIN) {
> break;
> }
>
> }
>
Ondrej, please let me know wh
On Wed, 2012-08-08 at 16:24 +0200, Jakub Hrozek wrote:
> On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote:
> > This bug was probably introduced with the subdomain patches. The
> > problem was that sss_dp_get_domains_send() is called even for the local
> > provider. There are certainly
On Wed, Aug 08, 2012 at 07:40:11AM -0400, Stephen Gallagher wrote:
> On Wed, 2012-08-08 at 11:08 +0200, Jakub Hrozek wrote:
> > The attached patch fixes a rather embarrassing memory leak in
> > create_ccache_dir_head.
>
> Ack
Pushed to master.
___
sssd-
On Wed, Aug 08, 2012 at 01:26:59PM +0200, Jakub Hrozek wrote:
> On Wed, Aug 08, 2012 at 01:18:52PM +0200, Ondrej Kos wrote:
> > On 08/08/2012 01:09 PM, Ondrej Kos wrote:
> > >https://fedorahosted.org/sssd/ticket/1461
> > forgot to mail the patch..
>
> Ack
>
Pushed to master.
On Wed, Aug 08, 2012 at 04:24:47PM +0200, Jakub Hrozek wrote:
> 2) The work we'll be doing later on #1126 would merge all the loops
> into one common place.
There is a WIP code for the merge in the "refactor" branch in my
fedorapeople.org repository. I started working on it earlier and the
On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote:
> This bug was probably introduced with the subdomain patches. The
> problem was that sss_dp_get_domains_send() is called even for the local
> provider. There are certainly many possible solutions of this issue. I
> decided to modify ss
On 08/03/2012 08:28 AM, Jan Zelený wrote:
> Dne pátek 20 července 2012 16:36:57, Dmitri Pal napsal(a):
>> Hello,
>>
>> Here is a bunch of patches for review:
> Hi,
> it took me a while but I finally finished the review.
>
>> Patch 1:
>> The unit test was not correct. The paths to files used in the
Ack from me, however if you do not like the if statement inside the loop
you can also change it to be:
while (true) {
status =
if (status != NSS_STATUS_TRYAGAIN) {
break;
}
}
Also looking at this loop I see a potential for infinite loop in case
something goes wrong and the internal call
This bug was probably introduced with the subdomain patches. The
problem was that sss_dp_get_domains_send() is called even for the local
provider. There are certainly many possible solutions of this issue. I
decided to modify sss_dp_issue_request() to call the callback
immediately if it is issued
On 08/08/2012 01:53 PM, Simo Sorce wrote:
On Wed, 2012-08-08 at 08:56 +0200, Ondrej Kos wrote:
Strange, I've created the patch with this alias, so patience flag should
be on
alias gfp='git format-patch -M -C --patience --full-index'
As for the while -> do-while, if I'd do that, then it would ne
On Wed, Aug 08, 2012 at 07:40:53AM -0400, Stephen Gallagher wrote:
> On Wed, 2012-08-08 at 13:26 +0200, Jakub Hrozek wrote:
> > On Wed, Aug 08, 2012 at 01:18:52PM +0200, Ondrej Kos wrote:
> > > On 08/08/2012 01:09 PM, Ondrej Kos wrote:
> > > >https://fedorahosted.org/sssd/ticket/1461
> > > forgot t
On Wed, 2012-08-08 at 08:56 +0200, Ondrej Kos wrote:
> Strange, I've created the patch with this alias, so patience flag should
> be on
> alias gfp='git format-patch -M -C --patience --full-index'
>
> As for the while -> do-while, if I'd do that, then it would need another
> condition
> if (stat
On Wed, 2012-08-08 at 13:26 +0200, Jakub Hrozek wrote:
> On Wed, Aug 08, 2012 at 01:18:52PM +0200, Ondrej Kos wrote:
> > On 08/08/2012 01:09 PM, Ondrej Kos wrote:
> > >https://fedorahosted.org/sssd/ticket/1461
> > forgot to mail the patch..
>
> Ack
>
> For some reason, the man pages that include
On Wed, 2012-08-08 at 11:08 +0200, Jakub Hrozek wrote:
> The attached patch fixes a rather embarrassing memory leak in
> create_ccache_dir_head.
Ack
signature.asc
Description: This is a digitally signed message part
___
sssd-devel mailing list
sssd-dev
On Wed, Aug 08, 2012 at 01:18:52PM +0200, Ondrej Kos wrote:
> On 08/08/2012 01:09 PM, Ondrej Kos wrote:
> >https://fedorahosted.org/sssd/ticket/1461
> forgot to mail the patch..
Ack
For some reason, the man pages that include this ldap_id_mapping.xml
stub do not get rebuild when the included file
On 08/08/2012 01:09 PM, Ondrej Kos wrote:
https://fedorahosted.org/sssd/ticket/1461
forgot to mail the patch..
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
cell: +420-736-417-909
phone: +420-532-294-558
ext.: 82-62558
irc: okos @ #brno
>From 7fa813c9a31ca1dcb
https://fedorahosted.org/sssd/ticket/1461
--
Ondrej Kos
Associate Software Engineer
Identity Management
Red Hat Czech
cell: +420-736-417-909
phone: +420-532-294-558
ext.: 82-62558
irc: okos @ #brno
___
sssd-devel mailing list
sssd-devel@lists.fedora
The attached patch fixes a rather embarrassing memory leak in
create_ccache_dir_head.
>From 0139f97af6fee3f53233a78806ddb0b1cf97273a Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Mon, 6 Aug 2012 21:33:35 +0200
Subject: [PATCH] Allocate on top of a talloc context, not NULL
---
src/providers/k
Collapsing servers previsouly expanded from a SRV query leads to a small
window where we use memory that was already freed.
I originally suspected this was the cause for the failover crash we've
been seeing lately, but I was wrong. I'll keep looking.
>From e4f52f9b24126ce93b54e35d84bf3b6769e6dce4
+FMT fix
On 08/08/2012 10:53 AM, Jakub Hrozek wrote:
On Wed, Aug 08, 2012 at 08:56:59AM +0200, Ondrej Kos wrote:
Strange, I've created the patch with this alias, so patience flag
should be on
alias gfp='git format-patch -M -C --patience --full-index'
As for the while -> do-while, if I'd do tha
On Wed, Aug 08, 2012 at 08:56:59AM +0200, Ondrej Kos wrote:
> Strange, I've created the patch with this alias, so patience flag
> should be on
> alias gfp='git format-patch -M -C --patience --full-index'
>
> As for the while -> do-while, if I'd do that, then it would need
> another condition
> if
On Wed, Aug 08, 2012 at 10:03:35AM +0200, Ondrej Kos wrote:
> On 08/08/2012 09:52 AM, Pavel Březina wrote:
> >I found another debug message without eol during my work.
> >
> >
> >___
> >sssd-devel mailing list
> >sssd-devel@lists.fedorahosted.org
> >https
On 08/08/2012 09:52 AM, Pavel Březina wrote:
I found another debug message without eol during my work.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Ack
--
Ondrej Kos
Associ
I found another debug message without eol during my work.
From dfdc7c04d30921e3c7bae3001e991678960da27b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Wed, 8 Aug 2012 09:51:42 +0200
Subject: [PATCH] Add end of line to debug message
---
src/responder/common/responder_dp.c
24 matches
Mail list logo
