Re: [SSSD] [PATCH] SYSDB: NULL-terminate the output of sysdb_get_{ranges, subdomains}

2012-09-10 Thread Pavel Březina
On 09/09/2012 09:31 PM, Jakub Hrozek wrote: I noticed (using valgrind) that the sysdb tests access memory outside the array allocated as a result of the functions in subject. The attached patch NULL-terminates the array so that it's safe to loop over the results. Nack. Just a nitpick :-) -

Re: [SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password

2012-09-10 Thread Ondrej Kos
On 09/09/2012 04:25 PM, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1515 The patch fixes handling of wrong password during both auth and chpass, in the chpass case, the return value was fixed in general. ___ sssd-devel mailing list

Re: [SSSD] [PATCH] KRB5: cancel the sysdb transaction on one place only

2012-09-10 Thread Pavel Březina
On 09/09/2012 09:53 PM, Jakub Hrozek wrote: Found by Coverity. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCHES] backend: initialize sudo only when it is enabled in services

2012-09-10 Thread Pavel Březina
On 09/07/2012 11:31 AM, Sumit Bose wrote: On Wed, Sep 05, 2012 at 03:05:49PM +0200, Pavel Březina wrote: 0001 fixes https://fedorahosted.org/sssd/ticket/1458 0002 fixes a memory leak when be_process_init() fails. I think it should be fixed, even though the backend is in this case immediately

Re: [SSSD] [PATCH] SYSDB: NULL-terminate the output of sysdb_get_{ranges, subdomains}

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 09:19:49AM +0200, Pavel Březina wrote: On 09/09/2012 09:31 PM, Jakub Hrozek wrote: I noticed (using valgrind) that the sysdb tests access memory outside the array allocated as a result of the functions in subject. The attached patch NULL-terminates the array so that

Re: [SSSD] [PATCH] SYSDB: NULL-terminate the output of sysdb_get_{ranges, subdomains}

2012-09-10 Thread Pavel Březina
On 09/10/2012 10:22 AM, Jakub Hrozek wrote: On Mon, Sep 10, 2012 at 09:19:49AM +0200, Pavel Březina wrote: On 09/09/2012 09:31 PM, Jakub Hrozek wrote: I noticed (using valgrind) that the sysdb tests access memory outside the array allocated as a result of the functions in subject. The attached

Re: [SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 09:22:21AM +0200, Ondrej Kos wrote: On 09/09/2012 04:25 PM, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1515 The patch fixes handling of wrong password during both auth and chpass, in the chpass case, the return value was fixed in general.

Re: [SSSD] [PATCH] KRB5: cancel the sysdb transaction on one place only

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 09:22:25AM +0200, Pavel Březina wrote: On 09/09/2012 09:53 PM, Jakub Hrozek wrote: Found by Coverity. Ack. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] RPM: BuildRequire selinux-policy-targeted

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 09:39:30AM +0200, Ondrej Kos wrote: On 09/07/2012 06:29 PM, Jakub Hrozek wrote: We check the presence of the directory /etc/selinux/targeted/logins to determine if the platform supports per-user SELinux logins. However, I forgot to BuildRequire that directory, so RPMs

Re: [SSSD] [PATCH] SYSDB: NULL-terminate the output of sysdb_get_{ranges, subdomains}

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 10:26:57AM +0200, Pavel Březina wrote: On 09/10/2012 10:22 AM, Jakub Hrozek wrote: On Mon, Sep 10, 2012 at 09:19:49AM +0200, Pavel Březina wrote: On 09/09/2012 09:31 PM, Jakub Hrozek wrote: I noticed (using valgrind) that the sysdb tests access memory outside the array

Re: [SSSD] [PATCH] RPM: BuildRequire selinux-policy-targeted

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 10:31:44AM +0200, Jakub Hrozek wrote: On Mon, Sep 10, 2012 at 09:39:30AM +0200, Ondrej Kos wrote: On 09/07/2012 06:29 PM, Jakub Hrozek wrote: We check the presence of the directory /etc/selinux/targeted/logins to determine if the platform supports per-user SELinux

Re: [SSSD] [PATCHES] backend: initialize sudo only when it is enabled in services

2012-09-10 Thread Sumit Bose
On Mon, Sep 10, 2012 at 09:35:25AM +0200, Pavel Březina wrote: On 09/07/2012 11:31 AM, Sumit Bose wrote: On Wed, Sep 05, 2012 at 03:05:49PM +0200, Pavel Březina wrote: 0001 fixes https://fedorahosted.org/sssd/ticket/1458 0002 fixes a memory leak when be_process_init() fails. I think it should

Re: [SSSD] [PATCHES] backend: initialize sudo only when it is enabled in services

2012-09-10 Thread Pavel Březina
On 09/10/2012 10:48 AM, Sumit Bose wrote: On Mon, Sep 10, 2012 at 09:35:25AM +0200, Pavel Březina wrote: On 09/07/2012 11:31 AM, Sumit Bose wrote: On Wed, Sep 05, 2012 at 03:05:49PM +0200, Pavel Březina wrote: 0001 fixes https://fedorahosted.org/sssd/ticket/1458 0002 fixes a memory leak when

[SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password

2012-09-10 Thread Jakub Hrozek
This is a backport of a fix for https://fedorahosted.org/sssd/ticket/1515 to the 1-8 branch. From 79a19271200823506963f5300517d0ecf4202c8b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Sun, 9 Sep 2012 08:56:13 -0400 Subject: [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect

[SSSD] [PATCH] tools_util.h provides signal_sssd function.

2012-09-10 Thread Michal Židek
I was looking for some reusable code and found static function send_sighup in sss_debuglevel.c. This function can be useful in other tools as well, so I renamed it to signal_sssd, added signum parameter and put it to tools_util.c/h. It can be used to send any signal to sssd monitor. Patch is in

Re: [SSSD] [PATCH] tools_util.h provides signal_sssd function.

2012-09-10 Thread Jakub Hrozek
On Mon, Sep 10, 2012 at 07:00:17PM +0200, Michal Židek wrote: I was looking for some reusable code and found static function send_sighup in sss_debuglevel.c. This function can be useful in other tools as well, so I renamed it to signal_sssd, added signum parameter and put it to tools_util.c/h.

Re: [SSSD] [PATCH] 1371-Missing resolv.conf should be non-fatal

2012-09-10 Thread Ariel Barria
thanks to both for comments. Date: Fri, 7 Sep 2012 14:02:39 +0200 From: jhro...@redhat.com To: sssd-devel@lists.fedorahosted.org Subject: Re: [SSSD] [PATCH] 1371-Missing resolv.conf should be non-fatal On Fri, Sep 07, 2012 at 12:41:30PM +0200, Michal Židek wrote: On 09/07/2012 05:53 AM,