[SSSD] [PATCH] Make subdomain discovery less noisy

2012-09-20 Thread Sumit Bose
Hi, this patch fixes https://fedorahosted.org/sssd/ticket/1517 by increasing some of the debug levels and print a log messages about the actual request only if the subdomain provider is configured. bye, Sumit From 72de4771f26192cb1fa616280efc347d0f48e347 Mon Sep 17 00:00:00 2001 From: Sumit Bose

Re: [SSSD] [PATCH] SSSD fails to store users if any of the requested attribute is empty.

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 02:27:03PM +0200, Michal Židek wrote: > https://fedorahosted.org/sssd/ticket/1440 > > Looks like some LDAP servers are able to store empty attribute > values. For some servers it results in syntax error, so it is > probably a rare case (if not an error) to have such values.

Re: [SSSD] [PATCH] Add more debuginfo into ldap_child

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 10:52:06AM +0200, Ondrej Kos wrote: > fixes https://fedorahosted.org/sssd/ticket/1225 , krb5_child already > updated before. Adding more debuginfo into ldap_child. Also old debug > levels rewritten into new macros. > > Patch is attached Ack

Re: [SSSD] [PATCHES] sss_cache tool invalidates records in memory cache

2012-09-20 Thread Jakub Hrozek
On Tue, Sep 18, 2012 at 01:26:20PM +0200, Michal Židek wrote: > On 09/17/2012 06:02 PM, Simo Sorce wrote: > > > >Hi Michal, > >you bring up a good point about the race with startup, but I am not > >totally convinced about the approach you used to address it. > > > >The race you point out could be e

Re: [SSSD] [PATCH] Add provider specific default regular expressions

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 11:07:43AM +0200, Sumit Bose wrote: > On Thu, Sep 20, 2012 at 10:19:38AM +0200, Pavel Březina wrote: > > On 09/19/2012 09:49 PM, Sumit Bose wrote: > > >Hi, > > > > > >this patch add specific default values for the regular expression to > > >split user names for the AD and IP

Re: [SSSD] [PATCH] DB: Cancel transaction in sysdb_store_user if sysdb_add_user fails

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 01:05:03PM +0200, Pavel Březina wrote: > On 09/20/2012 12:56 PM, Jakub Hrozek wrote: > >I found this while working on #1440 with Michal. > > Ack. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org htt

[SSSD] [PATCHES] Performance enhancements for AD provider

2012-09-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 * [PATCH 1/2] AD: Detect domain controller compatibility version This patch allows us to read the domain controller version from the RootDSE, if it exists. This will be used by the next patch to determine if the SSSD can use tokenGroups for lookups. *

[SSSD] [PATCH] SSSD fails to store users if any of the requested attribute is empty.

2012-09-20 Thread Michal Židek
https://fedorahosted.org/sssd/ticket/1440 Looks like some LDAP servers are able to store empty attribute values. For some servers it results in syntax error, so it is probably a rare case (if not an error) to have such values. LDB seems to be unable to handle such values too, so in this patch

Re: [SSSD] [PATCH] DB: Cancel transaction in sysdb_store_user if sysdb_add_user fails

2012-09-20 Thread Pavel Březina
On 09/20/2012 12:56 PM, Jakub Hrozek wrote: I found this while working on #1440 with Michal. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] DB: Cancel transaction in sysdb_store_user if sysdb_add_user fails

2012-09-20 Thread Jakub Hrozek
I found this while working on #1440 with Michal. >From fe247234065fb30c84b97df3b42c1d8245e78b19 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 19 Sep 2012 16:02:00 +0200 Subject: [PATCH] DB: Cancel transaction in sysdb_store_user if sysdb_add_user fails --- src/db/sysdb_ops.c | 9 ++

Re: [SSSD] [PATCH] pam: close fd when command is finished

2012-09-20 Thread Jakub Hrozek
On Tue, Sep 18, 2012 at 02:50:43PM +0200, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1361 Nack, this broke authentication for me, I'm getting a Broken Pipe error.. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lis

Re: [SSSD] [PATCH] Add provider specific default regular expressions

2012-09-20 Thread Sumit Bose
On Thu, Sep 20, 2012 at 10:19:38AM +0200, Pavel Březina wrote: > On 09/19/2012 09:49 PM, Sumit Bose wrote: > >Hi, > > > >this patch add specific default values for the regular expression to > >split user names for the AD and IPA provider. In a perfect patch the > >ID provider itself would report ba

[SSSD] [PATCH] Add more debuginfo into ldap_child

2012-09-20 Thread Ondrej Kos
fixes https://fedorahosted.org/sssd/ticket/1225 , krb5_child already updated before. Adding more debuginfo into ldap_child. Also old debug levels rewritten into new macros. Patch is attached O. -- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech cell: +420-736-417-909 p

Re: [SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password (1.8 backport)

2012-09-20 Thread Pavel Březina
On 09/20/2012 10:32 AM, Jakub Hrozek wrote: On Thu, Sep 20, 2012 at 10:30:24AM +0200, Jakub Hrozek wrote: Thanks, a new patch is attached. Umm, now it is. Sorry. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedo

Re: [SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password (1.8 backport)

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 10:30:24AM +0200, Jakub Hrozek wrote: > Thanks, a new patch is attached. Umm, now it is. Sorry. >From d646ddaeb20992ba94471d04ad21aa1a167e6318 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Sun, 9 Sep 2012 08:56:13 -0400 Subject: [PATCH] KRB5: Return PAM_AUTH_ERR on inc

Re: [SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password (1.8 backport)

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 10:04:02AM +0200, Pavel Březina wrote: > On 09/17/2012 08:29 PM, Jakub Hrozek wrote: > >On Fri, Sep 14, 2012 at 05:34:17PM +0200, Joschi Brauchle wrote: > >>>Hallo Jakub, > >>> > >>>I have tested the latest patch successfully. > >>> > >>>Please note that in the 2nd hunk, > >

Re: [SSSD] [PATCH] Add provider specific default regular expressions

2012-09-20 Thread Pavel Březina
On 09/19/2012 09:49 PM, Sumit Bose wrote: Hi, this patch add specific default values for the regular expression to split user names for the AD and IPA provider. In a perfect patch the ID provider itself would report back what he would like to use as a regular expression, but all solutions I coul

Re: [SSSD] [PATCH] SSH: Fix possible infinite loop when updating known_hosts

2012-09-20 Thread Jakub Hrozek
On Wed, Sep 19, 2012 at 01:58:05PM +0200, Jakub Hrozek wrote: > On Wed, Sep 19, 2012 at 11:55:30AM +0200, Jan Cholasta wrote: > > Hi, > > > > this patch fixes an infinite loop in ssh_host_pubkeys_update_known_hosts. > > > > Ack Pushed to master. ___ s

Re: [SSSD] [PATCH] 1371-Missing resolv.conf should be non-fatal

2012-09-20 Thread Jakub Hrozek
On Wed, Sep 19, 2012 at 04:12:52PM +0200, Jakub Hrozek wrote: > On Mon, Sep 17, 2012 at 09:39:28PM -0500, Ariel Barria wrote: > > > > it's true, simplifies quite a bit. thanks :)> Hi, > > > > > please consider squashing in the attached patch. I think it simplifies > > > the logic some more and

Re: [SSSD] [PATCH] LDB_ERR_INVALID_ATTRIBUTE_SYNTAX added to, sysdb_error_to_errno.

2012-09-20 Thread Jakub Hrozek
On Wed, Sep 19, 2012 at 05:56:35PM +0200, Jakub Hrozek wrote: > On Wed, Sep 19, 2012 at 05:42:35PM +0200, Michal Židek wrote: > > If the LDB_ERR_* code is not recognized by sysdb_error_to_errno > > function, it returns EFAULT by default. This caused confusion in the > > case when SSSD tried to stor

Re: [SSSD] KRB5 child: Don't return System Error on empty password

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 09:42:49AM +0200, Ondrej Kos wrote: > On 09/19/2012 10:35 AM, Jakub Hrozek wrote: > >https://fedorahosted.org/sssd/ticket/1310 > > > > > > > >___ > >sssd-devel mailing list > >sssd-devel@lists.fedorahosted.org > >https://lists.fedo

Re: [SSSD] [PATCH] KRB5 child: handle more error codes gracefully

2012-09-20 Thread Jakub Hrozek
On Thu, Sep 20, 2012 at 10:09:04AM +0200, Pavel Březina wrote: > On 09/19/2012 12:56 PM, Jakub Hrozek wrote: > >This patch changes handling of krb5 child error codes so that it's on par > >with the 1.8 branch after Joschi Brauchle reviewed the 1.8 backport. > > Ack. Pushed to master.

Re: [SSSD] [PATCH] KRB5 child: handle more error codes gracefully

2012-09-20 Thread Pavel Březina
On 09/19/2012 12:56 PM, Jakub Hrozek wrote: This patch changes handling of krb5 child error codes so that it's on par with the 1.8 branch after Joschi Brauchle reviewed the 1.8 backport. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.o

Re: [SSSD] [PATCH] KRB5: Return PAM_AUTH_ERR on incorrect password (1.8 backport)

2012-09-20 Thread Pavel Březina
On 09/17/2012 08:29 PM, Jakub Hrozek wrote: On Fri, Sep 14, 2012 at 05:34:17PM +0200, Joschi Brauchle wrote: >Hallo Jakub, > >I have tested the latest patch successfully. > >Please note that in the 2nd hunk, >1) the line with "KRB5_DEBUG(1, kerr);" should also be removed to >avoid duplicate debu

Re: [SSSD] KRB5 child: Don't return System Error on empty password

2012-09-20 Thread Ondrej Kos
On 09/19/2012 10:35 AM, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1310 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Ack O. -- Ondrej Kos Associate Softwar

Re: [SSSD] [PATCHES] SSH: Expire hosts in known_hosts

2012-09-20 Thread Jan Cholasta
Hi, Dne 19.9.2012 20:01, Stephen Gallagher napsal(a): -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 19 Sep 2012 06:09:59 AM EDT, Jan Cholasta wrote: Hi, this patch set changes the way the known_hosts file is updated so that only entries for hosts that were requested recently (in the la