Re: [SSSD] [PATCHES] change responder contexts hierarchy

2012-10-30 Thread Jakub Hrozek
On Tue, Oct 30, 2012 at 03:24:43PM +0100, Jakub Hrozek wrote: > On Fri, Oct 19, 2012 at 12:27:44PM +0200, Pavel Březina wrote: > > 0001: do not leak memory on failure in *_process_init() > > > > 0002: https://fedorahosted.org/sssd/ticket/1575 > > > > 0003: free request table as the first thing wh

Re: [SSSD] Unexpected behavior with 'simple_allow_users ='

2012-10-30 Thread Ondrej Kos
On 10/17/2012 03:28 PM, Michal Židek wrote: On 10/16/2012 03:45 PM, Stef Walter wrote: On 10/16/2012 02:04 PM, Jakub Hrozek wrote: I was wondering for a while whether to change the behaviour directly in confdb_get_string_as_list() but I think the attached patch takes a better approach because t

Re: [SSSD] [PATCH] authconfig: allow chpass_provider = proxy

2012-10-30 Thread Jakub Hrozek
On Tue, Oct 30, 2012 at 03:01:13PM +0100, Jakub Hrozek wrote: > On Tue, Oct 30, 2012 at 02:11:26PM +0100, Pavel Březina wrote: > > https://fedorahosted.org/sssd/ticket/1611 > > Ack. > > I will squash in the attached unit test amendment patch before pushing. > I will also change the commit message

Re: [SSSD] [PATCHES] change responder contexts hierarchy

2012-10-30 Thread Simo Sorce
On Tue, 2012-10-30 at 15:24 +0100, Jakub Hrozek wrote: > On Fri, Oct 19, 2012 at 12:27:44PM +0200, Pavel Březina wrote: > > 0001: do not leak memory on failure in *_process_init() > > > > 0002: https://fedorahosted.org/sssd/ticket/1575 > > > > 0003: free request table as the first thing when deal

Re: [SSSD] [PATCHES] change responder contexts hierarchy

2012-10-30 Thread Simo Sorce
On Fri, 2012-10-19 at 12:27 +0200, Pavel Březina wrote: > 0001: do not leak memory on failure in *_process_init() > > 0002: https://fedorahosted.org/sssd/ticket/1575 > > 0003: free request table as the first thing when deallocating rctx > Because we have changed the hierarchy we do not need to sp

Re: [SSSD] [PATCH] sudo: do not hardcode protocol version

2012-10-30 Thread Jakub Hrozek
On Tue, Oct 30, 2012 at 01:54:10PM +0100, Pavel Březina wrote: > Hi, > this was already discussed and the solution was > 04b3ab7658985af749460010123bbe37eccf50ed. > > On the client side it uses the same macro. If the protocol doesn't > match we return EFAULT, which terminates the connection. > >

Re: [SSSD] [PATCHES] change responder contexts hierarchy

2012-10-30 Thread Jakub Hrozek
On Fri, Oct 19, 2012 at 12:27:44PM +0200, Pavel Březina wrote: > 0001: do not leak memory on failure in *_process_init() > > 0002: https://fedorahosted.org/sssd/ticket/1575 > > 0003: free request table as the first thing when deallocating rctx > Because we have changed the hierarchy we do not nee

Re: [SSSD] [PATCH] authconfig: allow chpass_provider = proxy

2012-10-30 Thread Jakub Hrozek
On Tue, Oct 30, 2012 at 02:11:26PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1611 Ack. I will squash in the attached unit test amendment patch before pushing. I will also change the commit message as authconfig is an external program, it should really say something with c

Re: [SSSD] [PATCH] sss_cache: Remove fastcache even if sssd is not running.

2012-10-30 Thread Simo Sorce
On Tue, 2012-10-30 at 10:39 +0100, Michal Židek wrote: > On 10/29/2012 03:53 PM, Simo Sorce wrote: > > > > Codewise looks ok, but I still see duplication of the code used to lock > > the file. > > > > I was wondering, would it make sense to split this patch in 2 and put > > the lock_mc_file functio

[SSSD] [PATCH] authconfig: allow chpass_provider = proxy

2012-10-30 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/1611 From af5cca9e8ec5840dc8efdf57c94bf8c6e1ea0651 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 30 Oct 2012 14:00:21 +0100 Subject: [PATCH] authconfig: allow chpass_provider = proxy https://fedorahosted.org/sssd/ticket/1611 ---

Re: [SSSD] [PATCH] exit original process after sssd is initialized

2012-10-30 Thread Jakub Hrozek
On Fri, Oct 26, 2012 at 01:10:38PM +0200, Pavel Březina wrote: > On 10/22/2012 01:49 PM, Pavel Březina wrote: > >On 10/19/2012 02:20 PM, Simo Sorce wrote: > >>On Fri, 2012-10-19 at 09:52 +0200, Pavel Březina wrote: > >>>On 10/18/2012 08:43 PM, Stephen Gallagher wrote: > On 10/18/2012 09:50 AM,

Re: [SSSD] [PATCH] sudo: do not hardcode protocol version

2012-10-30 Thread Pavel Březina
On 10/30/2012 01:38 PM, Jakub Hrozek wrote: On Tue, Oct 30, 2012 at 01:27:50PM +0100, Pavel Březina wrote: From a6182a234b1bef9b9c4ab8fc6b925504c0135f69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 30 Oct 2012 12:03:19 +0100 Subject: [PATCH 1/2] sudo: do not hard

Re: [SSSD] [PATCH] sudo: do not hardcode protocol version

2012-10-30 Thread Jakub Hrozek
On Tue, Oct 30, 2012 at 01:27:50PM +0100, Pavel Březina wrote: > From a6182a234b1bef9b9c4ab8fc6b925504c0135f69 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Pavel=20B=C5=99ezina?= > Date: Tue, 30 Oct 2012 12:03:19 +0100 > Subject: [PATCH 1/2] sudo: do not hardcode protocol version > > --- > src/re

[SSSD] [PATCH] sudo: do not hardcode protocol version

2012-10-30 Thread Pavel Březina
From a6182a234b1bef9b9c4ab8fc6b925504c0135f69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 30 Oct 2012 12:03:19 +0100 Subject: [PATCH 1/2] sudo: do not hardcode protocol version --- src/responder/sudo/sudosrv_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

Re: [SSSD] [PATCH] do not default fullname to gecos when schema = ad

2012-10-30 Thread Pavel Březina
On 10/30/2012 11:11 AM, Sumit Bose wrote: On Fri, Oct 26, 2012 at 04:18:28PM +0200, Pavel Březina wrote: On 10/25/2012 12:27 PM, Sumit Bose wrote: On Thu, Oct 18, 2012 at 01:11:00PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1482 ... you add fullname to the user_attrs.

Re: [SSSD] [PATCH] do not default fullname to gecos when schema = ad

2012-10-30 Thread Sumit Bose
On Fri, Oct 26, 2012 at 04:18:28PM +0200, Pavel Březina wrote: > On 10/25/2012 12:27 PM, Sumit Bose wrote: > >On Thu, Oct 18, 2012 at 01:11:00PM +0200, Pavel Březina wrote: > >>https://fedorahosted.org/sssd/ticket/1482 > > > > > >... you add fullname to the user_attrs. Then sysdb_add_basic_user() w

Re: [SSSD] [PATCH] sss_cache: Remove fastcache even if sssd is not running.

2012-10-30 Thread Michal Židek
On 10/29/2012 03:53 PM, Simo Sorce wrote: Codewise looks ok, but I still see duplication of the code used to lock the file. I was wondering, would it make sense to split this patch in 2 and put the lock_mc_file functions as a more generic function in the common utils as a separate patch first ?