Re: [SSSD] [PATCH] TESTS: Test ghosts users in the RFC2307 schema

2012-11-26 Thread Jakub Hrozek
On Mon, Nov 26, 2012 at 04:01:03PM -0500, Simo Sorce wrote: > On Mon, 2012-11-26 at 21:26 +0100, Jakub Hrozek wrote: > > On Mon, Nov 26, 2012 at 09:52:13AM -0500, Simo Sorce wrote: > > > On Sun, 2012-11-25 at 23:53 +0100, Jakub Hrozek wrote: > > > > I'm implementing unit tests for the ghosts users

Re: [SSSD] [PATCH] MEMBEROF: Implement delete operation for ghost users

2012-11-26 Thread Jakub Hrozek
On Mon, Nov 26, 2012 at 12:00:44AM +0100, Jakub Hrozek wrote: > https://fedorahosted.org/sssd/ticket/1668 > > The memberof plugin did only expand the ghost users attribute to > parents when adding a nested group, but didn't implement the reverse > operation. > > This bug resulted in users being r

Re: [SSSD] [PATCH] TESTS: Test ghosts users in the RFC2307 schema

2012-11-26 Thread Simo Sorce
On Mon, 2012-11-26 at 21:26 +0100, Jakub Hrozek wrote: > On Mon, Nov 26, 2012 at 09:52:13AM -0500, Simo Sorce wrote: > > On Sun, 2012-11-25 at 23:53 +0100, Jakub Hrozek wrote: > > > I'm implementing unit tests for the ghosts users feature to make sure we > > > catch all the problems for the next up

Re: [SSSD] [PATCH] TESTS: Test ghosts users in the RFC2307 schema

2012-11-26 Thread Jakub Hrozek
On Mon, Nov 26, 2012 at 09:52:13AM -0500, Simo Sorce wrote: > On Sun, 2012-11-25 at 23:53 +0100, Jakub Hrozek wrote: > > I'm implementing unit tests for the ghosts users feature to make sure we > > catch all the problems for the next upstream release. Attached is a > > patch with a couple of unit t

Re: [SSSD] [PATCH] MEMBEROF: Do not add the ghost attribute to self

2012-11-26 Thread Jakub Hrozek
On Mon, Nov 26, 2012 at 09:34:50AM -0500, Simo Sorce wrote: > On Sun, 2012-11-25 at 23:50 +0100, Jakub Hrozek wrote: > > I found this ghost users bug when working on #1652. > > > > When the ghost attribute is added, the memberof plugin attempts to add > > it to self, which is wrong. I think it's s

Re: [SSSD] [PATCH] debug: print fatal and critical errors if debug level is, unresolved

2012-11-26 Thread Jakub Hrozek
On Thu, Nov 22, 2012 at 06:17:31PM +0100, Jakub Hrozek wrote: > On Mon, Nov 19, 2012 at 03:13:12PM +0100, Michal Židek wrote: > > On 11/19/2012 02:38 PM, Simo Sorce wrote: > > >On Mon, 2012-11-19 at 14:13 +0100, Michal Židek wrote: > > >>SSSDBG_CRITICAL_FAILURE or SSSDBG_FATAL_FAILURE > > > > > >It

Re: [SSSD] [PATCH 1/5] Fix tevent_req style for krb5_auth

2012-11-26 Thread Simo Sorce
On Mon, 2012-11-26 at 18:21 +0100, Pavel Březina wrote: > On 11/24/2012 05:33 AM, Simo Sorce wrote: > > No functionality changes, > > just make the code respect the tevent_req style and naming conventions > > and enhance readability by adding some helper functions. > > --- > > Good job on refactor

Re: [SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

2012-11-26 Thread Simo Sorce
On Mon, 2012-11-26 at 17:52 +0100, Pavel Březina wrote: > On 11/26/2012 05:04 PM, Simo Sorce wrote: > > On Mon, 2012-11-26 at 16:51 +0100, Pavel Březina wrote: > >> On 11/14/2012 03:01 PM, Simo Sorce wrote: > >>> In some case we allocate and assign data to a const pointer. > >>> When we then try to

[SSSD] #570-fall back to defaults from krb5.conf if the realm is not specified explicitly in sssd.conf

2012-11-26 Thread Ariel Barria
Hi. Apologies, I have been working in ticket #570 and I send for your comments before the send a patch final. I was reviewing where else needs to change and I find this places 1 - krb5_auth.c ---> tevent_req *krb5_auth_send( 2 - krb5_utils.c ---> char *expand_ccname_template( 3 - ipa_dyndns.c ---

Re: [SSSD] [PATCH 1/5] Fix tevent_req style for krb5_auth

2012-11-26 Thread Pavel Březina
On 11/24/2012 05:33 AM, Simo Sorce wrote: No functionality changes, just make the code respect the tevent_req style and naming conventions and enhance readability by adding some helper functions. --- Good job on refactoring Simo. I have few comments inline. +static errno_t krb5_auth_prepare_c

Re: [SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

2012-11-26 Thread Pavel Březina
On 11/26/2012 05:04 PM, Simo Sorce wrote: On Mon, 2012-11-26 at 16:51 +0100, Pavel Březina wrote: On 11/14/2012 03:01 PM, Simo Sorce wrote: In some case we allocate and assign data to a const pointer. When we then try to free it we would get a const warning because talloc_free accepts a void, n

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel should invalidate mmap cache

2012-11-26 Thread Simo Sorce
On Thu, 2012-11-22 at 09:52 +0100, Michal Židek wrote: > On 11/21/2012 04:41 PM, Simo Sorce wrote: > > On Wed, 2012-11-21 at 15:56 +0100, Michal Židek wrote: > >> On 11/21/2012 02:31 PM, Simo Sorce wrote: > >>> On Tue, 2012-11-20 at 14:29 +0100, Michal Židek wrote: > On 11/20/2012 02:22 PM, Mi

Re: [SSSD] Fix compare_principal_realm() check broken make check ?

2012-11-26 Thread Simo Sorce
On Mon, 2012-11-26 at 16:56 +0100, Pavel Březina wrote: > On 11/22/2012 12:06 AM, Jakub Hrozek wrote: > > On Wed, Nov 21, 2012 at 05:24:02PM -0500, Simo Sorce wrote: > >> I am getting a make check error: > >> Running suite(s): krb5_utils > >> 93%: Checks: 16, Failures: 1, Errors: 0 > >> ../src/test

Re: [SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

2012-11-26 Thread Simo Sorce
On Mon, 2012-11-26 at 16:51 +0100, Pavel Březina wrote: > On 11/14/2012 03:01 PM, Simo Sorce wrote: > > In some case we allocate and assign data to a const pointer. > > When we then try to free it we would get a const warning because talloc_free > > accepts a void, not a const void pointer. Use dis

Re: [SSSD] Fix compare_principal_realm() check broken make check ?

2012-11-26 Thread Pavel Březina
On 11/22/2012 12:06 AM, Jakub Hrozek wrote: On Wed, Nov 21, 2012 at 05:24:02PM -0500, Simo Sorce wrote: I am getting a make check error: Running suite(s): krb5_utils 93%: Checks: 16, Failures: 1, Errors: 0 ../src/tests/krb5_utils-tests.c:704:F:Helper functions:test_compare_principal_realm:0: Sa

Re: [SSSD] [PATCH 3/3] Avoid const warnings when deallocating memory

2012-11-26 Thread Pavel Březina
On 11/14/2012 03:01 PM, Simo Sorce wrote: In some case we allocate and assign data to a const pointer. When we then try to free it we would get a const warning because talloc_free accepts a void, not a const void pointer. Use discard_const to avoid the warning, it is safe in this case. --- src/

Re: [SSSD] [PATCH 2/3] Avoid duplicating macros

2012-11-26 Thread Pavel Březina
On 11/14/2012 03:01 PM, Simo Sorce wrote: This macro is already available in util/util.h which is expicitly included in this file. --- src/ldb_modules/memberof.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/ldb_modules/memberof.c b/src/ldb_modules/memberof.c

Re: [SSSD] [PATCH 1/3] Revert "Avoid accessing half-deallocated memory when using talloc_zfree macro."

2012-11-26 Thread Pavel Březina
On 11/14/2012 03:01 PM, Simo Sorce wrote: This reverts commit ff57c6aeb80a52b1f52bd1dac9308a69dc7a4774. This commit doesn't really make sense, we are never accessing freed memory as all we are dealing with is a pointer which is never itsef part of the memory we are freeing (if it were, it would

Re: [SSSD] [PATCH] TESTS: Test ghosts users in the RFC2307 schema

2012-11-26 Thread Simo Sorce
On Sun, 2012-11-25 at 23:53 +0100, Jakub Hrozek wrote: > I'm implementing unit tests for the ghosts users feature to make sure we > catch all the problems for the next upstream release. Attached is a > patch with a couple of unit tests that simulate what the LDAP provider > would do when using the

Re: [SSSD] [PATCH] MEMBEROF: Do not add the ghost attribute to self

2012-11-26 Thread Simo Sorce
On Sun, 2012-11-25 at 23:50 +0100, Jakub Hrozek wrote: > I found this ghost users bug when working on #1652. > > When the ghost attribute is added, the memberof plugin attempts to add > it to self, which is wrong. I think it's simply a copy-n-paste error > from the similar memberuid operation. >

Re: [SSSD] [PATCH] failover: Protect against empty host names

2012-11-26 Thread Michal Židek
On 11/23/2012 10:11 AM, Pavel Březina wrote: On 10/17/2012 04:01 PM, Michal Židek wrote: On 10/16/2012 11:36 AM, Pavel Březina wrote: On 10/15/2012 12:30 PM, Michal Židek wrote: Added new parameter to split_on_separator that allows to skip empty values. https://fedorahosted.org/sssd/ticket/14

Re: [SSSD] [PATCH] idmap: Silence DEBUG messages when dealing with built-in, SIDs.

2012-11-26 Thread Michal Židek
On 11/22/2012 07:16 PM, Pavel Březina wrote: On 11/22/2012 06:47 PM, Jakub Hrozek wrote: On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote: On 11/22/2012 10:27 AM, Pavel Březina wrote: On 11/21/2012 03:00 PM, Michal Židek wrote: On 11/21/2012 11:04 AM, Jakub Hrozek wrote: On Tue,

Re: [SSSD] [PATCH] some defensive programming

2012-11-26 Thread Jakub Hrozek
On Fri, Nov 23, 2012 at 08:48:06PM -0500, Simo Sorce wrote: > On Fri, 2012-11-23 at 09:28 +0100, Pavel Březina wrote: > > On 11/22/2012 10:08 PM, Simo Sorce wrote: > > > See commit msg, just a minor defensive fix. > > > > Hi, > > can you change the debug level to SSSDBG macro please? > > Attached

Re: [SSSD] [PATCH] SYSDB: Don't operate with aliases same as name

2012-11-26 Thread Jakub Hrozek
On Fri, Nov 23, 2012 at 07:41:07PM +0100, Jakub Hrozek wrote: > > Thanks, I updated the code and also built the patch on the current > > master. attached. > > > > Ack Pushed to master and sssd-1-9 ___ sssd-devel mailing list sssd-devel@lists.fedorahost