On Tue, Nov 27, 2012 at 11:27:03PM -0500, Simo Sorce wrote:
> On Wed, 2011-08-10 at 15:29 +0200, Jan Zelený wrote:
> > > On Wed, Aug 10, 2011 at 10:14:14AM +0200, Jan Zelený wrote:
> > > > > This patch should not be pushed to master, but I would like to get it
> > > > > reviewed anyway.
> > > > >
No functionality changes,
just make the code respect the tevent_req style and naming conventions
and enhance readability by adding some helper functions.
---
src/providers/krb5/krb5_access.c |6 +-
src/providers/krb5/krb5_auth.c | 683 --
src/provider
---
src/providers/ipa/ipa_id.c|5 +-
src/providers/ipa/ipa_id.h| 10 ++--
src/providers/ipa/ipa_subdomains_id.c | 73 +
3 files changed, 36 insertions(+), 52 deletions(-)
diff --git a/src/providers/ipa/ipa_id.c b/src/providers/ipa/ip
In particular note that we merge ipa_account_info_netgroups_done()
and ipa_account_info_users_done() into a single fucntion called
ipa_account_info_done() that handles both cases
We also remove the auxiliary function ipa_account_info_complete() that
unnecessarily violates the tevent_req style and
This revision should address all concerns raised by Pavel for code that I
actually changed from the original. For patch 1 a calrification I can't
make was asked. I 'fixed' the code as I realized I copied a debug statement
wrapped in an if statement that wasn't in the original code I move around,
so
On Wed, 2011-08-10 at 15:29 +0200, Jan Zelený wrote:
> > On Wed, Aug 10, 2011 at 10:14:14AM +0200, Jan Zelený wrote:
> > > > This patch should not be pushed to master, but I would like to get it
> > > > reviewed anyway.
> > > >
> > > > It should be used to provide a custom build for users experien
Also do not intermix two tevent_req sequences
---
src/providers/ipa/ipa_id.c | 151 +---
1 files changed, 71 insertions(+), 80 deletions(-)
diff --git a/src/providers/ipa/ipa_id.c b/src/providers/ipa/ipa_id.c
index
58bb1c11608acd4a7b341c80623eb37df17dec77
Avoids hardcoding magic numbers everywhere and self documents why a
mask is being applied.
---
src/providers/data_provider.h |1 +
src/providers/ipa/ipa_id.c|4 ++--
src/providers/ipa/ipa_subdomains_id.c |2 +-
src/providers/ldap/ldap_id.c |2 +-
src/pr
On Tue, 2012-10-30 at 15:30 +0100, Jakub Hrozek wrote:
> On Tue, Oct 30, 2012 at 01:54:10PM +0100, Pavel Březina wrote:
> > Hi,
> > this was already discussed and the solution was
> > 04b3ab7658985af749460010123bbe37eccf50ed.
> >
> > On the client side it uses the same macro. If the protocol doesn
On Tue, 2012-11-27 at 12:34 +0100, Pavel Březina wrote:
> On 11/24/2012 05:33 AM, Simo Sorce wrote:
> > In particular note that we merge ipa_account_info_netgroups_done()
> > and ipa_account_info_users_done() into a single fucntion called
> > ipa_account_info_done() that handles both cases
> >
> >
On Tue, 2012-11-27 at 11:02 +0100, Michal Židek wrote:
> On 11/26/2012 05:43 PM, Simo Sorce wrote:
> > On Thu, 2012-11-22 at 09:52 +0100, Michal Židek wrote:
> >> On 11/21/2012 04:41 PM, Simo Sorce wrote:
> >>> On Wed, 2012-11-21 at 15:56 +0100, Michal Židek wrote:
> On 11/21/2012 02:31 PM, Si
https://fedorahosted.org/sssd/ticket/1625
Additional info:
the class of configuration error messages could be
changed to match the default debug level.Apparently this was covered with
#1345 and in server.c
if (debug_level == SSSDBG_UNRESOLVED) {
/* set debug level
In some situations, the c-ares lookup can return NULL instead of
a list of addresses. In this situation, we need to avoid
dereferencing NULL.
This patch adds a log message and sets the count to zero so it is
handled appropriately below.
This patch fixes the crash seen in
https://bugzilla.redhat
On 11/27/2012 05:57 PM, Simo Sorce wrote:
On Tue, 2012-11-27 at 11:49 -0500, Stephen Gallagher wrote:
On Tue 27 Nov 2012 09:33:00 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
Can you use "fail" pattern instead of calling the former each time
allocation fail
The first three patches are just refactoring. The last patch implements
the real modify operation along with a number of unit tests.
>From 71902d3eab67a14ba200908b7c708d3f661e4ed8 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Mon, 26 Nov 2012 13:18:59 +0100
Subject: [PATCH 1/4] MEMBEROF: split
On Tue, 2012-11-27 at 11:49 -0500, Stephen Gallagher wrote:
> On Tue 27 Nov 2012 09:33:00 AM EST, Simo Sorce wrote:
> > On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
> >> Can you use "fail" pattern instead of calling the former each time
> >> allocation fails?
> >>
> >> Otherwise it looks
On Mon, Nov 26, 2012 at 10:42:17PM +0100, Jakub Hrozek wrote:
> On Mon, Nov 26, 2012 at 12:00:44AM +0100, Jakub Hrozek wrote:
> > https://fedorahosted.org/sssd/ticket/1668
> >
> > The memberof plugin did only expand the ghost users attribute to
> > parents when adding a nested group, but didn't im
On Tue 27 Nov 2012 09:33:00 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
Can you use "fail" pattern instead of calling the former each time
allocation fails?
Otherwise it looks good. I like the function.
I would like to vouch for always using 'done:' as a
On 11/27/2012 05:42 PM, Stephen Gallagher wrote:
On Tue 27 Nov 2012 09:28:56 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 13:59 +0100, Michal Židek wrote:
On 11/27/2012 01:44 PM, Pavel Březina wrote:
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
An
On Tue 27 Nov 2012 09:28:56 AM EST, Simo Sorce wrote:
On Tue, 2012-11-27 at 13:59 +0100, Michal Židek wrote:
On 11/27/2012 01:44 PM, Pavel Březina wrote:
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes in
On Tue, 2012-11-27 at 15:18 +0100, Pavel Březina wrote:
> Can you use "fail" pattern instead of calling the former each time
> allocation fails?
>
> Otherwise it looks good. I like the function.
>
I would like to vouch for always using 'done:' as a label and not other
arbitrary words.
Whether it
On 11/27/2012 02:16 PM, Michal Židek wrote:
On 11/27/2012 01:34 PM, Pavel Březina wrote:
On 11/26/2012 03:18 PM, Michal Židek wrote:
On 11/22/2012 07:16 PM, Pavel Březina wrote:
On 11/22/2012 06:47 PM, Jakub Hrozek wrote:
On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote:
On 11/22
On Tue, 2012-11-27 at 13:59 +0100, Michal Židek wrote:
> On 11/27/2012 01:44 PM, Pavel Březina wrote:
> > On 11/27/2012 01:35 PM, Michal Židek wrote:
> >> https://fedorahosted.org/sssd/ticket/1674
> >>
> >>
> >> Another bug found by Coverity. This patch changes indentation in part of
> >> the code
On 11/26/2012 02:40 PM, Michal Židek wrote:
On 11/23/2012 10:11 AM, Pavel Březina wrote:
On 10/17/2012 04:01 PM, Michal Židek wrote:
On 10/16/2012 11:36 AM, Pavel Březina wrote:
On 10/15/2012 12:30 PM, Michal Židek wrote:
Added new parameter to split_on_separator that allows to skip
empty val
On 11/27/2012 01:34 PM, Pavel Březina wrote:
On 11/26/2012 03:18 PM, Michal Židek wrote:
On 11/22/2012 07:16 PM, Pavel Březina wrote:
On 11/22/2012 06:47 PM, Jakub Hrozek wrote:
On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote:
On 11/22/2012 10:27 AM, Pavel Březina wrote:
On 11/2
On 11/27/2012 01:44 PM, Pavel Březina wrote:
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes indentation in part of
the code (so it looks bigger than it actually is). I updated debug
messages in the changed
On 11/27/2012 01:35 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes indentation in part of
the code (so it looks bigger than it actually is). I updated debug
messages in the changed part with the new SSSDBG_* macros.
Patch is
https://fedorahosted.org/sssd/ticket/1674
Another bug found by Coverity. This patch changes indentation in part of
the code (so it looks bigger than it actually is). I updated debug
messages in the changed part with the new SSSDBG_* macros.
Patch is attached.
Thanks
Michal
>From 452b0133932
On 11/26/2012 03:18 PM, Michal Židek wrote:
On 11/22/2012 07:16 PM, Pavel Březina wrote:
On 11/22/2012 06:47 PM, Jakub Hrozek wrote:
On Thu, Nov 22, 2012 at 10:38:28AM +0100, Michal Židek wrote:
On 11/22/2012 10:27 AM, Pavel Březina wrote:
On 11/21/2012 03:00 PM, Michal Židek wrote:
On 11/21
On 11/27/2012 12:52 PM, Michal Židek wrote:
https://fedorahosted.org/sssd/ticket/1673
There was a typo in the code (s/res/dom_res) which could result in
segfault (found by Coverity).
Thanks
Michal
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fe
https://fedorahosted.org/sssd/ticket/1673
There was a typo in the code (s/res/dom_res) which could result in
segfault (found by Coverity).
Thanks
Michal
>From 8cd6cafcca5282de095e305c4e8ea060dc679854 Mon Sep 17 00:00:00 2001
From: Michal Zidek
Date: Tue, 27 Nov 2012 12:36:40 +0100
Subject: [P
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On 11/24/2012 05:33 AM, Simo Sorce wrote:
In particular note that we merge ipa_account_info_netgroups_done()
and ipa_account_info_users_done() into a single fucntion called
ipa_account_info_done() that handles both cases
We also remove the auxiliary function ipa_account_info_complete() that
unne
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On 11/26/2012 05:43 PM, Simo Sorce wrote:
On Thu, 2012-11-22 at 09:52 +0100, Michal Židek wrote:
On 11/21/2012 04:41 PM, Simo Sorce wrote:
On Wed, 2012-11-21 at 15:56 +0100, Michal Židek wrote:
On 11/21/2012 02:31 PM, Simo Sorce wrote:
On Tue, 2012-11-20 at 14:29 +0100, Michal Židek wrote:
O
On Mon, Nov 26, 2012 at 05:52:53PM +0100, Pavel Březina wrote:
> In general, I think freeing const variable means that something is
> wrong with design, although I found myself in this situation once or
> twice (in other projects).
I don't think this is necessarily true; we often use a construct s
37 matches
Mail list logo
