Re: [SSSD] nss hosts and caching

2012-11-29 Thread James Hogarth
> > No, hosts are not supported. > > Currently the SSSD supports (and caches) these maps: > * passwd (aka users) > * groups > * netgroups > * services > Confirms what I thought thanks Jacob ___ sssd-devel mailing list sssd-devel@lists.fed

Re: [SSSD] [PATCH] Missing parameter in DEBUG message.

2012-11-29 Thread Jakub Hrozek
On Thu, Nov 29, 2012 at 06:49:48PM +0100, Michal Židek wrote: > We were printing some garbage value in this message. > > Patch attached. > > Thanks > Michal Ack Mea culpa.. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fe

[SSSD] [PATCH] Missing parameter in DEBUG message.

2012-11-29 Thread Michal Židek
We were printing some garbage value in this message. Patch attached. Thanks Michal >From e69558e2feef2f4f38d67d954b5692394701357d Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Thu, 29 Nov 2012 18:42:01 +0100 Subject: [PATCH] Missing parameter in DEBUG message. --- src/providers/data_provi

Re: [SSSD] nss hosts and caching

2012-11-29 Thread Jakub Hrozek
On Thu, Nov 29, 2012 at 03:30:48PM +, James Hogarth wrote: > Hi, > > Going through the docs I'm not entirely clear whether SSSD should be > caching host lookups (if hosts has sss added in nsswitch.conf) > > Should it cache like this (with negative cache timeouts etc via the > directives in [n

Re: [SSSD] [PATCH] failover: Protect against empty host names

2012-11-29 Thread Michal Židek
On 11/27/2012 03:18 PM, Pavel Březina wrote: On 11/26/2012 02:40 PM, Michal Židek wrote: On 11/23/2012 10:11 AM, Pavel Březina wrote: On 10/17/2012 04:01 PM, Michal Židek wrote: On 10/16/2012 11:36 AM, Pavel Březina wrote: On 10/15/2012 12:30 PM, Michal Židek wrote: Added new parameter to sp

[SSSD] nss hosts and caching

2012-11-29 Thread James Hogarth
Hi, Going through the docs I'm not entirely clear whether SSSD should be caching host lookups (if hosts has sss added in nsswitch.conf) Should it cache like this (with negative cache timeouts etc via the directives in [nss]) or should nscd be used alongside if host caching is required? Regards,

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-29 Thread Ondrej Kos
On 29/11/12 15:33, Ariel Barria wrote: > Date: Thu, 29 Nov 2012 12:08:57 +0100 > From: o...@redhat.com > To: sssd-devel@lists.fedorahosted.org > Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf > > On 28/11/12 19:31, Ariel Barria wrote: > > > > > > > Date

Re: [SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-29 Thread Simo Sorce
On Thu, 2012-11-29 at 11:48 +0100, Pavel Březina wrote: > Ack, but I'd like to consider using macro for: > > (ar->entry_type & BE_REQ_TYPE_MASK) > > Something like: > > BE_GET_REQ_TYPE(request) (request & BE_REQ_TYPE_MASK) Good idea, I'll add that. Simo. -- Simo Sorce * Red Hat, Inc * New Yo

Re: [SSSD] [PATCH 1/5] Fix tevent_req style for krb5_auth

2012-11-29 Thread Simo Sorce
On Thu, 2012-11-29 at 11:47 +0100, Pavel Březina wrote: > On 11/28/2012 05:24 AM, Simo Sorce wrote: > > +static errno_t krb5_auth_prepare_ccache_file(struct krb5child_req *kr, > > + struct be_ctx *be_ctx, > > +

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-29 Thread Ariel Barria
> Date: Thu, 29 Nov 2012 12:08:57 +0100 > From: o...@redhat.com > To: sssd-devel@lists.fedorahosted.org > Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid > sssd.conf > > On 28/11/12 19:31, Ariel Barria wrote: > > > > > > > Date: Wed, 28 Nov 2012 17:50:09 +0100 > > > Fro

Re: [SSSD] [PATCH] sudo: print message if old protocol is used

2012-11-29 Thread Jakub Hrozek
On Thu, Nov 15, 2012 at 05:54:26PM +0100, Pavel Březina wrote: > >Nitpicking, but for this kind of situations I think a switch/case > >statement would be much more clear (also avoids adding a variable as you > >use it once): > > > >switch(cli_ctx->cli_protocol_version->version) { > >case 0: > >

Re: [SSSD] [PATCH] avoid versioning libsss_sudo

2012-11-29 Thread Jakub Hrozek
On Thu, Nov 15, 2012 at 12:14:31PM +0100, Pavel Březina wrote: > We will no longer version libsss_sudo as agreed. Ack It would be nice to also teach sudo to look in another locations and then move the module outside /usr/lib{,64} in the future. ___ sssd

Re: [SSSD] [PATCH] Null pointer dereferenced.

2012-11-29 Thread Pavel Březina
On 11/28/2012 01:47 PM, Jakub Hrozek wrote: On Tue, Nov 27, 2012 at 11:42:02AM -0500, Stephen Gallagher wrote: Actually, I agree with Michal here. Performing the NULL check first reads better (and is more in line with our coding style elsewhere in SSSD). The patch's real changes are viewable wit

Re: [SSSD] [PATCH] warn user if password is about to expire

2012-11-29 Thread Pavel Březina
On 11/28/2012 05:39 PM, Sumit Bose wrote: On Wed, Nov 28, 2012 at 04:54:45PM +0100, Pavel Březina wrote: On 11/28/2012 11:15 AM, Sumit Bose wrote: On Tue, Nov 20, 2012 at 11:18:22AM +0100, Pavel Březina wrote: On 11/19/2012 04:59 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1

Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

2012-11-29 Thread Ondrej Kos
On 28/11/12 19:31, Ariel Barria wrote: > Date: Wed, 28 Nov 2012 17:50:09 +0100 > From: o...@redhat.com > To: sssd-devel@lists.fedorahosted.org > Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf > > On 28/11/12 17:12, Ariel Barria wrote: > > Thanks for your

Re: [SSSD] [PATCH 5/5] Use an entry type mask macro to filter entry types

2012-11-29 Thread Pavel Březina
Ack, but I'd like to consider using macro for: (ar->entry_type & BE_REQ_TYPE_MASK) Something like: BE_GET_REQ_TYPE(request) (request & BE_REQ_TYPE_MASK) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mail

Re: [SSSD] [PATCH 4/5] Streamline ipa_account_info handler

2012-11-29 Thread Pavel Březina
On 11/28/2012 05:24 AM, Simo Sorce wrote: In particular note that we merge ipa_account_info_netgroups_done() and ipa_account_info_users_done() into a single fucntion called ipa_account_info_done() that handles both cases We also remove the auxiliary function ipa_account_info_complete() that unne

Re: [SSSD] [PATCH 3/5] Fix tevent_req style for get_netgroup in ipa_id

2012-11-29 Thread Pavel Březina
Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH 2/5] Fix ipa_subdomain_id names and tevent_req style

2012-11-29 Thread Pavel Březina
Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH 1/5] Fix tevent_req style for krb5_auth

2012-11-29 Thread Pavel Březina
On 11/28/2012 05:24 AM, Simo Sorce wrote: +static errno_t krb5_auth_prepare_ccache_file(struct krb5child_req *kr, + struct be_ctx *be_ctx, + int *pam_status, int *dp_err) +{ +const char *ccname_template; +