[SSSD] [PATCH] Fix pam responder handling of coalesced requests

2012-12-13 Thread Simo Sorce
In our responders we have a feature that allows to avoid dispatching multiple identical requests at the same time. This is done by queing additional identical requests in a special hash table and then replying to all clients at the same time when a response is received. When the connection to a pr

Re: [SSSD] [PATCH] sudo: support generalized time format

2012-12-13 Thread Pavel Březina
On 12/13/2012 08:42 PM, Simo Sorce wrote: On Wed, 2012-12-12 at 14:34 +0100, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1712 Looks good to me, I wish there was a way to know the format is completely wrong after the first attempt so you do not try all of them for completely bogus

Re: [SSSD] [PATCH] MAN: Fix the title of sssd-sudo

2012-12-13 Thread Jakub Hrozek
On Tue, Dec 11, 2012 at 03:03:58PM -0500, Stephen Gallagher wrote: > On 12/11/2012 12:40 PM, Jakub Hrozek wrote: > >https://fedorahosted.org/sssd/ticket/1710 > > > > Ack > Pushed to master and sssd-1-9 ___ sssd-devel mailing list sssd-devel@lists.fedor

Re: [SSSD] [PATCH] sudo: support generalized time format

2012-12-13 Thread Jakub Hrozek
On Thu, Dec 13, 2012 at 02:42:12PM -0500, Simo Sorce wrote: > On Wed, 2012-12-12 at 14:34 +0100, Pavel Březina wrote: > > https://fedorahosted.org/sssd/ticket/1712 > > Looks good to me, > I wish there was a way to know the format is completely wrong after the > first attempt so you do not try all

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

2012-12-13 Thread Jakub Hrozek
On Thu, Dec 13, 2012 at 02:16:25PM -0500, Simo Sorce wrote: > On Thu, 2012-12-13 at 13:19 -0500, Simo Sorce wrote: > > On Thu, 2012-12-13 at 18:06 +0100, Michal Židek wrote: > > > Patch 1: (sssd_nss part) In functions nss_cmd_getXXnam, if working with > > > a local domain and no results were found

Re: [SSSD] [PATCHES] sudo: include primary group in user group list

2012-12-13 Thread Jakub Hrozek
On Thu, Dec 13, 2012 at 08:21:38PM +0100, Jakub Hrozek wrote: > On Thu, Dec 13, 2012 at 12:40:28PM +0100, Pavel Březina wrote: > > https://fedorahosted.org/sssd/ticket/1677 > > > > 0001: > > just a very little refactoring when touching the function > > > > Ack > > > 0002: > > Resolve primary gr

Re: [SSSD] [PATCH] additional fix for #1694

2012-12-13 Thread Jakub Hrozek
On Thu, Dec 13, 2012 at 08:28:43PM +0100, Jakub Hrozek wrote: > On Thu, Dec 13, 2012 at 08:25:41PM +0100, Jakub Hrozek wrote: > > On Wed, Dec 12, 2012 at 12:12:54PM -0500, Simo Sorce wrote: > > > Florian, > > > found that the previous fix was not sufficient. > > > > > > Attached a better patch to

Re: [SSSD] [PATCH] sudo: support generalized time format

2012-12-13 Thread Simo Sorce
On Wed, 2012-12-12 at 14:34 +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1712 Looks good to me, I wish there was a way to know the format is completely wrong after the first attempt so you do not try all of them for completely bogus strings, but it's ok in the general case.

Re: [SSSD] [PATCH] additional fix for #1694

2012-12-13 Thread Jakub Hrozek
On Thu, Dec 13, 2012 at 08:25:41PM +0100, Jakub Hrozek wrote: > On Wed, Dec 12, 2012 at 12:12:54PM -0500, Simo Sorce wrote: > > Florian, > > found that the previous fix was not sufficient. > > > > Attached a better patch to close the remaining concurrency issues in the > > client. > > > > Simo. >

Re: [SSSD] [PATCH] additional fix for #1694

2012-12-13 Thread Jakub Hrozek
On Wed, Dec 12, 2012 at 12:12:54PM -0500, Simo Sorce wrote: > Florian, > found that the previous fix was not sufficient. > > Attached a better patch to close the remaining concurrency issues in the > client. > > Simo. > > -- > Simo Sorce * Red Hat, Inc * New York The code looks sane to me, has

Re: [SSSD] [PATCHES] sudo: include primary group in user group list

2012-12-13 Thread Jakub Hrozek
On Thu, Dec 13, 2012 at 12:40:28PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1677 > > 0001: > just a very little refactoring when touching the function > Ack > 0002: > Resolve primary group in addition to secondary groups, so we don't > longer require memberUid present

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

2012-12-13 Thread Simo Sorce
On Thu, 2012-12-13 at 13:19 -0500, Simo Sorce wrote: > On Thu, 2012-12-13 at 18:06 +0100, Michal Židek wrote: > > Patch 1: (sssd_nss part) In functions nss_cmd_getXXnam, if working with > > a local domain and no results were found in sysdb, the entries are > > invalidated in memory cache too. >

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

2012-12-13 Thread Simo Sorce
On Thu, 2012-12-13 at 18:06 +0100, Michal Židek wrote: > Patch 1: (sssd_nss part) In functions nss_cmd_getXXnam, if working with > a local domain and no results were found in sysdb, the entries are > invalidated in memory cache too. Ok in the general case this patch would be sort of useless beca

Re: [SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

2012-12-13 Thread Michal Židek
On 12/13/2012 06:06 PM, Michal Židek wrote: Patch 1: (sssd_nss part) In functions nss_cmd_getXXnam, if working with a local domain and no results were found in sysdb, the entries are invalidated in memory cache too. Patch 2: (tools part) Tools sss_userdel and sss_groupdel send SSS_NSS_GETXXNAM r

[SSSD] [PATCHES] sss_userdel and sss_groupdel remove entries from fastcache

2012-12-13 Thread Michal Židek
Patch 1: (sssd_nss part) In functions nss_cmd_getXXnam, if working with a local domain and no results were found in sysdb, the entries are invalidated in memory cache too. Patch 2: (tools part) Tools sss_userdel and sss_groupdel send SSS_NSS_GETXXNAM requests after the entry was removed from s

[SSSD] [PATCHES] sudo: include primary group in user group list

2012-12-13 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/1677 0001: just a very little refactoring when touching the function 0002: Resolve primary group in addition to secondary groups, so we don't longer require memberUid present in the primary group. However, if the memberUid is present, it may happen that th