[SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Sumit Bose
Hi, a switch statement which was introduced with Remove unhelpful vtable from sss_cache has a missing default section which results in a compiler warning about an uninitialized variable. The attached patch should fix it. bye, Sumit From f12b0cc97adc2052bbe1a77366caaa5d0f610652 Mon Sep 17

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote: Hi, a switch statement which was introduced with Remove unhelpful vtable from sss_cache has a missing default section which results in a compiler warning about an uninitialized variable. The attached patch should fix it. bye,

Re: [SSSD] [PATCH] Fix faulty usn reinit

2013-01-09 Thread Jakub Hrozek
On Tue, Jan 08, 2013 at 05:54:59PM -0500, Simo Sorce wrote: On Tue, 2013-01-08 at 21:52 +0100, Jakub Hrozek wrote: On Mon, Jan 07, 2013 at 11:13:03PM -0500, Simo Sorce wrote: On Sun, 2013-01-06 at 00:37 -0500, Simo Sorce wrote: While looking at some code my eye fell on the fact that

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote: Hi, a switch statement which was introduced with Remove unhelpful vtable from sss_cache has a missing default section which results in a compiler warning about an

Re: [SSSD] [PATCH] AD: Add user as a direct member of his primary group

2013-01-09 Thread Sumit Bose
On Sun, Jan 06, 2013 at 02:44:14PM +0100, Jakub Hrozek wrote: There is one quirk that comes with using tokenGroups - the user is reported as a member of groups that are parent groups of his primary SID/GID as well. These group memberships are reflected in the database with member/memberof

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 10:51 +0100, Sumit Bose wrote: Hi, a switch statement which was introduced with Remove unhelpful vtable from sss_cache has a missing default section which results in a compiler warning about an uninitialized variable. The attached patch should fix it. The default

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote: Hi, a switch statement which was introduced with Remove unhelpful vtable from sss_cache has a missing

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote: Hi, a switch statement which was introduced with

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 10:51:34AM +0100, Sumit Bose wrote:

Re: [SSSD] [PATCH] Fix faulty usn reinit

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 11:35:38AM +0100, Jakub Hrozek wrote: Patch #3 is more tricky to test. Feel free to push patches #1 and #2 to master if it would ease your rebasing if I'm not done testing the last one soon. Squash in the attached fix and you'll get an ack even for patch #3 :-) From

Re: [SSSD] [PATCH] AD: Add user as a direct member of his primary group

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 02:32:41PM +0100, Sumit Bose wrote: On Sun, Jan 06, 2013 at 02:44:14PM +0100, Jakub Hrozek wrote: There is one quirk that comes with using tokenGroups - the user is reported as a member of groups that are parent groups of his primary SID/GID as well. These group

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 08:45 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 11:31:53AM +0100, Jakub Hrozek wrote: On Wed,

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Sumit Bose
On Wed, Jan 09, 2013 at 10:19:29AM -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:45 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 11:37 +0100, Jakub Hrozek wrote: On Wed,

Re: [SSSD] [PATCH] Fix faulty usn reinit

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 15:08 +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 11:35:38AM +0100, Jakub Hrozek wrote: Patch #3 is more tricky to test. Feel free to push patches #1 and #2 to master if it would ease your rebasing if I'm not done testing the last one soon. Squash in the

Re: [SSSD] [PATCH] Add a default section to a swtich-statement

2013-01-09 Thread Simo Sorce
On Wed, 2013-01-09 at 16:31 +0100, Sumit Bose wrote: On Wed, Jan 09, 2013 at 10:19:29AM -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:45 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:38 -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 08:35 -0500, Simo Sorce wrote: On Wed,

Re: [SSSD] [PATCH] AD: replace GID/UID, do not add another one

2013-01-09 Thread Sumit Bose
On Mon, Jan 07, 2013 at 03:06:59PM +0100, Jakub Hrozek wrote: On Mon, Jan 07, 2013 at 02:51:53PM +0100, Jakub Hrozek wrote: On Sun, Jan 06, 2013 at 02:35:42PM +0100, Jakub Hrozek wrote: Please see the commit message. I was wondering whether to include a new sysdb function, but then I

Re: [SSSD] [PATCH] AD: Add user as a direct member of his primary group

2013-01-09 Thread Sumit Bose
On Wed, Jan 09, 2013 at 03:37:17PM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 02:32:41PM +0100, Sumit Bose wrote: On Sun, Jan 06, 2013 at 02:44:14PM +0100, Jakub Hrozek wrote: There is one quirk that comes with using tokenGroups - the user is reported as a member of groups that

Re: [SSSD] [PATCH] AD: replace GID/UID, do not add another one

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 05:41:54PM +0100, Sumit Bose wrote: On Mon, Jan 07, 2013 at 03:06:59PM +0100, Jakub Hrozek wrote: On Mon, Jan 07, 2013 at 02:51:53PM +0100, Jakub Hrozek wrote: On Sun, Jan 06, 2013 at 02:35:42PM +0100, Jakub Hrozek wrote: Please see the commit message. I was

Re: [SSSD] [PATCH] AD: replace GID/UID, do not add another one

2013-01-09 Thread Sumit Bose
On Wed, Jan 09, 2013 at 05:47:06PM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 05:41:54PM +0100, Sumit Bose wrote: On Mon, Jan 07, 2013 at 03:06:59PM +0100, Jakub Hrozek wrote: On Mon, Jan 07, 2013 at 02:51:53PM +0100, Jakub Hrozek wrote: On Sun, Jan 06, 2013 at 02:35:42PM +0100,

Re: [SSSD] [PATCH] AD: Add user as a direct member of his primary group

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 05:43:15PM +0100, Sumit Bose wrote: Patches are looking good and testing went well together with Patch AD: replace GID/UID, do not add another one ACK bye, Sumit Pushed to master and sssd-1-9 ___ sssd-devel mailing list

Re: [SSSD] [PATCH] AD: replace GID/UID, do not add another one

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 05:54:14PM +0100, Sumit Bose wrote: On Wed, Jan 09, 2013 at 05:47:06PM +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 05:41:54PM +0100, Sumit Bose wrote: On Mon, Jan 07, 2013 at 03:06:59PM +0100, Jakub Hrozek wrote: On Mon, Jan 07, 2013 at 02:51:53PM +0100,

Re: [SSSD] [PATCH] Fix faulty usn reinit

2013-01-09 Thread Jakub Hrozek
On Wed, Jan 09, 2013 at 10:48:50AM -0500, Simo Sorce wrote: On Wed, 2013-01-09 at 15:08 +0100, Jakub Hrozek wrote: On Wed, Jan 09, 2013 at 11:35:38AM +0100, Jakub Hrozek wrote: Patch #3 is more tricky to test. Feel free to push patches #1 and #2 to master if it would ease your rebasing if

[SSSD] [PATCH] tools: Respect use_fully_qualified_names

2013-01-09 Thread Michal Židek
Tools for LOCAL domain ignored the 'use_fully_qualified_names = TRUE' option. https://fedorahosted.org/sssd/ticket/1746. Michal From 79db85fa0fcca2ff8cdf1d8b824a7c0ff1b8cb15 Mon Sep 17 00:00:00 2001 From: Michal Zidek mzi...@redhat.com Date: Wed, 9 Jan 2013 20:30:58 +0100 Subject: [PATCH]