Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Mon, Jan 14, 2013 at 03:50:17PM +0100, Jakub Hrozek wrote: Patch 0059: Stop creating fake sysdb contexts Ack from my point of view, but Sumit is a better authority on subdomains. But ID operations in a trusted domain still worked. Sumit did test the patchset in a trusted environment (thank

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Tue, Jan 15, 2013 at 10:58:45AM +0100, Jakub Hrozek wrote: On Mon, Jan 14, 2013 at 03:50:17PM +0100, Jakub Hrozek wrote: Patch 0059: Stop creating fake sysdb contexts Ack from my point of view, but Sumit is a better authority on subdomains. But ID operations in a trusted domain still

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Tue, Jan 15, 2013 at 11:14:38AM +0100, Jakub Hrozek wrote: On Tue, Jan 15, 2013 at 10:58:45AM +0100, Jakub Hrozek wrote: On Mon, Jan 14, 2013 at 03:50:17PM +0100, Jakub Hrozek wrote: Patch 0059: Stop creating fake sysdb contexts Ack from my point of view, but Sumit is a better

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Tue, 2013-01-15 at 11:17 +0100, Jakub Hrozek wrote: On Tue, Jan 15, 2013 at 11:14:38AM +0100, Jakub Hrozek wrote: On Tue, Jan 15, 2013 at 10:58:45AM +0100, Jakub Hrozek wrote: On Mon, Jan 14, 2013 at 03:50:17PM +0100, Jakub Hrozek wrote: Patch 0059: Stop creating fake sysdb contexts

Re: [SSSD] [PATCH] NSS: invalidate memcache user entry on initgr, too

On Tue, 2013-01-15 at 09:02 +0100, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1757 When the user entry was missing completely after initgroups, we would never invalidate the user entry from cache. This led to dangling cache entried in memory cache if the user was removed from

[SSSD] [PATCH] TOOLS: set domain in check_group_names

Patch only for master. I'm sorry, I missed this codepath when testing the recent changes. From ac3aed75dbfcfdd4af605ca5bea0ac4baf7c2517 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Tue, 15 Jan 2013 14:32:31 +0100 Subject: [PATCH] TOOLS: set domain in check_group_names ---

[SSSD] [PATCH] Update memcache after changes to group memberships in LOCAL domain

The attached patches fix https://fedorahosted.org/sssd/ticket/1764. We were only invalidating memcache when removing users or groups, but we should invalidate it on any changes including changes to group memberships etc. From 3f010184531e7ab2974fca86cc43edc6a2c8c0ed Mon Sep 17 00:00:00 2001 From:

Re: [SSSD] [PATCHES] Initial refactoring for #1747

On Tue, Jan 15, 2013 at 08:20:28AM -0500, Simo Sorce wrote: On Tue, 2013-01-15 at 11:17 +0100, Jakub Hrozek wrote: On Tue, Jan 15, 2013 at 11:14:38AM +0100, Jakub Hrozek wrote: On Tue, Jan 15, 2013 at 10:58:45AM +0100, Jakub Hrozek wrote: On Mon, Jan 14, 2013 at 03:50:17PM +0100, Jakub

Re: [SSSD] [PATCH] NSS: invalidate memcache user entry on initgr, too

On Tue, Jan 15, 2013 at 08:27:32AM -0500, Simo Sorce wrote: On Tue, 2013-01-15 at 09:02 +0100, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1757 When the user entry was missing completely after initgroups, we would never invalidate the user entry from cache. This led to

Re: [SSSD] [PATCH] TOOLS: set domain in check_group_names

On Tue, Jan 15, 2013 at 02:38:59PM +0100, Jakub Hrozek wrote: Patch only for master. I'm sorry, I missed this codepath when testing the recent changes. ACK bye, Sumit From ac3aed75dbfcfdd4af605ca5bea0ac4baf7c2517 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Tue,

Re: [SSSD] [PATCH] Update memcache after changes to group memberships in LOCAL domain

On Tue, Jan 15, 2013 at 02:41:33PM +0100, Jakub Hrozek wrote: The attached patches fix https://fedorahosted.org/sssd/ticket/1764. We were only invalidating memcache when removing users or groups, but we should invalidate it on any changes including changes to group memberships etc. Patches

[SSSD] [PATCH] LDAP: avoid complex realloc logic in save_rfc2307bis_group_memberships

The function tried to be smart and realloc only when needed, but that only lead to hard-to find bugs where the logic would not allocate the proper space. Remove the reallocation and prefer readability over speed in this case. In particular, if one iteration hit the if (num_added == 0) add=NULL

Re: [SSSD] [PATCH] Update memcache after changes to group memberships in LOCAL domain

On Tue, Jan 15, 2013 at 04:01:17PM +0100, Sumit Bose wrote: On Tue, Jan 15, 2013 at 02:41:33PM +0100, Jakub Hrozek wrote: The attached patches fix https://fedorahosted.org/sssd/ticket/1764. We were only invalidating memcache when removing users or groups, but we should invalidate it on any

Re: [SSSD] [PATCH] LDAP: avoid complex realloc logic in save_rfc2307bis_group_memberships

On Tue, 2013-01-15 at 17:38 +0100, Jakub Hrozek wrote: The function tried to be smart and realloc only when needed, but that only lead to hard-to find bugs where the logic would not allocate the proper space. Remove the reallocation and prefer readability over speed in this case. In

Re: [SSSD] [PATCH] TOOLS: set domain in check_group_names

On Tue, Jan 15, 2013 at 03:58:09PM +0100, Sumit Bose wrote: On Tue, Jan 15, 2013 at 02:38:59PM +0100, Jakub Hrozek wrote: Patch only for master. I'm sorry, I missed this codepath when testing the recent changes. ACK bye, Sumit Pushed to master.

Re: [SSSD] [PATCH] LDAP: avoid complex realloc logic in save_rfc2307bis_group_memberships

On Tue, Jan 15, 2013 at 02:12:48PM -0500, Simo Sorce wrote: On Tue, 2013-01-15 at 17:38 +0100, Jakub Hrozek wrote: The function tried to be smart and realloc only when needed, but that only lead to hard-to find bugs where the logic would not allocate the proper space. Remove the