Re: [SSSD] [PATCH] refactor nested group processing

2013-02-22 Thread Pavel Brezina
- Original Message - > From: "Pavel Březina" > To: sssd-devel@lists.fedorahosted.org > Sent: Thursday, February 21, 2013 11:43:26 AM > Subject: [SSSD] [PATCH] refactor nested group processing > > https://fedorahosted.org/sssd/ticket/1784 I should have probably add that this is the final

Re: [SSSD] [PATCH] Do not process success case in an else

2013-02-22 Thread Michal Židek
On 02/01/2013 11:56 AM, Jakub Hrozek wrote: No functional change, it's just bad manners to have a code structured like: if (ret != EOK) { /* Do stuff */ } else { /* Do different stuff */ } The else was moved to the topmost block. Ack. Michal __

Re: [SSSD] [PATCH] sysdb: try dealing with binary-content attributes

2013-02-22 Thread Jan Engelhardt
On Friday 2013-02-22 17:31, Jakub Hrozek wrote: >> I have here a LDAP user entry which has this attribute >> >> loginAllowedTimeMap:: >> AP///38AAP///38AAP///38AAP///38AAP///38A >> >> In the function sysdb_attrs_add_string(), called from >> sdap_attrs_add_ldap_attr(),

Re: [SSSD] [PATCH] Remove enumerate=true from man sssd-ldap

2013-02-22 Thread Michal Židek
On 02/14/2013 08:24 PM, Jakub Hrozek wrote: A simple one-liner. According to git grep, no other example in the man pages suggests enumerate=true. https://fedorahosted.org/sssd/ticket/1737 I haven't find any other places in documentation that would suggest enumerate = true. Ack. Michal _

Re: [SSSD] [PATCH] sdap_fill_memberships: continue if a member is not foud in sysdb

2013-02-22 Thread Jakub Hrozek
On Fri, Feb 22, 2013 at 03:32:50PM +0100, Pavel Březina wrote: > https://fedorahosted.org/sssd/ticket/1755 I agree, I can't think of a reason why we should be failing to store a group completely when we can't find one of its members for one reason or another. I haven't really done much testing bu

Re: [SSSD] [PATCH] sysdb: try dealing with binary-content attributes

2013-02-22 Thread Jakub Hrozek
On Thu, Feb 21, 2013 at 01:20:47PM +0100, Jan Engelhardt wrote: > I have here a LDAP user entry which has this attribute > > loginAllowedTimeMap:: >AP///38AAP///38AAP///38AAP///38AAP///38A > > In the function sysdb_attrs_add_string(), called from > sdap_attrs_add_lda

Re: [SSSD] Design Discussion: SSSD should support DNS sites

2013-02-22 Thread Sumit Bose
On Fri, Feb 22, 2013 at 04:41:15PM +0100, Jakub Hrozek wrote: > On Fri, Feb 22, 2013 at 04:32:44PM +0100, Sumit Bose wrote: > > On Fri, Feb 22, 2013 at 02:57:08PM +0100, Pavel Březina wrote: > > > On 02/22/2013 09:33 AM, Sumit Bose wrote: > > > >On Thu, Feb 21, 2013 at 07:02:47PM +0100, Jakub Hroze

Re: [SSSD] [PATCH] Fix the krb5 password expiration warning

2013-02-22 Thread Jakub Hrozek
On Mon, Feb 18, 2013 at 03:17:36PM +0100, Ondrej Kos wrote: > On 02/14/2013 08:21 PM, Jakub Hrozek wrote: > >The attached patch fixes https://fedorahosted.org/sssd/ticket/1808. When > >the domain pam expiration is not set at all, default to -1 so that the > >Kerberos provider can pick its default o

Re: [SSSD] Design Discussion: SSSD should support DNS sites

2013-02-22 Thread Jakub Hrozek
On Fri, Feb 22, 2013 at 04:32:44PM +0100, Sumit Bose wrote: > On Fri, Feb 22, 2013 at 02:57:08PM +0100, Pavel Březina wrote: > > On 02/22/2013 09:33 AM, Sumit Bose wrote: > > >On Thu, Feb 21, 2013 at 07:02:47PM +0100, Jakub Hrozek wrote: > > >>On Thu, Feb 21, 2013 at 05:16:07PM +0100, Sumit Bose wr

Re: [SSSD] Design Discussion: SSSD should support DNS sites

2013-02-22 Thread Sumit Bose
On Fri, Feb 22, 2013 at 02:57:08PM +0100, Pavel Březina wrote: > On 02/22/2013 09:33 AM, Sumit Bose wrote: > >On Thu, Feb 21, 2013 at 07:02:47PM +0100, Jakub Hrozek wrote: > >>On Thu, Feb 21, 2013 at 05:16:07PM +0100, Sumit Bose wrote: > >>>After a discussion with Simo I updated the page again. > >

Re: [SSSD] sysdb mishandles LDAP attrs with binary blob data

2013-02-22 Thread Jan Engelhardt
On Thursday 2013-02-21 13:20, Jan Engelhardt wrote: >The problem exists since at least sssd-1.8.5 [openSUSE 12.2]. The patch >is against HEAD and applies there likewise. Just for the record, the problem does not exist in sssd-1.5.11 (the version we shipped in openSUSE 12.1). AFAICS, sssd-1.5.11

[SSSD] [PATCH] BUILD: Build shared components as an internal shared library

2013-02-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 There is a large amount of duplicated code being linked into multiple SSSD binaries. Instead of statically linking this code throughout the SSSD, we should instead create private shared libraries for them and drop this code on the system only once. T

[SSSD] [PATCH] sdap_fill_memberships: continue if a member is not foud in sysdb

2013-02-22 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/1755 From bac604c707903ba9dc9346d45bc43a26859e582b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Fri, 22 Feb 2013 15:27:55 +0100 Subject: [PATCH] sdap_fill_memberships: continue if a member is not foud in sysdb https://fedorahosted.or

Re: [SSSD] Design Discussion: SSSD should support DNS sites

2013-02-22 Thread Pavel Březina
On 02/22/2013 09:33 AM, Sumit Bose wrote: On Thu, Feb 21, 2013 at 07:02:47PM +0100, Jakub Hrozek wrote: On Thu, Feb 21, 2013 at 05:16:07PM +0100, Sumit Bose wrote: After a discussion with Simo I updated the page again. bye, Sumit Hi, I think this plugin architecture matches what we discuss

Re: [SSSD] Design Discussion: SSSD should support DNS sites

2013-02-22 Thread Sumit Bose
On Thu, Feb 21, 2013 at 07:02:47PM +0100, Jakub Hrozek wrote: > On Thu, Feb 21, 2013 at 05:16:07PM +0100, Sumit Bose wrote: > > After a discussion with Simo I updated the page again. > > > > bye, > > Sumit > > > > Hi, > > I think this plugin architecture matches what we discussed over the > pho