This email provides the patch as an attachment. It also provides a more
substantial commit message and fixes one comment formatting issue.
Nathaniel
>From a544ee1457c8fd928d7e4d8fd9a3c8ee7ced5503 Mon Sep 17 00:00:00 2001
From: Nathaniel McCallum
Date: Tue, 5 Mar 2013 15:57:45 -0500
Subject: [PATC
Hi Jackub,
May be you can include the attached file here
http://jhrozek.fedorapeople.org/cmocka/
It's an example showing complete mocking of rect.c interface.
thanks,
Abhishek
On Thu, Feb 28, 2013 at 3:10 PM, Jakub Hrozek wrote:
> On Thu, Feb 28, 2013 at 01:17:41AM +0530, Abhishek Singh wrote
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I've been meaning to put these together and submit them for a while.
This is the set of macros and aliases I've been using for years to
build SSSD. I played around with them today, adding some
auto-detection for the platform being built, so it should b
On Tue, Mar 05, 2013 at 06:46:00PM +0100, Jakub Hrozek wrote:
> It seems that at least some error codes are mishandled. When I attempt
> to auth with a bad password, SSSD returns System Error. This is not what
> we want, for some display managers (xdm and I thin even kdm) the System
> Error retval
On Tue, Mar 05, 2013 at 12:51:41PM -0500, Stephen Gallagher wrote:
> On Tue 05 Mar 2013 11:42:40 AM EST, Simo Sorce wrote:
> > On Tue, 2013-03-05 at 11:21 -0500, Stephen Gallagher wrote:
> >> -BEGIN PGP SIGNED MESSAGE-
> >> Hash: SHA1
> >>
> >> On Tue 05 Mar 2013 11:11:28 AM EST, Simo Sorce
On Tue 05 Mar 2013 11:42:40 AM EST, Simo Sorce wrote:
> On Tue, 2013-03-05 at 11:21 -0500, Stephen Gallagher wrote:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> On Tue 05 Mar 2013 11:11:28 AM EST, Simo Sorce wrote:
>>> Thanks to Stephen for pointing out the flaw.
>>>
>>
>> Would you mi
On Tue, Mar 05, 2013 at 05:11:29PM +0100, Pavel Březina wrote:
> On 03/04/2013 07:34 PM, Simo Sorce wrote:
> >On Mon, 2013-03-04 at 13:29 -0500, Simo Sorce wrote:
> >>On Mon, 2013-03-04 at 13:10 +0100, Pavel Březina wrote:
> >>>On 02/28/2013 12:29 AM, Simo Sorce wrote:
> This patch removes yet
On Tue, Mar 05, 2013 at 12:20:14PM -0500, Lukas Slebodnik wrote:
> Hi,
> I played with clang and there were 2 interesting warnings:
>
> ---
> ../sssd/src/responder/sudo/sudosrv_get_sudorules.c:373:71: warning: implicit
> conversion from enumeration type 'enum sss_sudo_type' to dif
Hi,
I played with clang and there were 2 interesting warnings:
---
../sssd/src/responder/sudo/sudosrv_get_sudorules.c:373:71: warning: implicit
conversion from enumeration type 'enum sss_sudo_type' to different enumeration
type 'enum sss_dp_sudo_type' [-Wconversion]
On Tue, Mar 05, 2013 at 11:17:10AM -0500, Simo Sorce wrote:
> On Tue, 2013-03-05 at 16:36 +0100, Michal Židek wrote:
> > https://fedorahosted.org/sssd/ticket/1765
> >
> > Patch is in attachment.
>
> ACK.
>
> Simo.
Pushed to master.
___
sssd-devel mail
On Tue, 2013-03-05 at 11:21 -0500, Stephen Gallagher wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On Tue 05 Mar 2013 11:11:28 AM EST, Simo Sorce wrote:
> > Thanks to Stephen for pointing out the flaw.
> >
>
> Would you mind updating the commit message to note that it also fixes
>
On Tue, Mar 05, 2013 at 02:14:56PM +0100, Pavel Březina wrote:
> On 03/05/2013 12:21 AM, Jakub Hrozek wrote:
> >With the amount of patches making its way to master these days, I
> >thought it was prudent to run clang out-of-band. It uncovered a bunch of
> >false positives and this bug.
>
> Ack.
P
On Fri, Mar 01, 2013 at 01:39:22PM +0100, Pavel Březina wrote:
> On 02/12/2013 06:12 PM, Jakub Hrozek wrote:
> >Hi,
> >
> >Short version - attached is a patch proposal for a unit test based on
> >cmocka. The patches are an example of a complex, yet isolated unit test
> >and I'd like to get opinions
---
src/external/krb5.m4| 1 +
src/providers/krb5/krb5_auth.c | 2 +-
src/providers/krb5/krb5_auth.h | 1 +
src/providers/krb5/krb5_child.c | 201
src/providers/krb5/krb5_child_handler.c | 7 ++
src/sss_client/s
On Fri, Mar 01, 2013 at 02:38:08PM +0100, Pavel Březina wrote:
> On 03/01/2013 02:01 PM, Jakub Hrozek wrote:
> >On Fri, Mar 01, 2013 at 01:39:22PM +0100, Pavel Březina wrote:
> >>>[1] http://cmocka.cryptomilk.org/
> >>
> >>Very nice.
> >>
> >>I would like to increase granularity though. First of al
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Tue 05 Mar 2013 11:11:28 AM EST, Simo Sorce wrote:
> Thanks to Stephen for pointing out the flaw.
>
Would you mind updating the commit message to note that it also fixes
the ERR_LAST comparison (which was the original issue that Coverity
identifie
On 03/05/2013 05:11 PM, Simo Sorce wrote:
Thanks to Stephen for pointing out the flaw.
Ack.
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On Tue, 2013-03-05 at 16:36 +0100, Michal Židek wrote:
> https://fedorahosted.org/sssd/ticket/1765
>
> Patch is in attachment.
ACK.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://l
Thanks to Stephen for pointing out the flaw.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
>From e8179af19debdac179747bbdeaccb6b3a0c47a50 Mon Sep 17 00:00:00 2001
From: Simo Sorce
Date: Tue, 5 Mar 2013 10:12:10 -0500
Subject: [PATCH] Improve IS_SSSD_ERROR() macro
We need to mask the first part
On 03/04/2013 07:34 PM, Simo Sorce wrote:
On Mon, 2013-03-04 at 13:29 -0500, Simo Sorce wrote:
On Mon, 2013-03-04 at 13:10 +0100, Pavel Březina wrote:
On 02/28/2013 12:29 AM, Simo Sorce wrote:
This patch removes yet another set of custom and parallel error codes
specified in the sdap_result en
https://fedorahosted.org/sssd/ticket/1765
Patch is in attachment.
Thanks
Michal
>From 9cc03efcb98a28b47ab2c9c7988ee8a261775895 Mon Sep 17 00:00:00 2001
From: Michal Zidek
Date: Tue, 5 Mar 2013 16:23:14 +0100
Subject: [PATCH] Remove the alt_db_path parameter of sysdb_init
This parameter was nev
On 03/05/2013 12:21 AM, Jakub Hrozek wrote:
With the amount of patches making its way to master these days, I
thought it was prudent to run clang out-of-band. It uncovered a bunch of
false positives and this bug.
Ack.
___
sssd-devel mailing list
sssd
On Tue, Mar 05, 2013 at 09:57:36AM +0100, Sumit Bose wrote:
> On Tue, Mar 05, 2013 at 12:20:12AM +0100, Jakub Hrozek wrote:
> > I don't think there is a reason to ignore error codes while storing
> > subdomains.
>
> I see it the other way round, there is no reason to return an error if
> storing a
On Tue, Mar 05, 2013 at 12:20:12AM +0100, Jakub Hrozek wrote:
> I don't think there is a reason to ignore error codes while storing
> subdomains.
I see it the other way round, there is no reason to return an error if
storing a subdomain fails, because we cannot do anything about it. If an
error is
24 matches
Mail list logo
