[SSSD] [PATCH] Fixed typo in debug message.

2013-03-07 Thread Lukas Slebodnik
Hello, I am trying to get familiar with source code of sssd and I found typo in source code. This is not critical issue, because this is only debug message. There was more than 2 years :-) LSFrom 33b8a77f69a6b8ad52714fcd8fac5e92b0dc1ced Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik

Re: [SSSD] [PATCH] Fixed typo in debug message.

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 04:54:46AM -0500, Lukas Slebodnik wrote: Hello, I am trying to get familiar with source code of sssd and I found typo in source code. This is not critical issue, because this is only debug message. There was more than 2 years :-) LS Hi, we are gradually trying to

[SSSD] [PATCH] Removing unused parameter type from sudosrv_get_sudorules_query_cache()

2013-03-07 Thread Lukas Slebodnik
Hi, this patch should solve ticket https://fedorahosted.org/sssd/ticket/1825 LSFrom 639b380e6f5705b6fb6db3287a3047396a3bb54a Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Thu, 7 Mar 2013 11:54:01 +0100 Subject: [PATCH] Removing unused parameter type from

Re: [SSSD] [PATCHES] change responder contexts hierarchy

2013-03-07 Thread Pavel Březina
On 03/07/2013 11:26 AM, Pavel Březina wrote: On 10/30/2012 07:21 PM, Jakub Hrozek wrote: On Tue, Oct 30, 2012 at 03:24:43PM +0100, Jakub Hrozek wrote: On Fri, Oct 19, 2012 at 12:27:44PM +0200, Pavel Březina wrote: 0001: do not leak memory on failure in *_process_init() 0002:

Re: [SSSD] [PATCH] Removing unused parameter type from sudosrv_get_sudorules_query_cache()

2013-03-07 Thread Pavel Březina
On 03/07/2013 12:10 PM, Lukas Slebodnik wrote: Hi, this patch should solve ticket https://fedorahosted.org/sssd/ticket/1825 LS Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Fixed typo in debug message.

2013-03-07 Thread Lukas Slebodnik
Hi, numbers converted to SSSDBG_ levels. Should I update whole file? LS - Original Message - From: Jakub Hrozek jhro...@redhat.com To: sssd-devel@lists.fedorahosted.org Sent: Thursday, March 7, 2013 11:06:50 AM Subject: Re: [SSSD] [PATCH] Fixed typo in debug message. On Thu, Mar 07,

Re: [SSSD] [PATCH] Fixed typo in debug message.

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 06:38:49AM -0500, Lukas Slebodnik wrote: Hi, numbers converted to SSSDBG_ levels. Ack to the patch. Should I update whole file? No, that's not needed. Let's just continue changing the levels along with other changes. LS Please don't top post :) - Original

Re: [SSSD] [PATCH] Fixed typo in debug message.

2013-03-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu 07 Mar 2013 06:38:49 AM EST, Lukas Slebodnik wrote: Hi, numbers converted to SSSDBG_ levels. Should I update whole file? No, we're not trying to do a mass-update at this time. Our policy is that anytime you modify a function that still

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Michal Židek
On 03/07/2013 03:56 AM, Simo Sorce wrote: On Thu, 2013-03-07 at 03:15 +0100, Michal Židek wrote: On 03/07/2013 12:02 AM, Simo Sorce wrote: On Wed, 2013-03-06 at 23:19 +0100, Michal Židek wrote: On 03/06/2013 08:13 PM, Simo Sorce wrote: On Wed, 2013-03-06 at 19:33 +0100, Michal Židek wrote:

[SSSD] [PATCH] Provide libnl3 support

2013-03-07 Thread Ondrej Kos
Hi, Attached find patch introducing support of the libnl3 netlink library. The SSSD now builds with libnl3 by default, but is still configurable to use the libnl in version 1 by adding configure parameter --with-netlink-lib=libnl Ondra -- Ondrej Kos Associate Software Engineer Identity

[SSSD] Design Discussion: Integrate SSSD with CIFS Client

2013-03-07 Thread Sumit Bose
Hi, please have a look at https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient This is my understanding about what needs to be done to replace winbind with sssd with respect to a CIFS client, i.e. cifs kernel module and cifs-utils packages. For your convenience the content

Re: [SSSD] [PATCH] Fixed typo in debug message.

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 01:38:17PM +0100, Jakub Hrozek wrote: On Thu, Mar 07, 2013 at 06:38:49AM -0500, Lukas Slebodnik wrote: Hi, numbers converted to SSSDBG_ levels. Ack to the patch. Pushed to master. ___ sssd-devel mailing list

Re: [SSSD] [PATCH] Removing unused parameter type from sudosrv_get_sudorules_query_cache()

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 12:29:58PM +0100, Pavel Březina wrote: On 03/07/2013 12:10 PM, Lukas Slebodnik wrote: Hi, this patch should solve ticket https://fedorahosted.org/sssd/ticket/1825 LS Ack. Pushed to master. ___ sssd-devel mailing list

Re: [SSSD] Design Discussion: Integrate SSSD with CIFS Client

2013-03-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/07/2013 08:22 AM, Sumit Bose wrote: Hi, please have a look at https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient This is my understanding about what needs to be done to replace winbind with sssd with respect to a

Re: [SSSD] [PATCH] Provide libnl3 support

2013-03-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu 07 Mar 2013 08:17:19 AM EST, Ondrej Kos wrote: Hi, Attached find patch introducing support of the libnl3 netlink library. The SSSD now builds with libnl3 by default, but is still configurable to use the libnl in version 1 by adding

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Simo Sorce
On Thu, 2013-03-07 at 13:44 +0100, Michal Židek wrote: Ok :) So I removed the unlink() from destructor (and the sss_mc_set_recycled with it). I added new dret variable to catch return value from unlink() in the done: part of sss_mc_create_file(), so that we do not overwrite the original

Re: [SSSD] Design Discussion: Integrate SSSD with CIFS Client

2013-03-07 Thread Simo Sorce
On Thu, 2013-03-07 at 08:35 -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/07/2013 08:22 AM, Sumit Bose wrote: Hi, please have a look at https://fedorahosted.org/sssd/wiki/DesignDocs/IntegrateSSSDWithCIFSClient This is my understanding

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Michal Židek
On 03/07/2013 02:42 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 13:44 +0100, Michal Židek wrote: Ok :) So I removed the unlink() from destructor (and the sss_mc_set_recycled with it). I added new dret variable to catch return value from unlink() in the done: part of sss_mc_create_file(), so

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Simo Sorce
On Thu, 2013-03-07 at 15:02 +0100, Michal Židek wrote: +/* Closing the file descriptor and ummaping the file + * from memory is done in the mc_ctx_destructor. */ if (mc_ctx mc_ctx-fd != -1) { -close(mc_ctx-fd); -ret = unlink(mc_ctx-file); -

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Michal Židek
On 03/07/2013 03:22 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:02 +0100, Michal Židek wrote: +/* Closing the file descriptor and ummaping the file + * from memory is done in the mc_ctx_destructor. */ if (mc_ctx mc_ctx-fd != -1) { -close(mc_ctx-fd); -

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Simo Sorce
On Thu, 2013-03-07 at 15:46 +0100, Michal Židek wrote: On 03/07/2013 03:22 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:02 +0100, Michal Židek wrote: +/* Closing the file descriptor and ummaping the file + * from memory is done in the mc_ctx_destructor. */ if

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Michal Židek
On 03/07/2013 04:19 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:46 +0100, Michal Židek wrote: On 03/07/2013 03:22 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:02 +0100, Michal Židek wrote: +/* Closing the file descriptor and ummaping the file + * from memory is done in

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Simo Sorce
On Thu, 2013-03-07 at 17:44 +0100, Michal Židek wrote: On 03/07/2013 04:19 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:46 +0100, Michal Židek wrote: On 03/07/2013 03:22 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:02 +0100, Michal Židek wrote: +/* Closing the file descriptor

Re: [SSSD] [PATCH] File descriptor leak in nss responder.

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 11:53:12AM -0500, Simo Sorce wrote: On Thu, 2013-03-07 at 17:44 +0100, Michal Židek wrote: On 03/07/2013 04:19 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:46 +0100, Michal Židek wrote: On 03/07/2013 03:22 PM, Simo Sorce wrote: On Thu, 2013-03-07 at 15:02

Re: [SSSD] [PATCH] BUILD: Add contributed macros and aliases to simplify building

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 07:21:18PM +0100, Jakub Hrozek wrote: On Wed, Mar 06, 2013 at 10:47:45AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 06 Mar 2013 09:02:44 AM EST, Jakub Hrozek wrote: +# Determine the architecture of the platform we're

Re: [SSSD] [PATCH] BUILD: Add contributed macros and aliases to simplify building

2013-03-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/07/2013 01:21 PM, Jakub Hrozek wrote: On Wed, Mar 06, 2013 at 10:47:45AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 06 Mar 2013 09:02:44 AM EST, Jakub Hrozek wrote: +# Determine the architecture

Re: [SSSD] [PATCH] BUILD: Add contributed macros and aliases to simplify building

2013-03-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/07/2013 01:23 PM, Jakub Hrozek wrote: On Thu, Mar 07, 2013 at 07:21:18PM +0100, Jakub Hrozek wrote: On Wed, Mar 06, 2013 at 10:47:45AM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed 06 Mar 2013

Re: [SSSD] [PATCH] BUILD: Add contributed macros and aliases to simplify building

2013-03-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu 07 Mar 2013 01:46:22 PM EST, Stephen Gallagher wrote: On 03/07/2013 01:23 PM, Jakub Hrozek wrote: On Thu, Mar 07, 2013 at 07:21:18PM +0100, Jakub Hrozek wrote: Ack, I will just squash in the attached patch so that the example can be just

Re: [SSSD] [PATCH] Provide libnl3 support

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 02:17:19PM +0100, Ondrej Kos wrote: Hi, Attached find patch introducing support of the libnl3 netlink library. The SSSD now builds with libnl3 by default, but is still configurable to use the libnl in version 1 by adding configure parameter --with-netlink-lib=libnl

Re: [SSSD] [PATCH] BUILD: Add contributed macros and aliases to simplify building

2013-03-07 Thread Jakub Hrozek
On Thu, Mar 07, 2013 at 01:58:23PM -0500, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu 07 Mar 2013 01:46:22 PM EST, Stephen Gallagher wrote: On 03/07/2013 01:23 PM, Jakub Hrozek wrote: On Thu, Mar 07, 2013 at 07:21:18PM +0100, Jakub Hrozek wrote: Ack, I