Re: [SSSD] [PATCH] BUILD: Fix cmocka

2013-03-12 Thread Lukas Slebodnik
On (11/03/13 15:04), Pavel Brezina wrote: >- Original Message - >> From: "Stephen Gallagher" >> To: "Development of the System Security Services Daemon" >> >> Sent: Monday, March 11, 2013 5:38:30 PM >> Subject: [SSSD] [PATCH] BUILD: Fix cmocka >> >> -BEGIN PGP SIGNED MESSAGE- >>

Re: [SSSD] rawhide test failure: krb5-utils-tests

2013-03-12 Thread Lukas Slebodnik
On (11/03/13 19:33), Stephen Gallagher wrote: >On 03/11/2013 05:31 PM, Nathaniel McCallum wrote: >> http://koji.fedoraproject.org/koji/taskinfo?taskID=5108784 >> > >Most likely https://fedorahosted.org/sssd/ticket/1833 > It should not be issue from ticket #1833. In spec file there is no BuildRequ

Re: [SSSD] rawhide test failure: krb5-utils-tests

2013-03-12 Thread Ondrej Kos
On 03/12/2013 12:33 AM, Stephen Gallagher wrote: On 03/11/2013 05:31 PM, Nathaniel McCallum wrote: >http://koji.fedoraproject.org/koji/taskinfo?taskID=5108784 > Most likelyhttps://fedorahosted.org/sssd/ticket/1833 I wouldn't say so, the cmocka failing tests are in nss-srv-tests, in the build

[SSSD] [PATCH] Removing unused header file providers.h

2013-03-12 Thread Lukas Slebodnik
Hi, I found two header files, which are not included in any other file src/providers/providers.h and src/sss_client/protos.h First one is removed in attached patch and second one was commented with "#if 0" more then four years ago. But I am not sure it should be removed (is it documentation?), the

Re: [SSSD] [PATCH 1/2] Reuse sss_open_cloexec at other places in code.

2013-03-12 Thread Ondrej Kos
On 03/11/2013 04:58 PM, Lukas Slebodnik wrote: On (11/03/13 15:26), Ondrej Kos wrote: On 03/11/2013 11:42 AM, Lukas Slebodnik wrote: On (11/03/13 10:48), Ondrej Kos wrote: On 03/11/2013 10:22 AM, Lukas Slebodnik wrote: diff --git a/src/util/util.h b/src/util/util.h index 8afb3bc964dfc7ea5deb

Re: [SSSD] [PATCH] Removing unused header file providers.h

2013-03-12 Thread Sumit Bose
On Tue, Mar 12, 2013 at 10:57:38AM +0100, Lukas Slebodnik wrote: > Hi, > > I found two header files, which are not included in any other file > src/providers/providers.h and src/sss_client/protos.h > First one is removed in attached patch and second one was commented > with "#if 0" more then four

[SSSD] [PATCH] Fix initialization of multiple variables

2013-03-12 Thread Ondrej Kos
Hi, While trying to figure culprit of #1833 and trying all possible optimization levels, I noticed several uninitialized variable warnings. Attached patch fixes those. Ondra -- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech phone: +420-532-294-558 cell: +420-736-41

Re: [SSSD] rawhide test failure: krb5-utils-tests

2013-03-12 Thread Sumit Bose
On Tue, Mar 12, 2013 at 10:25:04AM +0100, Lukas Slebodnik wrote: > On (11/03/13 19:33), Stephen Gallagher wrote: > >On 03/11/2013 05:31 PM, Nathaniel McCallum wrote: > >> http://koji.fedoraproject.org/koji/taskinfo?taskID=5108784 > >> > > > >Most likely https://fedorahosted.org/sssd/ticket/1833 >

Re: [SSSD] [PATCH] Removing unused header file providers.h

2013-03-12 Thread Simo Sorce
On Tue, 2013-03-12 at 12:13 +0100, Sumit Bose wrote: > On Tue, Mar 12, 2013 at 10:57:38AM +0100, Lukas Slebodnik wrote: > > Hi, > > > > I found two header files, which are not included in any other file > > src/providers/providers.h and src/sss_client/protos.h > > First one is removed in attached

Re: [SSSD] [PATCH] BUILD: Fix cmocka

2013-03-12 Thread Pavel Březina
On 03/12/2013 09:33 AM, Lukas Slebodnik wrote: On (11/03/13 15:04), Pavel Brezina wrote: - Original Message - From: "Stephen Gallagher" To: "Development of the System Security Services Daemon" Sent: Monday, March 11, 2013 5:38:30 PM Subject: [SSSD] [PATCH] BUILD: Fix cmocka -BEG

Re: [SSSD] [PATCH] Removing unused header file providers.h

2013-03-12 Thread Lukas Slebodnik
On (12/03/13 09:01), Simo Sorce wrote: >On Tue, 2013-03-12 at 12:13 +0100, Sumit Bose wrote: >> On Tue, Mar 12, 2013 at 10:57:38AM +0100, Lukas Slebodnik wrote: >> > Hi, >> > >> > I found two header files, which are not included in any other file >> > src/providers/providers.h and src/sss_client/p

Re: [SSSD] [PATCH] Fix initialization of multiple variables

2013-03-12 Thread Michal Židek
On 03/12/2013 01:07 PM, Ondrej Kos wrote: diff --git a/src/providers/krb5/krb5_renew_tgt.c b/src/providers/krb5/krb5_renew_tgt.c index e8957484286b34781f66d5dc43efdf4a3dab4530..f593edb506b4e207f6cdc786bf144fd04ea7f51c 100644 --- a/src/providers/krb5/krb5_renew_tgt.c +++ b/src/providers/krb5/k

Re: [SSSD] [PATCH] Fix initialization of multiple variables

2013-03-12 Thread Ondrej Kos
On 03/12/2013 02:47 PM, Michal Židek wrote: On 03/12/2013 01:07 PM, Ondrej Kos wrote: diff --git a/src/providers/krb5/krb5_renew_tgt.c b/src/providers/krb5/krb5_renew_tgt.c index e8957484286b34781f66d5dc43efdf4a3dab4530..f593edb506b4e207f6cdc786bf144fd04ea7f51c 100644 --- a/src/providers/krb5/k

Re: [SSSD] [PATCH] Removing unused header file providers.h

2013-03-12 Thread Ondrej Kos
On 03/12/2013 02:23 PM, Lukas Slebodnik wrote: On (12/03/13 09:01), Simo Sorce wrote: On Tue, 2013-03-12 at 12:13 +0100, Sumit Bose wrote: On Tue, Mar 12, 2013 at 10:57:38AM +0100, Lukas Slebodnik wrote: Hi, I found two header files, which are not included in any other file src/providers/prov

Re: [SSSD] [PATCH] Fix initialization of multiple variables

2013-03-12 Thread Michal Židek
On 03/12/2013 03:03 PM, Ondrej Kos wrote: On 03/12/2013 02:47 PM, Michal Židek wrote: On 03/12/2013 01:07 PM, Ondrej Kos wrote: diff --git a/src/providers/krb5/krb5_renew_tgt.c b/src/providers/krb5/krb5_renew_tgt.c index e8957484286b34781f66d5dc43efdf4a3dab4530..f593edb506b4e207f6cdc786bf144fd

[SSSD] [PATCH] fix segfault in nss responder unit test

2013-03-12 Thread Pavel Březina
From f53b1740387e99d6d7b5d0f8c1654e888d00b383 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 12 Mar 2013 15:24:05 +0100 Subject: [PATCH] fix segfault in nss responder unit test https://fedorahosted.org/sssd/ticket/1833 state is expected to be a pointer --- src/tests

Re: [SSSD] [PATCH] fix segfault in nss responder unit test

2013-03-12 Thread Ondrej Kos
On 03/12/2013 03:28 PM, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/1833 state is expected to be a pointer good catch Ack Ondra -- Ondrej Kos Associate Software Engineer Identity Management Red Hat Czech phone: +420-532-294-558 cell: +420-736-417-909 ext: 82-62558 loc: 1

[SSSD] [PATCH] build: require libcmocka on fedora 18+

2013-03-12 Thread Pavel Březina
From a19fcc0aefc6e386dd74b775c3e8f1c8f07af825 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 12 Mar 2013 15:37:35 +0100 Subject: [PATCH] build: require libcmocka on fedora 18+ --- contrib/sssd.spec.in | 4 1 file changed, 4 insertions(+) diff --git a/contrib/s

Re: [SSSD] [PATCH] fix segfault in nss responder unit test

2013-03-12 Thread Lukas Slebodnik
On (12/03/13 15:38), Ondrej Kos wrote: >On 03/12/2013 03:28 PM, Pavel Březina wrote: >>https://fedorahosted.org/sssd/ticket/1833 >> >>state is expected to be a pointer > >good catch > >Ack > >Ondra > It works for me too. LS ___ sssd-devel mailing list s

Re: [SSSD] [PATCH] build: require libcmocka on fedora 18+

2013-03-12 Thread Lukas Slebodnik
On (12/03/13 16:15), Pavel Březina wrote: > >From a19fcc0aefc6e386dd74b775c3e8f1c8f07af825 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Pavel=20B=C5=99ezina?= >Date: Tue, 12 Mar 2013 15:37:35 +0100 >Subject: [PATCH] build: require libcmocka on fedora 18+ > >--- > contrib/sssd.spec.in | 4 > 1 fi

Re: [SSSD] [PATCH] build: require libcmocka on fedora 18+

2013-03-12 Thread Pavel Březina
On 03/12/2013 04:24 PM, Lukas Slebodnik wrote: On (12/03/13 16:15), Pavel Březina wrote: From a19fcc0aefc6e386dd74b775c3e8f1c8f07af825 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Tue, 12 Mar 2013 15:37:35 +0100 Subject: [PATCH] build: require libcmocka on fedora 18