Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 08:56:01PM +0100, Jakub Hrozek wrote: > OK, in general this plan sounds good. I have amended the design page > again: > https://fedorahosted.org/sssd/wiki/DesignDocs/ActiveDirectoryDNSUpdates?action=diff&version=9&old_version=8 Sorry, that edit was incomplete. Please see th

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 03:21:39PM -0400, Simo Sorce wrote: > On Mon, 2013-03-18 at 20:04 +0100, Jakub Hrozek wrote: > > On Mon, Mar 18, 2013 at 02:25:15PM -0400, Simo Sorce wrote: > > > On Mon, 2013-03-18 at 18:47 +0100, Jakub Hrozek wrote: > > > > On Mon, Mar 18, 2013 at 10:27:13AM -0400, Simo So

Re: [SSSD] SSSD Test Suite Coverage

2013-03-18 Thread Jakub Hrozek
On Tue, Mar 19, 2013 at 12:31:09AM +0530, Abhishek Singh wrote: > Changes done. > > My public repo of sssd : https://github.com/AbhishekKumarSingh/sssd > Hi Abhishek, this is much better, thank you! I only have two minor style nitpicks now: 1) void test_check_if_uid_is_active_success(void ** s

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Simo Sorce
On Mon, 2013-03-18 at 20:04 +0100, Jakub Hrozek wrote: > On Mon, Mar 18, 2013 at 02:25:15PM -0400, Simo Sorce wrote: > > On Mon, 2013-03-18 at 18:47 +0100, Jakub Hrozek wrote: > > > On Mon, Mar 18, 2013 at 10:27:13AM -0400, Simo Sorce wrote: > > > > On Mon, 2013-03-18 at 15:09 +0100, Jakub Hrozek w

Re: [SSSD] SSSD Test Suite Coverage

2013-03-18 Thread Simo Sorce
On Tue, 2013-03-19 at 00:31 +0530, Abhishek Singh wrote: > Changes done. > > > My public repo of sssd : https://github.com/AbhishekKumarSingh/sssd > Thanks Abhishek, in the futurte can you send the patch attached as type text/plain, apparently you are sending it as application/octet-stream and

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 02:25:15PM -0400, Simo Sorce wrote: > On Mon, 2013-03-18 at 18:47 +0100, Jakub Hrozek wrote: > > On Mon, Mar 18, 2013 at 10:27:13AM -0400, Simo Sorce wrote: > > > On Mon, 2013-03-18 at 15:09 +0100, Jakub Hrozek wrote: > > > > On Mon, Mar 18, 2013 at 08:29:48AM -0400, Simo So

Re: [SSSD] SSSD Test Suite Coverage

2013-03-18 Thread Abhishek Singh
Changes done. My public repo of sssd : https://github.com/AbhishekKumarSingh/sssd On Mon, Mar 18, 2013 at 7:02 PM, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/18/2013 09:17 AM, Abhishek Singh wrote: > > Hi Jackub, > > > > I have attached a patch. Kindly

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Simo Sorce
On Mon, 2013-03-18 at 18:47 +0100, Jakub Hrozek wrote: > On Mon, Mar 18, 2013 at 10:27:13AM -0400, Simo Sorce wrote: > > On Mon, 2013-03-18 at 15:09 +0100, Jakub Hrozek wrote: > > > On Mon, Mar 18, 2013 at 08:29:48AM -0400, Simo Sorce wrote: > > > > On Mon, 2013-03-18 at 09:46 +0100, Jakub Hrozek w

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 10:27:13AM -0400, Simo Sorce wrote: > On Mon, 2013-03-18 at 15:09 +0100, Jakub Hrozek wrote: > > On Mon, Mar 18, 2013 at 08:29:48AM -0400, Simo Sorce wrote: > > > On Mon, 2013-03-18 at 09:46 +0100, Jakub Hrozek wrote: > > > > > > > > I'm all for generic shared code, but the

Re: [SSSD] [PATCH] BUILD: Always run distcheck and RPM tests in /dev/shm

2013-03-18 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/18/2013 10:48 AM, Stephen Gallagher wrote: > Some of the tests (such as the sysdb tests) are highly I/O > limited. By running them on a ramdisk, we can significantly speed > up the test runs when doing a distcheck or RPM build. > > The RPM specf

[SSSD] [PATCH] BUILD: Always run distcheck and RPM tests in /dev/shm

2013-03-18 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Some of the tests (such as the sysdb tests) are highly I/O limited. By running them on a ramdisk, we can significantly speed up the test runs when doing a distcheck or RPM build. The RPM specfile is not conditionalized like the Makefile because it is

Re: [SSSD] [PATCH] Decrease krb5_auth_timeout default

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 01:13:28PM +0100, Jakub Hrozek wrote: > On Mon, Mar 18, 2013 at 12:59:41PM +0100, Jakub Hrozek wrote: > > On Mon, Mar 11, 2013 at 11:31:47AM +0100, Ondrej Kos wrote: > > > Hi, > > > > > > Patch for https://fedorahosted.org/sssd/ticket/1738 is attached > > > > > > > Ack, b

Re: [SSSD] [PATCHES] SELinux processing related patches

2013-03-18 Thread Michal Židek
On 03/18/2013 12:03 PM, Jakub Hrozek wrote: On Fri, Mar 08, 2013 at 09:10:24PM +0100, Michal Židek wrote: On Mon, Mar 04, 2013 at 04:13:31PM +0100, Michal Židek wrote: On 03/04/2013 02:53 PM, Pavel Březina wrote: On 03/01/2013 04:13 PM, Michal Židek wrote: Patch 1: Right now, we have SELinux

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Simo Sorce
On Mon, 2013-03-18 at 15:09 +0100, Jakub Hrozek wrote: > On Mon, Mar 18, 2013 at 08:29:48AM -0400, Simo Sorce wrote: > > On Mon, 2013-03-18 at 09:46 +0100, Jakub Hrozek wrote: > > > > > > I'm all for generic shared code, but then it would sound like even > > > LDAP > > > provider for instance supp

Re: [SSSD] [PATCH] support local users as member of remote ldap server

2013-03-18 Thread Simo Sorce
On Mon, 2013-03-18 at 11:42 +0100, Jakub Hrozek wrote: > On Fri, Mar 15, 2013 at 09:45:26PM -0400, Simo Sorce wrote: > > This works only for rfc2307 schema. > > > > Resolves https://fedorahosted.org/sssd/ticket/1020 > > > > Simo. > > > > -- > > Simo Sorce * Red Hat, Inc * New York > > > I hav

Re: [SSSD] [PATCH] Remove duplicate remake from bashrc_sssd

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 09:14:47AM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Mon 18 Mar 2013 08:20:27 AM EDT, Jakub Hrozek wrote: > > I was building my own custom aliases on top of the bashrc_sssd and > > I noticed that the remake alias is duplicated.

Re: [SSSD] [PATCH] Retry the correct service on krb5 child timeout

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 01:28:53PM +0100, Ondrej Kos wrote: > On 03/18/2013 12:52 PM, Jakub Hrozek wrote: > >We were resolving a different service than we should have been. > > Ack Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahos

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 08:29:48AM -0400, Simo Sorce wrote: > On Mon, 2013-03-18 at 09:46 +0100, Jakub Hrozek wrote: > > > > I'm all for generic shared code, but then it would sound like even > > LDAP > > provider for instance supports the dynamic updates.. > > This would be a positive feature im

Re: [SSSD] SSSD Test Suite Coverage

2013-03-18 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/18/2013 09:17 AM, Abhishek Singh wrote: > Hi Jackub, > > I have attached a patch. Kindly check it. > > thanks, > An excellent start, Abhishek! I have a few comments (mostly style): Please make sure to maintain the same whitespace that was

Re: [SSSD] SSSD Test Suite Coverage

2013-03-18 Thread Abhishek Singh
Hi Jackub, I have attached a patch. Kindly check it. thanks, On Mon, Mar 18, 2013 at 6:23 PM, Abhishek Singh < abhishekkumarsingh@gmail.com> wrote: > Hi Jackub, > > I have attached cmocka test for 'find_uid.c' and coverage report. Kindly > review it. > > thanks, > Abhishek > > > On Wed, Ma

Re: [SSSD] [PATCH] Remove duplicate remake from bashrc_sssd

2013-03-18 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon 18 Mar 2013 08:20:27 AM EDT, Jakub Hrozek wrote: > I was building my own custom aliases on top of the bashrc_sssd and > I noticed that the remake alias is duplicated. > Oops, I meant to remove that one when I translated it into clean && chmake

Re: [SSSD] SSSD Test Suite Coverage

2013-03-18 Thread Abhishek Singh
Hi Jackub, I have attached cmocka test for 'find_uid.c' and coverage report. Kindly review it. thanks, Abhishek On Wed, Mar 6, 2013 at 1:36 AM, Abhishek Singh < abhishekkumarsingh@gmail.com> wrote: > Hi Jackub, > > May be you can include the attached file here > http://jhrozek.fedorapeople

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Simo Sorce
On Mon, 2013-03-18 at 09:46 +0100, Jakub Hrozek wrote: > > I'm all for generic shared code, but then it would sound like even > LDAP > provider for instance supports the dynamic updates.. This would be a positive feature imo. > also the ipa_ > options are already there and we should support them

Re: [SSSD] [PATCH] Retry the correct service on krb5 child timeout

2013-03-18 Thread Ondrej Kos
On 03/18/2013 12:52 PM, Jakub Hrozek wrote: We were resolving a different service than we should have been. Ack ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] Remove duplicate remake from bashrc_sssd

2013-03-18 Thread Jakub Hrozek
I was building my own custom aliases on top of the bashrc_sssd and I noticed that the remake alias is duplicated. >From d603cb0ad0630b8bd9b50e104ccd79ac59461e73 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 18 Mar 2013 13:19:03 +0100 Subject: [PATCH] Remove duplicate remake from bashrc_ss

Re: [SSSD] [PATCH] Decrease krb5_auth_timeout default

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 12:59:41PM +0100, Jakub Hrozek wrote: > On Mon, Mar 11, 2013 at 11:31:47AM +0100, Ondrej Kos wrote: > > Hi, > > > > Patch for https://fedorahosted.org/sssd/ticket/1738 is attached > > > > Ack, but I had to apply a patch I just sent to the list to get around a > sssd_be se

[SSSD] [PATCH] tests: Print warning if LDB_MODULES_PATH is not set

2013-03-18 Thread Michal Židek
"make check" sets the LDB_MODULES_PATH automatically, but if run as individual tests, the environment variable must be set manually, otherwise the system memberof.so is used. This patch adds warning if the default system memberof.so is used in sysdb-tests and sysdb_ssh-tests. Patch attached. Mic

Re: [SSSD] [PATCH] Decrease krb5_auth_timeout default

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 11, 2013 at 11:31:47AM +0100, Ondrej Kos wrote: > Hi, > > Patch for https://fedorahosted.org/sssd/ticket/1738 is attached > Ack, but I had to apply a patch I just sent to the list to get around a sssd_be segfault in case the child segfaulted. _

[SSSD] [PATCH] Retry the correct service on krb5 child timeout

2013-03-18 Thread Jakub Hrozek
We were resolving a different service than we should have been. >From 4b74672bbbfa7e7721a4d5dfaefcd505baac6d62 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 18 Mar 2013 12:37:01 +0100 Subject: [PATCH] Retry the correct service on krb5 child timeout --- src/providers/krb5/krb5_auth.c | 2

Re: [SSSD] [PATCHES] SELinux processing related patches

2013-03-18 Thread Jakub Hrozek
On Fri, Mar 08, 2013 at 09:10:24PM +0100, Michal Židek wrote: > >On Mon, Mar 04, 2013 at 04:13:31PM +0100, Michal Židek wrote: > >>On 03/04/2013 02:53 PM, Pavel Březina wrote: > >>>On 03/01/2013 04:13 PM, Michal Židek wrote: > Patch 1: Right now, we have SELinux procesing split between the prov

Re: [SSSD] [PATCH] support local users as member of remote ldap server

2013-03-18 Thread Jakub Hrozek
On Fri, Mar 15, 2013 at 09:45:26PM -0400, Simo Sorce wrote: > This works only for rfc2307 schema. > > Resolves https://fedorahosted.org/sssd/ticket/1020 > > Simo. > > -- > Simo Sorce * Red Hat, Inc * New York I haven't tested the patches yet, but the option is missing from man pages and confi

Re: [SSSD] [PATCH] Making the ldb check configurable

2013-03-18 Thread Jakub Hrozek
On Wed, Mar 13, 2013 at 11:23:07AM +0100, Lukas Slebodnik wrote: > Hi, > > attached patch should fix ticket > https://fedorahosted.org/sssd/ticket/1813 > > Comments welcomed. > > LS > From a2dca2e1a5be39ce9208ccc44ed10092f4080ea9 Mon Sep 17 00:00:00 2001 > From: Lukas Slebodnik > Date: Wed, 13

Re: [SSSD] [PATCH] Fix broken client in master

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 09:47:13AM +0100, Lukas Slebodnik wrote: > On (16/03/13 15:46), Simo Sorce wrote: > >On Sat, 2013-03-16 at 15:40 +0100, Lukas Slebodnik wrote: > >> On (16/03/13 14:38), Lukas Slebodnik wrote: > >> >On (15/03/13 21:35), Simo Sorce wrote: > >> >>Fixes https://fedorahosted.org/

Re: [SSSD] [PATCH] Fix coverity issue 13136

2013-03-18 Thread Jakub Hrozek
On Mon, Mar 18, 2013 at 10:38:35AM +0100, Jakub Hrozek wrote: > On Wed, Mar 13, 2013 at 04:34:51PM +0100, Ondrej Kos wrote: > > Hi, > > > > Attached find patch for https://fedorahosted.org/sssd/ticket/1811 > > > > Ack Pushed to master. ___ sssd-devel

Re: [SSSD] [PATCH] Fix coverity issue 13136

2013-03-18 Thread Jakub Hrozek
On Wed, Mar 13, 2013 at 04:34:51PM +0100, Ondrej Kos wrote: > Hi, > > Attached find patch for https://fedorahosted.org/sssd/ticket/1811 > Ack ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/

Re: [SSSD] [PATCH] Removing unused declaration of functions and variable.

2013-03-18 Thread Jakub Hrozek
On Wed, Mar 13, 2013 at 01:59:05PM +0100, Lukas Slebodnik wrote: > Hello, > > everything important is in subject. > > LS > extern struct dp_option default_krb5_opts[]; > extern struct sss_krb5_cc_be file_cc; > -extern struct sss_krb5_cc_be dir_cc; You can also remove file_cc here. ___

Re: [SSSD] [PATCH] support local users as member of remote ldap server

2013-03-18 Thread Lukas Slebodnik
On (15/03/13 21:45), Simo Sorce wrote: >This works only for rfc2307 schema. > >Resolves https://fedorahosted.org/sssd/ticket/1020 > >Simo. > >-- >Simo Sorce * Red Hat, Inc * New York >From ab8786126f1467c7b889598961b75c40f8fdafa5 Mon Sep 17 00:00:00 2001 >From: Simo Sorce >Date: Fri, 15 Mar 2013

Re: [SSSD] [PATCH] Fix broken client in master

2013-03-18 Thread Lukas Slebodnik
On (16/03/13 15:46), Simo Sorce wrote: >On Sat, 2013-03-16 at 15:40 +0100, Lukas Slebodnik wrote: >> On (16/03/13 14:38), Lukas Slebodnik wrote: >> >On (15/03/13 21:35), Simo Sorce wrote: >> >>Fixes https://fedorahosted.org/sssd/ticket/1838 >> >> >> >>Simo. >> >> >> >>-- >> >>Simo Sorce * Red Hat,

Re: [SSSD] Design Discussion: Active Directory DNS updates

2013-03-18 Thread Jakub Hrozek
On Sun, Mar 10, 2013 at 09:46:49AM -0400, Simo Sorce wrote: > Excellent Design page, comments in line. > > On Fri, 2013-03-08 at 23:15 +0100, Jakub Hrozek wrote: > > Hi, > > > > I have created a design page to discuss DNS updates of Active Directory > > clients: > > https://fedorahosted.org/sssd/