Re: [SSSD] [PATCH] refactor nested group processing

2013-03-22 Thread Lukas Slebodnik
On (21/03/13 16:10), Pavel Březina wrote: >On 03/21/2013 03:43 PM, Lukas Slebodnik wrote: >>On (22/02/13 13:46), Pavel Brezina wrote: >>>- Original Message - From: "Pavel Březina" To: sssd-devel@lists.fedorahosted.org Sent: Thursday, February 21, 2013 11:43:26 AM Subject: [

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Abhishek Singh
patches attached. On Sat, Mar 23, 2013 at 12:46 AM, Abhishek Singh < abhishekkumarsingh@gmail.com> wrote: > combined unit test patch for find_uid and io added. > > > On Sat, Mar 23, 2013 at 12:17 AM, Abhishek Singh < > abhishekkumarsingh@gmail.com> wrote: > >> changes done. >> >> >> On S

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Abhishek Singh
combined unit test patch for find_uid and io added. On Sat, Mar 23, 2013 at 12:17 AM, Abhishek Singh < abhishekkumarsingh@gmail.com> wrote: > changes done. > > > On Sat, Mar 23, 2013 at 12:07 AM, Stephen Gallagher > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 03/22

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Abhishek Singh
changes done. On Sat, Mar 23, 2013 at 12:07 AM, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 03/22/2013 02:33 PM, Abhishek Singh wrote: > > New tests added to success tests. Please review it. > > > > Almost :) > > You can't just test for integer equivalence,

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2013 02:33 PM, Abhishek Singh wrote: > New tests added to success tests. Please review it. > Almost :) You can't just test for integer equivalence, because it's conceivable that there may be other flags returned beyond just the FD_CLOEXEC f

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Abhishek Singh
New tests added to success tests. Please review it. Thanks, On Fri, Mar 22, 2013 at 4:48 PM, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On Fri 22 Mar 2013 04:32:52 AM EDT, Abhishek Singh wrote: > > > > Hi, > > > > I have attached a patch that contains cmocka

[SSSD] [PATCH] Use UPN from Kerberos ticket

2013-03-22 Thread Sumit Bose
Hi, this patch should fix https://fedorahosted.org/sssd/ticket/1634 and eliminates the need to guess the UPN in the PAC responder. bye, Sumit From 7351471575460f5aa0b487ee9c3108fa1a117e8f Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Mon, 9 Jul 2012 11:01:25 +0200 Subject: [PATCH] Use UPN from

Re: [SSSD] [PATCH] Incorrect *.py[co] files placement

2013-03-22 Thread Jakub Hrozek
On Wed, Mar 20, 2013 at 07:05:49PM +0100, Lukas Slebodnik wrote: > Package sssd contains python files. Python files which are not packaged > in noarch package must be installed in ${python_sitearch} directory > and not in ${python_sitelib} directory > > Autoconf detected variable $(pyexecdir) is e

Re: [SSSD] [PATCH 2/2] Making the authtok structure really opaque.

2013-03-22 Thread Jakub Hrozek
On Fri, Mar 22, 2013 at 09:19:13AM +0100, Lukas Slebodnik wrote: > On (21/03/13 20:18), Jakub Hrozek wrote: > >On Wed, Mar 20, 2013 at 07:17:28PM +0100, Lukas Slebodnik wrote: > >> On (20/03/13 13:58), Jakub Hrozek wrote: > >> >On Fri, Mar 15, 2013 at 12:46:34PM +0100, Ondrej Kos wrote: > >> >> On

Re: [SSSD] [PATCH] Provide libnl3 support

2013-03-22 Thread Jakub Hrozek
On Fri, Mar 22, 2013 at 10:57:18AM +0100, Ondrej Kos wrote: > Hi, > > Thanks for the review, new patch is attached. Almost there. See inline for a couple of last requests. > --- a/contrib/sssd.spec.in > +++ b/contrib/sssd.spec.in > @@ -122,14 +122,17 @@ BuildRequires: libselinux-devel > BuildRe

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri 22 Mar 2013 04:32:52 AM EDT, Abhishek Singh wrote: > > Hi, > > I have attached a patch that contains cmocka unittest for io.c . > Kindly review it. > This is a good start, but I'd like to see some more comprehensive tests. In the success t

Re: [SSSD] [PATCH] Provide libnl3 support

2013-03-22 Thread Ondrej Kos
On 03/21/2013 05:46 PM, Jakub Hrozek wrote: On Thu, Mar 21, 2013 at 05:21:09PM +0100, Jakub Hrozek wrote: On Thu, Mar 21, 2013 at 03:25:16PM +0100, Ondrej Kos wrote: On 03/07/2013 08:39 PM, Jakub Hrozek wrote: On Thu, Mar 07, 2013 at 02:17:19PM +0100, Ondrej Kos wrote: Hi, Attached find patc

Re: [SSSD] SSSD Test Suite Coverage

2013-03-22 Thread Abhishek Singh
Hi, I have attached a patch that contains cmocka unittest for io.c . Kindly review it. thanks On Tue, Mar 19, 2013 at 12:52 AM, Jakub Hrozek wrote: > On Tue, Mar 19, 2013 at 12:31:09AM +0530, Abhishek Singh wrote: > > Changes done. > > > > My public repo of sssd : https://github.com/AbhishekK

Re: [SSSD] [PATCH 2/2] Making the authtok structure really opaque.

2013-03-22 Thread Lukas Slebodnik
On (21/03/13 20:18), Jakub Hrozek wrote: >On Wed, Mar 20, 2013 at 07:17:28PM +0100, Lukas Slebodnik wrote: >> On (20/03/13 13:58), Jakub Hrozek wrote: >> >On Fri, Mar 15, 2013 at 12:46:34PM +0100, Ondrej Kos wrote: >> >> On 03/15/2013 10:34 AM, Lukas Slebodnik wrote: >> >> >On (15/03/13 09:13), Ond