Re: [SSSD] SSSD Test Suite Coverage

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 02:44:47AM +0530, Abhishek Singh wrote: > Hi Jakub, > > I have done requested changes and have attached the patch with this mail. > Kindly review it. > > thanks, > > Hi Abhishek, this is much better and we're almost there. I only have a couple of comments before I push

Re: [SSSD] [PATCHES] ding-libs coverity issues

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 11:55:46PM +0200, Jakub Hrozek wrote: > On Wed, Apr 03, 2013 at 04:21:30PM -0400, Dmitri Pal wrote: > > On 04/03/2013 06:37 AM, Ondrej Kos wrote: > > > Hi, > > > > > > Attached patches fix the following tickets filed as coverity issues: > > > > > > https://fedorahosted.org/s

Re: [SSSD] [PATCHES] ding-libs coverity issues

2013-04-04 Thread Jakub Hrozek
On Wed, Apr 03, 2013 at 04:21:30PM -0400, Dmitri Pal wrote: > On 04/03/2013 06:37 AM, Ondrej Kos wrote: > > Hi, > > > > Attached patches fix the following tickets filed as coverity issues: > > > > https://fedorahosted.org/sssd/ticket/1856 > > https://fedorahosted.org/sssd/ticket/1858 > > https://fe

Re: [SSSD] [PATCH] INI: Remove dead code

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 01:11:23PM -0400, Dmitri Pal wrote: > On 04/04/2013 06:25 AM, Ondrej Kos wrote: > > On 04/03/2013 10:39 PM, Dmitri Pal wrote: > >> On 04/03/2013 07:36 AM, Ondrej Kos wrote: > >>> Hi, > >>> > >>> Issue found by coverity, the code itself was inaccessibile. > >>> > >>> https://

Re: [SSSD] [PATCH] LDAP: Fix value initialization warnings

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 12:12:19PM +0200, Ondrej Kos wrote: > On 04/04/2013 11:31 AM, Jakub Hrozek wrote: > >On Thu, Apr 04, 2013 at 11:17:05AM +0200, Jakub Hrozek wrote: > >>On Thu, Apr 04, 2013 at 08:57:03AM +0200, Lukas Slebodnik wrote: > >>>On (03/04/13 14:13), Lukas Slebodnik wrote: > hi,

Re: [SSSD] [PATCH] LDAP: Fix value initialization warnings

2013-04-04 Thread Jakub Hrozek
On Wed, Apr 03, 2013 at 03:14:08PM +0200, Ondrej Kos wrote: > On 04/03/2013 02:13 PM, Lukas Slebodnik wrote: > >hi, > > > >There are no more any warnings in fedora 19 with attached patches. > >I think, that they are false positive, but I don't like warnings. > > > >LS > > > > > > > >___

[SSSD] [PATCH] add libcmocka in BUILD.txt

2013-04-04 Thread Ariel Barria
Patch for Add libcmocka in the list the dependency to remove warning in the building sssd. 0001-add-libcmocka-in-BUILD.txt.patch Description: Binary data ___ sssd-devel mailing list sssd-devel@lists.fedorahost

Re: [SSSD] [PATCH] INI: Remove dead code

2013-04-04 Thread Dmitri Pal
On 04/04/2013 06:25 AM, Ondrej Kos wrote: > On 04/03/2013 10:39 PM, Dmitri Pal wrote: >> On 04/03/2013 07:36 AM, Ondrej Kos wrote: >>> Hi, >>> >>> Issue found by coverity, the code itself was inaccessibile. >>> >>> https://fedorahosted.org/sssd/ticket/1857 >>> >>> Patch is attached >>> >>> Ondra >>

[SSSD] [PATCH] Thighten up become_user()

2013-04-04 Thread Simo Sorce
Commit should say it all. We do not have any security issue (that I know off) with the current code, but I want to tighten up the privileges more given we do not need the additional capabilities in the krb5_child anyway. Simo. -- Simo Sorce * Red Hat, Inc * New York >From 0349a5aef2b81a367dc2c08

Re: [SSSD] [PATCH] Fix krbcc dir creation issue with MIT krb5 1.11

2013-04-04 Thread Simo Sorce
On Thu, 2013-04-04 at 12:14 +0200, Lukas Slebodnik wrote: > ehlo, > > In krb5-libs 1.11, function krb5_cc_resolve verify if credential cache dir > exists. If it doesn't exist, than it will be created. We > have to ensure, that it will be created with right uid, gid and permissions. > > There is c

[SSSD] [PATCH] Allow using flatname for subdomain home dir template

2013-04-04 Thread Jakub Hrozek
Currently the default is the same as it used to. Shall I also change the default? I know there are already people using the trusts out there, so I didn't want to disrupt their environment. >From b451c6d00fe2861948d1cc60f6a213a95ca531f1 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 4 Apr 2

Re: [SSSD] [PATCH] Fix krbcc dir creation issue with MIT krb5 1.11

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 12:14:31PM +0200, Lukas Slebodnik wrote: > ehlo, > > In krb5-libs 1.11, function krb5_cc_resolve verify if credential cache dir > exists. If it doesn't exist, than it will be created. We > have to ensure, that it will be created with right uid, gid and permissions. > > The

Re: [SSSD] [PATCH] INI: Remove dead code

2013-04-04 Thread Ondrej Kos
On 04/03/2013 10:39 PM, Dmitri Pal wrote: On 04/03/2013 07:36 AM, Ondrej Kos wrote: Hi, Issue found by coverity, the code itself was inaccessibile. https://fedorahosted.org/sssd/ticket/1857 Patch is attached Ondra ___ sssd-devel mailing list sssd

[SSSD] [PATCH] Fix krbcc dir creation issue with MIT krb5 1.11

2013-04-04 Thread Lukas Slebodnik
ehlo, In krb5-libs 1.11, function krb5_cc_resolve verify if credential cache dir exists. If it doesn't exist, than it will be created. We have to ensure, that it will be created with right uid, gid and permissions. There is check in krb_auth_send, whether cached user data in ldb contains SYSDB_CC

Re: [SSSD] [PATCH] LDAP: Fix value initialization warnings

2013-04-04 Thread Ondrej Kos
On 04/04/2013 11:31 AM, Jakub Hrozek wrote: On Thu, Apr 04, 2013 at 11:17:05AM +0200, Jakub Hrozek wrote: On Thu, Apr 04, 2013 at 08:57:03AM +0200, Lukas Slebodnik wrote: On (03/04/13 14:13), Lukas Slebodnik wrote: hi, There are no more any warnings in fedora 19 with attached patches. I think

Re: [SSSD] [PATCH] LDAP: Fix value initialization warnings

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 11:17:05AM +0200, Jakub Hrozek wrote: > On Thu, Apr 04, 2013 at 08:57:03AM +0200, Lukas Slebodnik wrote: > > On (03/04/13 14:13), Lukas Slebodnik wrote: > > >hi, > > > > > >There are no more any warnings in fedora 19 with attached patches. > > >I think, that they are false p

Re: [SSSD] [PATCH] LDAP: Fix value initialization warnings

2013-04-04 Thread Jakub Hrozek
On Thu, Apr 04, 2013 at 08:57:03AM +0200, Lukas Slebodnik wrote: > On (03/04/13 14:13), Lukas Slebodnik wrote: > >hi, > > > >There are no more any warnings in fedora 19 with attached patches. > >I think, that they are false positive, but I don't like warnings. > > > >LS > > I found another initial